decomp(aes): match AESiEncryptBlock and AESiDecryptBlock, link aes; idct dataflow #1311
Reference in New Issue
Block a user
Delete Branch "agent/w0929/o2-aes-idct-land"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
worker 33aab024. instruction-exact functions: 9/9 instruction-exact functions: 0/2 gate: 0 regressions, 0 forbidden, 0 readability, dol sha1 26116613f624061ba99c8d1a299aaa6efa85670d
Graphify reviewed this change.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Graphify review — findings
Marks
net/aes.casMatchingso the AES unit now builds and links against the matched objects. Adds an__rlwinmintrinsic declaration alongside__rlwimifor code that needs explicit rotate-and-mask codegen. ReshufflesTMCJPEGDEC_IdctBlock_Lumi's locals and statement order toward the original compiler output, with per-row scoped temporaries and precomputedpitch2–pitch7row offsets, while keeping the same IDCT math.Review partial — this diff was larger than one review pass covers, so later files were not reviewed; some findings may be missing.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 55 functions depend on the 41 functions this change touches.
Health — grade C; 10 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):
CDBRecordDecrypt()— 2 callers, 27 callees (high)CDBDatabaseSearchRecordLayer()— 1 callers, 31 callees (high)CDBDatabaseSearchDayLayer()— 1 callers, 24 callees (high)CDBDatabaseSearchMonthLayer()— 1 callers, 24 callees (high)CDBDatabaseSearchYearLayer()— 1 callers, 24 callees (high)CDBRecordEncrypt()— 1 callers, 23 callees (high)CDBDatabaseSearchHourLayer()— 1 callers, 22 callees (high)CDBDatabaseSearchMinuteLayer()— 1 callers, 22 callees (high)Verification — 55 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):