decomp(aes): match AESiEncryptBlock and AESiDecryptBlock, link aes; idct dataflow #1311

Merged
coah80 merged 1 commits from agent/w0929/o2-aes-idct-land into main 2026-10-09 08:11:17 +00:00
coah80 commented 2026-10-09 08:11:14 +00:00 (Migrated from github.com)

worker 33aab024. instruction-exact functions: 9/9 instruction-exact functions: 0/2 gate: 0 regressions, 0 forbidden, 0 readability, dol sha1 26116613f624061ba99c8d1a299aaa6efa85670d

worker 33aab024. instruction-exact functions: 9/9 instruction-exact functions: 0/2 gate: 0 regressions, 0 forbidden, 0 readability, dol sha1 26116613f624061ba99c8d1a299aaa6efa85670d
graphify-labs[bot] (Migrated from github.com) reviewed 2026-10-09 08:15:35 +00:00
graphify-labs[bot] (Migrated from github.com) left a comment

Graphify reviewed this change.

Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).


Graphify review — findings

Marks net/aes.c as Matching so the AES unit now builds and links against the matched objects. Adds an __rlwinm intrinsic declaration alongside __rlwimi for code that needs explicit rotate-and-mask codegen. Reshuffles TMCJPEGDEC_IdctBlock_Lumi's locals and statement order toward the original compiler output, with per-row scoped temporaries and precomputed pitch2–pitch7 row offsets, while keeping the same IDCT math.

Review partial — this diff was larger than one review pass covers, so later files were not reviewed; some findings may be missing.

Analysis details — impact, health, verification

Impact & health

Graphify review

Impact — 55 functions depend on the 41 functions this change touches.

Health — grade C; 10 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):

  • CDBRecordDecrypt() — 2 callers, 27 callees (high)
  • CDBDatabaseSearchRecordLayer() — 1 callers, 31 callees (high)
  • CDBDatabaseSearchDayLayer() — 1 callers, 24 callees (high)
  • CDBDatabaseSearchMonthLayer() — 1 callers, 24 callees (high)
  • CDBDatabaseSearchYearLayer() — 1 callers, 24 callees (high)
  • CDBRecordEncrypt() — 1 callers, 23 callees (high)
  • CDBDatabaseSearchHourLayer() — 1 callers, 22 callees (high)
  • CDBDatabaseSearchMinuteLayer() — 1 callers, 22 callees (high)
  • …and 2 more

Verification — 55 functions in the blast radius were not formally verified this run (proofs are advisory here).

Gate & verification

graphify gate

PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 44 function(s) in the blast radius were not formally verified this run
<!-- graphify-inline:39d15fcc27b32c3f06241be6e47e62824d778409 --> **Graphify reviewed this change.** **Looks safe to merge** — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment). --- ## Graphify review — findings Marks `net/aes.c` as `Matching` so the AES unit now builds and links against the matched objects. Adds an `__rlwinm` intrinsic declaration alongside `__rlwimi` for code that needs explicit rotate-and-mask codegen. Reshuffles `TMCJPEGDEC_IdctBlock_Lumi`'s locals and statement order toward the original compiler output, with per-row scoped temporaries and precomputed `pitch2`–`pitch7` row offsets, while keeping the same IDCT math. _Review partial — this diff was larger than one review pass covers, so later files were not reviewed; some findings may be missing._ <details> <summary>Analysis details — impact, health, verification</summary> ### Impact & health ## Graphify review **Impact** — 55 functions depend on the 41 functions this change touches. **Health** — grade C; 10 existing hotspot(s) in the area this change touches (pre-existing, not introduced here): - `CDBRecordDecrypt()` — 2 callers, 27 callees (high) - `CDBDatabaseSearchRecordLayer()` — 1 callers, 31 callees (high) - `CDBDatabaseSearchDayLayer()` — 1 callers, 24 callees (high) - `CDBDatabaseSearchMonthLayer()` — 1 callers, 24 callees (high) - `CDBDatabaseSearchYearLayer()` — 1 callers, 24 callees (high) - `CDBRecordEncrypt()` — 1 callers, 23 callees (high) - `CDBDatabaseSearchHourLayer()` — 1 callers, 22 callees (high) - `CDBDatabaseSearchMinuteLayer()` — 1 callers, 22 callees (high) - …and 2 more **Verification** — 55 functions in the blast radius were not formally verified this run (proofs are advisory here). ### Gate & verification ## graphify gate **PASS** — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed. Advisory (not blocking): - verification_scope: 44 function(s) in the blast radius were not formally verified this run </details>
Sign in to join this conversation.