[codex] Match RVLFaceLib system unit #166

Merged
coah80 merged 1 commits from agent/worker60/rfl-controller into main 2026-09-22 08:05:57 +00:00
coah80 commented 2026-09-22 08:05:22 +00:00 (Migrated from github.com)

What changed

Match RVLFaceLib's internal system helpers by making four helpers static inline. The source stays readable while the emitted function set matches the original object.

Validation

  • RFL_System objdiff: 100% fuzzy; code 2880/2880, data 252/252, functions 28/28, and 1/1 complete unit.
  • Every owned section is exact: .data, .sbss, .sdata, .text, extab, and extabindex all report 100%.
  • pool_diff.py: POOL IDENTICAL up to 1 (mine=1 base=1).
  • ctxdiff.py: all 28 RFL_System symbols have identical instruction counts and diffs 0.
  • python3 configure.py --version 43U and the full Ninja link/DOL build passed.
  • git diff --check passed.
  • The repository-wide build/43U/ok gate remains blocked by the current aggregate DOL SHA1 7d018a2cbd5ee0ee61e4ecedf4b7bd9006aca877 versus configured 26116613f624061ba99c8d1a299aaa6efa85670d; the owned RFL_System unit is exact.

Note

Make RVLFaceLib system unit helpers file-local with static inline

Marks RFLiBootLoad, RFLiBootLoadAsync, RFLiGetUsedWorkSize, and RFLiCriticalError in RFL_System.c as static inline, restricting their linkage to the translation unit. Their implementations and behavior are unchanged. Risk: any out-of-tree code relying on external linkage of these RFLi* helpers will fail to link.

Macroscope summarized 3285798.

## What changed Match RVLFaceLib's internal system helpers by making four helpers `static inline`. The source stays readable while the emitted function set matches the original object. ## Validation - `RFL_System` objdiff: 100% fuzzy; code 2880/2880, data 252/252, functions 28/28, and 1/1 complete unit. - Every owned section is exact: `.data`, `.sbss`, `.sdata`, `.text`, `extab`, and `extabindex` all report 100%. - `pool_diff.py`: `POOL IDENTICAL up to 1 (mine=1 base=1)`. - `ctxdiff.py`: all 28 `RFL_System` symbols have identical instruction counts and `diffs 0`. - `python3 configure.py --version 43U` and the full Ninja link/DOL build passed. - `git diff --check` passed. - The repository-wide `build/43U/ok` gate remains blocked by the current aggregate DOL SHA1 `7d018a2cbd5ee0ee61e4ecedf4b7bd9006aca877` versus configured `26116613f624061ba99c8d1a299aaa6efa85670d`; the owned RFL_System unit is exact. <!-- Macroscope's pull request summary starts here --> <!-- Macroscope will only edit the content between these invisible markers, and the markers themselves will not be visible in the GitHub rendered markdown. --> <!-- If you delete either of the start / end markers from your PR's description, Macroscope will append its summary at the bottom of the description. --> > [!NOTE] > ### Make RVLFaceLib system unit helpers file-local with `static inline` > Marks `RFLiBootLoad`, `RFLiBootLoadAsync`, `RFLiGetUsedWorkSize`, and `RFLiCriticalError` in [RFL_System.c](https://github.com/coah80/wii-ipl/pull/166/files#diff-d74ab6389205a4f4d220b93d254098e35dd1c0df56cf451564c801ba7b63dd82) as `static inline`, restricting their linkage to the translation unit. Their implementations and behavior are unchanged. Risk: any out-of-tree code relying on external linkage of these `RFLi*` helpers will fail to link. > > <!-- Macroscope's review summary starts here --> > > <sup><a href="https://app.macroscope.com">Macroscope</a> summarized 3285798.</sup> > <!-- Macroscope's review summary ends here --> > <!-- Macroscope's pull request summary ends here -->
Sign in to join this conversation.