[codex] match ESMisc savedata deletion #2

Merged
coah80 merged 1 commits from codex/worker2-delete-savedata-20260921 into main 2026-09-21 19:27:29 +00:00
coah80 commented 2026-09-21 19:03:59 +00:00 (Migrated from github.com)

Summary

  • Match ipl::utility::ESMisc::DeleteSavedata(ESTitleId, EGG::Heap*) to the 43U reference object.
  • Preserve the compiler’s source order by declaring ret after the savedata traversal state and making the loop index increment explicit before strlen.

Validation

  • Baseline fuzzy_match_percent: 97.439026
  • Candidate fuzzy_match_percent: 100.0
  • pool_diff.py ran before ctxdiff.py; the target function’s string region is unchanged and the first pool divergence is after this function.
  • ctxdiff.py: diffs 0
  • ninja build/43U/src/src/utility/iplESMisc.o: passed
  • git diff --check: passed

This PR changes only src/utility/iplESMisc.cpp and targets main.

Note

Adjust ESMisc::DeleteSavedata loop and variable order

Moves the return-status declaration below other locals and changes the deletion loop to increment its index in the body after each entry is processed, instead of in the loop header. This aligns the implementation with the original codex version.

Macroscope summarized 336b26f.

## Summary - Match `ipl::utility::ESMisc::DeleteSavedata(ESTitleId, EGG::Heap*)` to the 43U reference object. - Preserve the compiler’s source order by declaring `ret` after the savedata traversal state and making the loop index increment explicit before `strlen`. ## Validation - Baseline `fuzzy_match_percent`: `97.439026` - Candidate `fuzzy_match_percent`: `100.0` - `pool_diff.py` ran before `ctxdiff.py`; the target function’s string region is unchanged and the first pool divergence is after this function. - `ctxdiff.py`: `diffs 0` - `ninja build/43U/src/src/utility/iplESMisc.o`: passed - `git diff --check`: passed This PR changes only `src/utility/iplESMisc.cpp` and targets `main`. <!-- Macroscope's pull request summary starts here --> <!-- Macroscope will only edit the content between these invisible markers, and the markers themselves will not be visible in the GitHub rendered markdown. --> <!-- If you delete either of the start / end markers from your PR's description, Macroscope will append its summary at the bottom of the description. --> > [!NOTE] > ### Adjust `ESMisc::DeleteSavedata` loop and variable order > Moves the return-status declaration below other locals and changes the deletion loop to increment its index in the body after each entry is processed, instead of in the loop header. This aligns the implementation with the original codex version. > > <!-- Macroscope's review summary starts here --> > > <sup><a href="https://app.macroscope.com">Macroscope</a> summarized 336b26f.</sup> > <!-- Macroscope's review summary ends here --> > <!-- Macroscope's pull request summary ends here -->
Sign in to join this conversation.