Revert padding/asm-hack links from #225, #229, #230 #232

Merged
coah80 merged 3 commits from agent/w0929/revert-devin-hacks into main 2026-09-28 19:15:37 +00:00
coah80 commented 2026-09-28 19:15:30 +00:00 (Migrated from github.com)

reverts #225, #229 and #230. they got the dol hash right but mostly by faking the layout instead of decompiling:

  • iplChannelTitle / iplBoardObject: ~90 dummy static const f32 padN __attribute__((section(".data"), aligned(1), used)) = 0.0f; objects (plus .sdata byte pads) just to push later data to the right addresses
  • iplController: 10 more functions turned into inline asm
  • iplBoard: volatile locals to force the interrupt states onto the stack
  • iplChannelSelect: DECOMP_FORCE_ACTIVE on a dead sbss symbol
  • eggAudioExpMgr: a made up Sample subclass that exists only to flip the @52@ thunk order
  • iplSaveDataManager: only links by shuffling the existing asm blocks around

AGENTS.md says no artificial assembly or layout tricks, so these go back to NonMatching/Equivalent and get redone properly in follow-up PRs. source tree after this is identical to b1fd4041 (pre-#225) plus the #231 tools fix

gates (fresh orchestrator build)

  • clean ninja build/43U/ok passes, main.dol sha1 26116613f624061ba99c8d1a299aaa6efa85670d
  • full ninja passes
  • report: linked code 58.48% -> 55.18% (expected, those links were fake), fuzzy 65.27% unchanged, matched data 72.11% -> 72.18%
reverts #225, #229 and #230. they got the dol hash right but mostly by faking the layout instead of decompiling: - iplChannelTitle / iplBoardObject: ~90 dummy `static const f32 padN __attribute__((section(".data"), aligned(1), used)) = 0.0f;` objects (plus .sdata byte pads) just to push later data to the right addresses - iplController: 10 more functions turned into inline asm - iplBoard: `volatile` locals to force the interrupt states onto the stack - iplChannelSelect: `DECOMP_FORCE_ACTIVE` on a dead sbss symbol - eggAudioExpMgr: a made up `Sample` subclass that exists only to flip the `@52@` thunk order - iplSaveDataManager: only links by shuffling the existing asm blocks around AGENTS.md says no artificial assembly or layout tricks, so these go back to NonMatching/Equivalent and get redone properly in follow-up PRs. source tree after this is identical to b1fd4041 (pre-#225) plus the #231 tools fix gates (fresh orchestrator build) - clean `ninja build/43U/ok` passes, main.dol sha1 `26116613f624061ba99c8d1a299aaa6efa85670d` - full ninja passes - report: linked code 58.48% -> 55.18% (expected, those links were fake), fuzzy 65.27% unchanged, matched data 72.11% -> 72.18%
Sign in to join this conversation.