Link fa/msc puh_msc + puh_msc_cmd + msc_drv (clean subset) #449

Merged
devin-ai-integration[bot] merged 1 commits from agent/w0929/misc1-clean into main 2026-10-01 04:37:58 +00:00
devin-ai-integration[bot] commented 2026-10-01 04:37:54 +00:00 (Migrated from github.com)

Summary

Clean subset of agent/w0929/misc1 — links 3 units, all verified metadata.complete: true / fuzzy 100.0 on current main:

  • fa/msc/puh_msc.c, fa/msc/puh_msc_cmd.c
  • fa/driver/msc_drv.c — g_attach_func/g_detach_func static declaration order swap fixes .sbss emission order (MWCC emits in reverse declaration order)

Carries memoryCard decode progress on still-NonMatching units: DigitTable struct-copy idiom for digit tables (show_capacity, GCWindow init), create_icon frame<<1 shift + <=8 loop bound, update_icon_anm icon->anmMax pointer-path, iplMemoryCardBase.h NOVTABLE-removal for embedded-MI-base vptr suppression (keeps iplGCSaveData complete: ctor 158/158). puh_msc_blk.c decode improvements come along (99.45 fuzzy, stays NonMatching).

Verified: ninja clean; build/43U/main.dol sha1 26116613f624061ba99c8d1a299aaa6efa85670d; fresh objdiff report confirms every flipped unit complete: true. No shims.

Link to Devin session: https://app.devin.ai/sessions/222dce3cd2364f14bc9a8d5ef82cda00
Open in Devin Desktop: https://app.devin.ai/desktop/session/222dce3cd2364f14bc9a8d5ef82cda00?variant=devin
Requested by: @coah80

## Summary Clean subset of `agent/w0929/misc1` — links 3 units, all verified `metadata.complete: true` / fuzzy 100.0 on current main: - `fa/msc/puh_msc.c`, `fa/msc/puh_msc_cmd.c` - `fa/driver/msc_drv.c` — `g_attach_func`/`g_detach_func` static declaration order swap fixes `.sbss` emission order (MWCC emits in reverse declaration order) Carries memoryCard decode progress on still-`NonMatching` units: DigitTable struct-copy idiom for digit tables (`show_capacity`, GCWindow `init`), `create_icon` frame<<1 shift + <=8 loop bound, `update_icon_anm` `icon->anmMax` pointer-path, `iplMemoryCardBase.h` NOVTABLE-removal for embedded-MI-base vptr suppression (keeps `iplGCSaveData` complete: ctor 158/158). `puh_msc_blk.c` decode improvements come along (99.45 fuzzy, stays NonMatching). Verified: `ninja` clean; `build/43U/main.dol` sha1 `26116613f624061ba99c8d1a299aaa6efa85670d`; fresh objdiff report confirms every flipped unit `complete: true`. No shims. Link to Devin session: https://app.devin.ai/sessions/222dce3cd2364f14bc9a8d5ef82cda00 Open in Devin Desktop: https://app.devin.ai/desktop/session/222dce3cd2364f14bc9a8d5ef82cda00?variant=devin Requested by: @coah80
devin-ai-integration[bot] commented 2026-10-01 04:37:58 +00:00 (Migrated from github.com)

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring
<!-- devin-pr-monitoring-controls --> I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)". - [ ] Disable automatic comment, CI, and merge conflict monitoring
Sign in to join this conversation.