cleanup(bte): name HCI/UUSB vendorId productId taskId #940

Closed
coah80 wants to merge 1 commits from cleanup/bte-usb-ids into main
coah80 commented 2026-10-02 19:42:49 +00:00 (Migrated from github.com)

Summary

  • tHCI_CFG::at_0x00/02 → vendorId/productId (init {2652, 8449} = Broadcom USB IDs)
  • tUUSB::at_0x04/06/08 → vendorId/productId/taskId (copied in hcisu_h2_open)
  • tUUSB::at_0x0b → pad_0x0b (only cleared)

Verification

  • ninja all_source build/43U/ok
  • DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d
  • hcisu_h2 / bte_main Matching 100%
## Summary - `tHCI_CFG::at_0x00/02` → `vendorId`/`productId` (init `{2652, 8449}` = Broadcom USB IDs) - `tUUSB::at_0x04/06/08` → `vendorId`/`productId`/`taskId` (copied in `hcisu_h2_open`) - `tUUSB::at_0x0b` → `pad_0x0b` (only cleared) ## Verification - `ninja all_source build/43U/ok` - DOL sha1 `26116613f624061ba99c8d1a299aaa6efa85670d` - `hcisu_h2` / `bte_main` Matching 100%
coah80 commented 2026-10-02 19:48:18 +00:00 (Migrated from github.com)

Orchestrator review (automatic): the gate flags a forbidden pattern. For cleanup PRs this is almost always a field renamed to pad*, padding*, unused* or dummy*: those names are reserved for catching fake padding objects. Keep unk_0xNN or use a descriptive name (e.g. reserved) and push; the daemon re-gates automatically.

Orchestrator review (automatic): the gate flags a forbidden pattern. For cleanup PRs this is almost always a field renamed to `pad*`, `padding*`, `unused*` or `dummy*`: those names are reserved for catching fake padding objects. Keep `unk_0xNN` or use a descriptive name (e.g. `reserved`) and push; the daemon re-gates automatically.
coah80 commented 2026-10-09 18:07:35 +00:00 (Migrated from github.com)

Merged via #1358 (rebased onto current main; the written byte at 0x0b is named reserved instead of pad_0x0b because the code stores to it). DOL unchanged.

Merged via #1358 (rebased onto current main; the written byte at 0x0b is named `reserved` instead of `pad_0x0b` because the code stores to it). DOL unchanged.

Pull request closed

Sign in to join this conversation.