decomp: align EXIF rational denominator address structure #992

Merged
coah80 merged 1 commits from agent/bittle/exif-rational-address into main 2026-10-02 23:37:40 +00:00
coah80 commented 2026-10-02 23:35:46 +00:00 (Migrated from github.com)

Reconstruction

Two source-line reconstruction: group offset+4 before adding thumbnailData for IFD0 rational denominator reads, matching the original address-expression structure. This leaves scalar decoding, numerator writes, denominator reads and error paths intact.

  • IFD0:99.386696%→99.49065%;480/481 instructions (still partial)
  • Unit:98.94104%→98.98035%;3/6 exact and1348/5088 exact bytes preserved
  • Parent reran267,282 paired compiled-PPC EXIF calls, including tags, both byte orders, rational bounds, directory cases and42 overlapping version-copy cases; all passed
  • Bounded interpreter evidence, not formal equivalence or Wii hardware validation
  • All3 exact functions retain ctxdiff zero; no allocated data changes; only same-sized EXIF .text changes among1027 source objects, no report regressions
  • Pool identical(no strings), full43U build and required DOL SHA1 pass

No IFD1 const change: separate read-only overlap audit did not justify it. No new exact function or linking claim. Historical base in attempt log is the worker's baseline; current parent validation below supersedes it.

Parent validation baseline

Rebased and independently rebuilt on main 13881c99fb. Tested tree 825b60254c.
DOL SHA1:26116613f624061ba99c8d1a299aaa6efa85670d. Worktree/diff checks pass. User requested decompilation first, matching next and linking last. No merge performed or requested by this author.

Note

Align EXIF rational denominator address math with original in TMCJPEGDEC_IFD0_tag_parse

Regroups the X- and Y-resolution denominator address calculations so the four-byte offset is applied before adding the thumbnail-data base, matching the original function. Removes a redundant pointer cast.

Macroscope summarized 89c2c17.

## Reconstruction Two source-line reconstruction: group offset+4 before adding thumbnailData for IFD0 rational denominator reads, matching the original address-expression structure. This leaves scalar decoding, numerator writes, denominator reads and error paths intact. - IFD0:99.386696%→99.49065%;480/481 instructions (still partial) - Unit:98.94104%→98.98035%;3/6 exact and1348/5088 exact bytes preserved - Parent reran267,282 paired compiled-PPC EXIF calls, including tags, both byte orders, rational bounds, directory cases and42 overlapping version-copy cases; all passed - Bounded interpreter evidence, not formal equivalence or Wii hardware validation - All3 exact functions retain ctxdiff zero; no allocated data changes; only same-sized EXIF .text changes among1027 source objects, no report regressions - Pool identical(no strings), full43U build and required DOL SHA1 pass No IFD1 const change: separate read-only overlap audit did not justify it. No new exact function or linking claim. Historical base in attempt log is the worker's baseline; current parent validation below supersedes it. ## Parent validation baseline Rebased and independently rebuilt on main 13881c99fb2f3df970ea5c4308f0aaa063a931b1. Tested tree 825b60254cd48acd7f0f85312864b7bbede6eeff. DOL SHA1:26116613f624061ba99c8d1a299aaa6efa85670d. Worktree/diff checks pass. User requested decompilation first, matching next and linking last. No merge performed or requested by this author. <!-- Macroscope's pull request summary starts here --> <!-- Macroscope will only edit the content between these invisible markers, and the markers themselves will not be visible in the GitHub rendered markdown. --> <!-- If you delete either of the start / end markers from your PR's description, Macroscope will append its summary at the bottom of the description. --> > [!NOTE] > ### Align EXIF rational denominator address math with original in `TMCJPEGDEC_IFD0_tag_parse` > Regroups the X- and Y-resolution denominator address calculations so the four-byte offset is applied before adding the thumbnail-data base, matching the original function. Removes a redundant pointer cast. > - Adds a reconstruction log and validation report covering rejected trials, differential test counts, instruction coverage, and the DOL hash in [jpeg-next-reconstruction-attempts.md](https://github.com/coah80/wii-ipl/pull/992/files#diff-b7112a452e284526fa66e2313da8577bf1d8a5003e3121b8a5063c390d170f79) and [jpeg-next-reconstruction-validation.txt](https://github.com/coah80/wii-ipl/pull/992/files#diff-cfc31538089f555445dcb06d70823da78d1a4d4519962a966e3eeb99fcc02d81) > > <!-- Macroscope's review summary starts here --> > > <sup><a href="https://app.macroscope.com">Macroscope</a> summarized 89c2c17.</sup> > <!-- Macroscope's review summary ends here --> > <!-- Macroscope's pull request summary ends here -->
coah80 commented 2026-10-02 23:37:38 +00:00 (Migrated from github.com)

Reviewed and merged: rebased on main, full build ok, DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d, 0 regressions, 0 forbidden patterns.

Reviewed and merged: rebased on main, full build ok, DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d, 0 regressions, 0 forbidden patterns.
Sign in to join this conversation.