478 Commits

Author SHA1 Message Date
coah
a764ab3331 cleanup(chansvm): typed buffers and names (worker 4b37bd69) (#1376) 2026-10-09 14:54:26 -05:00
coah
7a44876cbd decomp(system): warning_run in C (asm placeholder removed) (worker d00a2f20) (#1368) 2026-10-09 14:19:16 -05:00
coah
c8b2789812 cleanup: name placeholder struct members in headers (worker 6bc18d30) (#1359) 2026-10-09 13:08:40 -05:00
coah
c8c8a71e22 decomp(tistring): match inputChar and link tiString (last function) (worker b9cb2697) (#1336) 2026-10-09 12:07:31 -05:00
coah
f7f36d59f8 decomp: pair array destructor, name StandData, real Queue push/pop (section scores 100%) (worker 674f53ed) (#1335) 2026-10-09 09:27:07 -05:00
coah
da26714711 decomp(inputform): link tiInputForm (target definition order, vtable ownership, Sample class, dead-stripped helper stand-in) (worker c64933ad) (#1332) 2026-10-09 08:55:57 -05:00
coah
12e857a9e2 decomp(inputform): match LayoutByNW4R::create (tiInputForm 221/221 exact) (worker f17f914e) (#1329) 2026-10-09 07:38:59 -05:00
coah
5046adc6da decomp(inputform): calcCursorPos and create structure (93.05 -> 99.88, 96.40 -> 98.16) (worker 00d2d4a1) (#1317) 2026-10-09 03:49:47 -05:00
coah
47fe453260 decomp(sdmemory): match drawTransferTitles and link iplSDMemory; loadCardFileIcons 213 -> 126 (worker 76898382) (#1313) 2026-10-09 03:14:07 -05:00
coah
2d4cfa7094 decomp(mcm): match _create_icon and link iplMemoryCardManager; pdm MBR reads (worker a7a698b7) (#1312) 2026-10-09 03:12:24 -05:00
coah
e27d9e090a decomp(aes): match AESiEncryptBlock and AESiDecryptBlock, link aes; idct dataflow (worker 33aab024) (#1311) 2026-10-09 03:11:17 -05:00
coah
55891734ae fix(chansvm): use compatible const converter callback types (#1307) 2026-10-08 22:46:39 -05:00
coah
2a7cc791b1 decomp(sdmemory): drawTransferTitles via MSL wcsstr overload and TextBox::SetTextColor (363->50) (worker 9b634499) (#1305) 2026-10-08 22:23:33 -05:00
coah
10146c1b5f decomp(candidatebox): match createAnmPane_ and link tiCandidateBox (worker 6dca7c84) (#1300) 2026-10-08 21:23:21 -05:00
coah
da1c3b7ff8 decomp(address): link iplAddressEdit (definition order, get_button_no table) (worker d1e93825) (#1287) 2026-10-08 18:45:56 -05:00
coah
fa8632368e decomp: replace balloon margin comma-expression hack with TextBalloon::getDefaultMargin getters (worker 383d17df) (#1281) 2026-10-08 18:28:39 -05:00
coah
dc7725eb2d decomp(address): match AddressEdit::create (worker 68baf5e3) (#1280) 2026-10-08 18:26:09 -05:00
coah
f49f337c6b decomp(aoss): match AOSSSendHelloRequest; move packet state and CRC table into AOSSData.c (proven .bss ownership) (worker 1df7b1d6) (#1267) 2026-10-08 14:52:49 -05:00
coah
af7146a850 decomp: SDChannelSelect collectTitles functions exact; link iplSDChannelSelect (worker 654f9547) (#1259) 2026-10-08 13:45:52 -05:00
coah
f9ebd2f4cc refactor: drop per-unit novtable switches that change no object (worker 94d1c9c8) (#1257) 2026-10-08 13:33:40 -05:00
coah
c3dbaf8c8e refactor(board): write the stripped URL extension check instead of forcing its strings (grok-focus) (worker a5dca043) (#1245) 2026-10-06 13:52:09 -05:00
coah
7c6393f96c refactor(parental): write the stripped settings dump instead of forcing its strings (grok-parental) (worker 3c180d67) (#1244) 2026-10-06 13:48:10 -05:00
coah
1fd0970728 refactor(ESMisc): write the stripped DeleteSharedContent instead of forcing its strings (grok-esmisc) (worker 30ed7895) (#1243) 2026-10-06 13:42:17 -05:00
coah
f18082e88b refactor: remove remaining force-retention and placement tricks where the build is unchanged (rx67) (worker 719f7d50) (#1232) 2026-10-05 13:31:52 -05:00
coah
f0722e8397 refactor(scene,system): named constants and cast cleanup in memory card, SD memory and system files (rx40) (worker 7ff7f6b8) (#1217) 2026-10-05 08:17:56 -05:00
coah
901fe02868 refactor: name remaining placeholder fields and locals across 148 files (rx22) (worker 45545207) (#1205) 2026-10-05 06:51:22 -05:00
coah
efa1859f6c decomp(memoryCard): match create_banner with banner texture helpers (rx7 astra max) (worker e78a3a35) (#1201) 2026-10-05 06:13:44 -05:00
coah
6b57fb49a1 refactor: name placeholder fields in browser, TVRC, NHTTP and keyboard utilities; reformat NHTTP stdlib (rx21) (worker a5a11fba) (#1200) 2026-10-05 06:07:08 -05:00
coah
3620369944 refactor: name placeholder members in Setting, ChannelSelect, ChannelTitle and utilities (rx20) (worker f8ebca28) (#1199) 2026-10-05 06:01:41 -05:00
coah
c9860af4e9 link(keyboard): link tiCellPhone and tiSignWindow (function order, inline constructors) (rx6 astra max) (worker 6439ed29) (#1194) 2026-10-05 05:02:05 -05:00
coah
21c5ceda39 fix(Button): make friend declaration consistent across translation units (#1178) 2026-10-04 23:10:42 -05:00
coah
7b29f284c1 decomp: six asm bodies rewritten in C++ (sound, GUI, TVRC, button, channel select, input form) (da7 astra max) (worker 08481d4a) (#1176) 2026-10-04 22:25:10 -05:00
coah
ca031bd8ff decomp(MemoryCard): card-thread shared fields are volatile; match isBannerEnable and getBlocks (lv19 astra max) (worker 912ee959) (#1169) 2026-10-04 21:09:01 -05:00
coah
60341ca483 decomp(CdbBackup): C++ backup tasks with a volatile completion flag (orch) (worker e4439837) (#1165) 2026-10-04 20:42:50 -05:00
coah
491bba6ae3 decomp(Address): match start_drag_event through the portrait accessor and root-pane lookup (f5 astra max) (worker 1a15738b) (#1159) 2026-10-04 19:03:19 -05:00
coah
db6157b693 decomp(tiZiString): split candidate buffers at original boundaries, match clearCandidates and setElementBuffer (agg astra max) (worker 8cb13c23) (#1145) 2026-10-03 16:58:37 -05:00
coah
0b671e4883 link(tiPcKeyboard): restore inline-method emission and destructor thunk order (lnkx astra xhigh) (worker 45d2d3ca) (#1135) 2026-10-03 14:50:36 -05:00
coah
7b8dbf2c96 fix(keyboard): declare cellphone reset on its owning class (#1015) 2026-10-02 20:32:23 -05:00
coah
8ffaa9d25a decomp(bs2): preserve update publications and repeated entry reads (#995) 2026-10-02 18:49:17 -05:00
devin-ai-integration[bot]
3aa9daf94a decomp: emission gates for iplSDChannelTitle + MemoryCardManager decodes (#972)
IPL_SD_CHANNEL_TITLE_CPP gates move inline members to declarations so the
TU emits non-inlined calls like retail (same dedup-loss pattern as
#834's vtable restoration): iplInterporation::get, math::VEC3 ctor,
FaderSceneBase::initCalcNormal/calcCommonAfter, SceneBase::isReady/
isResetProcessDone/getParent/getChild/getNext/getPrev, NANDTask::
isFinished/checkData, Graphics::setOrthoTrans/setOrthoScale,
ut::Rect/RuntimeTypeInfo.

Verified vs main: iplSDChannelTitle 68/69 fns byte-exact (152B tail
residual in iplSDChannelTitle_flushSaveBeforeExit), iplMemoryCardManager
18/26. Units stay NonMatching; documented walls in revisit.attempts.md.

Co-authored-by: devin <devin@cognition.ai>
Co-authored-by: coah80 <usernamecole7@gmail.com>
2026-10-02 17:22:10 -05:00
coah
255f3e0530 decomp: reconstruct ESMisc cleanup helpers and return ABI (#964) 2026-10-02 16:42:08 -05:00
coah
a2a0460567 cleanup(AudioWavePlayer): rename mbFillInCallback (#937)
unk_0xB5 → mbFillInCallback: when true MakeWave runs in the wave-packet
callback; when false it runs from update(). Ctor defaults true.
2026-10-02 14:47:25 -05:00
coah
4a046a17ab cleanup(AxAdpcmPlayer): rename VoiceInfo update sync flag (#930)
unk_0x0C / getUnk_0x0C / setUnk_0x0C → mUpdateFlag / getUpdateFlag / setUpdateFlag

Cross-thread voice sync: main sets 1, calc() promotes to 2, audio callback clears to 0.
2026-10-02 14:43:48 -05:00
coah
fd775c34dc link(iplChannelSelect: native weak vtable / Hermite emission) (link1) (worker bf02f407) (#934) 2026-10-02 14:39:44 -05:00
coah
5a332eceba cleanup(iplChannelSelect): rename ortho translate/scale fields (#922)
unk_0xD8 -> mOrthoTrans; unk_0xE4 -> mOrthoScale (setOrthoTransAndScale).
Byte-identical.
2026-10-02 14:37:03 -05:00
coah
77439a3268 cleanup(iplChannelManager): name mbDiskChannelReady (#908)
unk_0x1B81 -> mbDiskChannelReady
isUnk_0x1B81 -> isDiskChannelReady
setUnk_0x1B81 -> setDiskChannelReady

Set when BS2 enters RVL_GAME and disk banner info is applied; cleared when
disk banner data is consumed or channel UI dismisses it.

Touched channelSelect / channelTitle callers.

Matching 100% before/after; DOL sha1 unchanged.
2026-10-02 14:29:40 -05:00
coah
1f3d89772e cleanup(iplChannelScriptManager): name CSData mbHasNewMessage (#895)
unk_0x1A -> mbHasNewMessage

Set true when starting channel script, cleared when the title has no new
NWC24 message (isNewMessageThere).

Touched channelSelect / channelTitle / sdChannelTitle writers.

Matching 100% before/after; DOL sha1 unchanged.
2026-10-02 14:24:22 -05:00
coah
ab8bece04e cleanup(iplController): name decide/pinch/kpad/classic fields (#889)
unk_0x08 -> mDecideHoldCount
unk_0x1C -> mbForceInvalid
unk_0x1D -> mbPinching
unk_0x1E -> mbWasPinching
unk_0x20 -> mpKpadStatus
unk_0x24 -> mClassicCursorPos
unk_0x2C -> mClassicCursorTimer

Also update iplControllerManager ctor inits for Base fields.

Matching 100% before/after; DOL sha1 unchanged.
2026-10-02 14:20:10 -05:00
coah
0059de422f cleanup(iplSettingSelect): rename pending scene and exit sequence fields (#888)
unk_0x90 -> mPendingSceneId (SCENE_* values); unk_0x94 -> mExitSeqStep.
Also use SCENE_* constants instead of magic numbers. Byte-identical.
2026-10-02 14:19:44 -05:00
coah
73795cb3fb cleanup(ErrorHandler): name set() arg storage fields (#875)
Rename unused debug-ish stash fields to match ErrorHandler::set params:
- unk_0x14 → mArg1 (char[4] from arg1)
- unk_0x0C → mArg2
- unk_0x10 → mArg3

Verified: ErrorHandler 100%/100%, build/43U/ok, DOL sha1
26116613f624061ba99c8d1a299aaa6efa85670d
2026-10-02 14:11:44 -05:00