Compare commits

...

9 Commits

Author SHA1 Message Date
Cursor Agent
2aa13863fa Match iplMemoryCard .sdata2 (data 100%)
Append the int-to-float conversion constant that ends the original
.sdata2 for src/scene/memoryCard/iplMemoryCard.cpp. Data bytes go from
2640/2664 (99.0991%) to 2664/2664; code was already 100%.

Co-authored-by: coah <coah80@users.noreply.github.com>
2026-10-01 21:31:55 +00:00
coah
3946983f96 KPAD 19/29, kbd_lib 15/21 (objdiff) (worker 2ecd44fa) (#482) 2026-10-01 16:29:36 -05:00
github-actions[bot]
85d75cd0cf docs: update progress [skip ci] 2026-10-01 21:27:27 +00:00
coah
af39f2678f Match SD disk-info success return and restore its epilogue extent (#481)
* Restore the SD disk-info function's original epilogue extent

* Match explicit SD disk-info success return and update code total

* Match explicit SD disk-info success return and update code total
2026-10-01 16:26:40 -05:00
github-actions[bot]
d613662c54 docs: update progress [skip ci] 2026-10-01 21:17:45 +00:00
coah
0e6e235004 Correct PFSYS_TimeStamp's truncated symbol extent (#479)
* Include original stack restore and return in PFSYS_TimeStamp extent

* Account for timestamp epilogue in verified code-byte total
2026-10-01 16:17:08 -05:00
coah
020e1b6f0b iplSetting 105/112 (worker e1b8983d) (#480) 2026-10-01 16:16:23 -05:00
coah
3440aab039 Handle objects without .data in pool_diff (#478)
* Treat absent .data sections as empty string pools

* Test absent and unequal string pools
2026-10-01 16:11:01 -05:00
coah
dab806eaa2 Correct the 43U completion guard's expected unit count (#477) 2026-10-01 16:10:57 -05:00
16 changed files with 861 additions and 18 deletions

View File

@@ -53,9 +53,9 @@ Progress
<!-- progress:start -->
| Decompiled | Matched | Linked | Data |
|:---:|:---:|:---:|:---:|
| 99.37% | 87.40% | 61.64% | 91.14% |
| 99.37% | 87.47% | 61.64% | 91.14% |
units 915/1027 complete, functions 12198/12563 matched.
units 915/1027 complete, functions 12203/12563 matched.
decompiled = code with a C/C++ implementation (objdiff fuzzy), matched = byte-exact code, linked = code actually linked into the DOL, data = byte-exact data
<!-- progress:end -->

View File

@@ -13113,7 +13113,7 @@ pfstub_com_massage = .text:0x815E6C40; // type:function size:0xE4
pfstub_store_result = .text:0x815E6D24; // type:function size:0xC4
PFSYS_initializeSYS = .text:0x815E6DE8; // type:function size:0x4
PFSYS_GetCurrentContextID = .text:0x815E6DEC; // type:function size:0x18
PFSYS_TimeStamp = .text:0x815E6E04; // type:function size:0x74
PFSYS_TimeStamp = .text:0x815E6E04; // type:function size:0x7C
pfstub_call_function_standard = .text:0x815E6E80; // type:function size:0x584
pfstub_attach = .text:0x815E7404; // type:function size:0x50
pfstub_buffering = .text:0x815E7454; // type:function size:0x50
@@ -13202,7 +13202,7 @@ pfd_sddrv_pread = .text:0x815EAADC; // type:function size:0x38
pfd_sddrv_pwrite = .text:0x815EAB14; // type:function size:0x38
pfd_sddrv_unmount = .text:0x815EAB4C; // type:function size:0x34
pfd_sddrv_finalize = .text:0x815EAB80; // type:function size:0xE4
pfd_sddrv_get_disk_info = .text:0x815EAC64; // type:function size:0x180
pfd_sddrv_get_disk_info = .text:0x815EAC64; // type:function size:0x188
pfd_sddrv_init_drv_tbl = .text:0x815EADEC; // type:function size:0x18
pfd_sddrv_registar_callback = .text:0x815EAE04; // type:function size:0x10
pfd_sddrv_is_media_insert = .text:0x815EAE14; // type:function size:0x98

View File

@@ -554,7 +554,7 @@ s32 pfd_sddrv_get_disk_info(FADisk* disk, FADiskInfo* disk_info) {
disk_info->heads = 0;
disk_info->sectorsPerTrack = 0;
disk_info->formatParam = 0;
return result;
return 0;
}
s32 pfd_sddrv_init_drv_tbl(FADiskTbl* disk_table, u32 extended) {

View File

@@ -851,15 +851,15 @@ USBKBDErr KBDSetModState(u32 channel, u32 value) {
}
u16 KBDTranslateHidCode(u32 keyCode, u32 modifiers, s32 country) {
KBDKeyMap* map;
u16* table;
u32 keyIndex;
u16 entry;
s32 mask;
u16* table;
u16 activeFlag;
u16 entry;
KBDKeyMap* map;
s32 offset;
s32 group;
u32 shiftFlag;
u16 activeFlag;
u32 keyIndex;
if (kbdInitialized == FALSE) {
return 0xFFFF;
@@ -920,9 +920,9 @@ u16 KBDTranslateHidCode(u32 keyCode, u32 modifiers, s32 country) {
shiftFlag <<= offset;
activeFlag = shiftFlag;
if (mask == 0 && (activeFlag & entry) != 0) {
if (mask == 0 && (entry & activeFlag) != 0) {
offset = offset ^ ((modifiers >> 9) & 1);
} else if (mask == 0x8000 && (activeFlag & entry) != 0) {
} else if (mask == 0x8000 && (entry & activeFlag) != 0) {
u32 numLockShift = 0;
if ((s32)(modifiers & 0x100) == 0x100 && offset == 0) {
numLockShift = 1;

View File

@@ -1607,8 +1607,8 @@ static void KPADiSamplingCallback(s32 chan) {
u32 device;
if (WPADProbe(chan, &device) != -1) {
u8 index = kpad->ringIndex;
KPADSample* status;
u32 tier;
KPADSample* status;
u32 enabled;
u32 tableIndex;
if (index >= 16) {

View File

@@ -744,3 +744,6 @@ namespace ipl {
}
}
// Original .sdata2 ends with the PPC int-to-float conversion constant.
extern "C" const f64 sMemoryCardIntToFloat = 4503601774854144.0;

View File

@@ -3559,6 +3559,10 @@ namespace ipl {
}
}
static inline bool HasUSBAPResult(const u8* result) {
return *result != 0;
}
void Setting::setUSBAP() {
switch (unk_0x84) {
case 1:
@@ -3579,7 +3583,7 @@ namespace ipl {
}
break;
case 2:
if (unk_0x91C[1] != 0) {
if (HasUSBAPResult(&unk_0x91C[1])) {
www::wiisetting::setFuncResult(unk_0x91C[1]);
unk_0x84 = 1;
unk_0x91C[1] = 0;

View File

@@ -9,8 +9,8 @@ from pathlib import Path
EXPECTED_DOL_SHA1 = "26116613f624061ba99c8d1a299aaa6efa85670d"
EXPECTED_TOTAL_UNITS = 1026
EXPECTED_TOTAL_CODE = 2995172
EXPECTED_TOTAL_UNITS = 1027
EXPECTED_TOTAL_CODE = 2995188
EXPECTED_TOTAL_DATA = 1832684
EXPECTED_TOTAL_FUNCTIONS = 12563
INTEGER_PATTERN = re.compile(r"-?(0|[1-9][0-9]*)\Z")

View File

@@ -7,8 +7,10 @@ BASE = 'build/43U/obj/src/utility/iplESMisc.o'
def pool(path):
e = ELFFile(open(path, 'rb'))
sec = {s.name: s for s in e.iter_sections()}
d = sec['.data'].data()
section = e.get_section_by_name('.data')
if section is None:
return []
d = section.data()
out = []
off = 0
while off < len(d):
@@ -42,6 +44,7 @@ def main():
for j in range(n, max(len(mine), len(base))):
src = mine if j < len(mine) else base
print(' extra %3d %r' % (j, src[j][1][:70]))
return 1
return 0

View File

@@ -0,0 +1,121 @@
Baseline HEAD f4fd16f8. Current baseline report missing; nearest available ancestor 8e43db05 will be selected explicitly for gate, supplemented with current HEAD report /tmp/sol-low-start.json.
Structural diagnosis for every open function saved in /tmp/sol-low-diagnosis.
KPADGetProjectionPos | operand order: half height and pixel scale | structural/exact (0, 10) insns 19/19 | restored
KPADGetProjectionPos | target operand order: height first; pixel scale first | structural/exact (0, 10) insns 19/19 | restored
KPADGetProjectionPos | explicit double temporary initialized before products | structural/exact (0, 14) insns 19/19 | restored
reset_kpad | initialize reference distance before bounds | structural/exact (0, 10) insns 117/117 | restored
reset_kpad | expression temporary: retain numerator for both stores | structural/exact (0, 8) insns 117/117 | restored
reset_kpad | inline distance ratio and initialize reference distance | structural/exact (20, 95) insns 116/117 | restored
KPADSetSensorHeight | move channel pointer initialization ahead of constants | structural/exact (0, 7) insns 52/52 | restored
KPADSetSensorHeight | inline squares into sqrt argument | structural/exact (0, 7) insns 52/52 | restored
KPADSetSensorHeight | store center before squared intermediates | structural/exact (0, 7) insns 52/52 | restored
KPADGetProjectionPos | declaration-order search | declaration block:; f64 scaled;; f32 height = rect->bottom - rect->top;; f32 halfHeight = height * 0.5f;; f32 x = src->x * halfHeight;; f32 y = src->y * halfHeight;; start (0, 9); best (0, 9) after 23 builds; source restored; best order was:; f64 scaled;; f32 height = rect->bottom - rect->top;; f32 halfHeight = height * 0.5f;; f32 x = src->x * halfHeight;; f32 y = src->y * halfHeight;;
KPADSetSensorHeight | declaration-order search | declaration block:; KPADInside* kpad;; f32 halfHeight;; f32 barOffsetX;; f32 barDiagonal;; f32 halfWidthSquared;; f32 halfWidth;; f32 negativeSensorHeight;; f32 barDiagonalSquared;; f32 halfHeightSquared;; start (0, 7); best (0, 7) after 93 builds; source restored; best order was:; KPADInside* kpad;; f32 halfHeight;; f32 barOffsetX;; f32 barDiagonal;; f32 halfWidthSquared;; f32 halfWidth;; f32 negativeSensorHeight;; f32 barDiagonalSquared;; f32 halfHeightSquared;;
calc_acc_horizon | declaration-order search | declaration block:; f32 magnitude = (f32)sqrt(kpad->acceleration.x * kpad->acceleration.x + kpad->acceleration.y * kpad->acceleration.y);; f32 normalizedX;; f32 normalizedY;; f32 targetY;; f32 targetX;; f32 productX;; f32 oldX;; f32 oldY;; f32 blend;; f32 projectedX;; f32 smoothing;; f32 deltaX;; f32 nextX;; f32 nextY;; f32 normalized;; f32 unitX;; f32 oldCircleX;; f32 oldCircleY;; f32 unitY;; f32 circleX;; f32 deltaCircleX;; f32 circleY;; f32 deltaCircleY;; start (2, 35); improved (0, 30); improved (0, 29); best (0, 29) after 100 builds; kept in source:; f32 productX;; f32 oldX;; f32 normalizedY;; f32 targetY;; f32 targetX;; f32 magnitude = (f32)sqrt(kpad->acceleration.x * kpad->acceleration.x + kpad->acceleration.y * kpad->acceleration.y);; f32 normalizedX;; f32 oldY;; f32 blend;; f32 projectedX;; f32 smoothing;; f32 deltaX;; f32 nextX;; f32 nextY;; f32 normalized;; f32 unitX;; f32 oldCircleX;; f32 oldCircleY;; f32 unitY;; f32 circleX;; f32 deltaCircleX;; f32 circleY;; f32 deltaCircleY;;
select_1obj_first | declaration-order search | declaration block:; KPADDPDObject* object = kpad->dpdState.objects;; KPADDPDObject* end = kpad->dpdState.candidates;; f32 scale = kpad->dpdObjectScale;; f32 productX = kpad->horizonTangent.x * kpad->horizonAxis.x;; f32 productY = kpad->horizonTangent.y * kpad->horizonAxis.x;; f32 offsetX = productX + kpad->horizonTangent.y * kpad->horizonAxis.y;; f32 offsetY = productY - kpad->horizonTangent.x * kpad->horizonAxis.y;; start (2, 26); best (2, 26) after 52 builds; source restored; best order was:; KPADDPDObject* object = kpad->dpdState.objects;; KPADDPDObject* end = kpad->dpdState.candidates;; f32 scale = kpad->dpdObjectScale;; f32 productX = kpad->horizonTangent.x * kpad->horizonAxis.x;; f32 productY = kpad->horizonTangent.y * kpad->horizonAxis.x;; f32 offsetX = productX + kpad->horizonTangent.y * kpad->horizonAxis.y;; f32 offsetY = productY - kpad->horizonTangent.x * kpad->horizonAxis.y;;
kbdEventHandler | reuse report status temporary in comparisons | structural/exact (3, 148) insns 185/186 | restored
kbdEventHandler | initialize channel pointer in one expression | structural/exact (0, 6) insns 186/186 | restored
kbdEventHandler | declare report status with its first load | build failed .c -o build/43U/src/libs/RVL_SDK/src/kbd && "/usr/bin/python3" tools/transform_dep.py build/43U/src/libs/RVL_SDK/src/kbd/kbd_lib.d build/43U/src/libs/RVL_SDK/src/kbd/kbd_lib.d
### mwcceppc.exe Compiler:
# File: libs\RVL_SDK\src\kbd\kbd_lib.c
# ---------------------------------------
# 238: u8 status = bytes[2];
# Error: ^^
# (10141) expression syntax error
# Too many errors printed, aborting program
User break, cancelled...
ninja: build stopped: subcommand failed.
| restored
KBDSetModState | typed channel pointer for load and store | structural/exact (0, 7) insns 42/42 | restored
KBDSetModState | physical modifier masked expression | structural/exact (3, 7) insns 42/42 | restored
KBDSetModState | single modifier state temporary | structural/exact (0, 4) insns 42/42 | restored
kbd_led_handler | load completion callback before releasing command | structural/exact (24, 19) insns 23/25 | restored
select_1obj_continue | declaration-order search | declaration block:; KPADDPDObject* candidates = kpad->dpdState.candidates;; KPADDPDObject* candidate;; KPADDPDObject* object;; KPADDPDObject* matchedCandidate;; KPADDPDObject* source;; f32 best = kp_err_near_pos * kp_err_near_pos;; start (0, 17); best (0, 17) after 36 builds; source restored; best order was:; KPADDPDObject* candidates = kpad->dpdState.candidates;; KPADDPDObject* candidate;; KPADDPDObject* object;; KPADDPDObject* matchedCandidate;; KPADDPDObject* source;; f32 best = kp_err_near_pos * kp_err_near_pos;;
KPADInit | declaration-order search | declaration block:; KPADInside* kpad;; f32 distanceValue;; f32 sensorDistance;; f32 rotationElement;; f32 referenceWidth;; f32 referenceHeight;; f32 objectInterval;; f32 zero;; f32 degreesToRadians;; f32 one;; f32* matrix;; u32 i;; s32 chan;; BOOL enabled;; start (9, 81); improved (8, 70); improved (8, 67); improved (8, 58); improved (8, 54); improved (8, 51); best (8, 51) after 100 builds; kept in source:; f32 referenceHeight;; f32 objectInterval;; f32 sensorDistance;; f32 rotationElement;; f32 referenceWidth;; KPADInside* kpad;; f32 distanceValue;; f32 zero;; f32 degreesToRadians;; f32 one;; u32 i;; f32* matrix;; s32 chan;; BOOL enabled;;
KPADRead | declaration-order search | declaration block:; KPADInside* kpad = &inside_kpads[chan];; s32 probe;; BOOL interruptState;; u32 available = 0;; u32 ringCount;; s32 start;; s32 sampleIndex;; u32 remaining;; u32 remainingSamples;; u32 buttons;; u16 previousButtons;; u32 changed;; u32 extensionButtons;; u32 coreButtons;; u8 device;; KPADSample latestSample;; KPADSample* sample;; KPADStatus* output;; start (11, 89); improved (11, 86); improved (11, 84); best (11, 84) after 100 builds; kept in source:; KPADInside* kpad = &inside_kpads[chan];; KPADStatus* output;; BOOL interruptState;; u32 available = 0;; u32 ringCount;; s32 start;; s32 sampleIndex;; u32 remaining;; u32 remainingSamples;; s32 probe;; u16 previousButtons;; u32 changed;; u32 extensionButtons;; u32 coreButtons;; u8 device;; KPADSample latestSample;; KPADSample* sample;; u32 buttons;;
kbdProcMod | pass modifier expression directly | structural/exact (0, 4) insns 256/256 | restored
kbdProcMod | local modifier scope around inline setter | structural/exact (0, 4) insns 256/256 | restored
kbdProcMod | channel argument recovered from typed channel | structural/exact (14, 88) insns 259/256 | restored
KBDSetModState | read old union through typed field pointer | structural/exact (0, 7) insns 42/42 | restored
KBDSetModState | write new union through typed field pointer | structural/exact (0, 4) insns 42/42 | restored
KBDSetModState | reverse union temporary declaration order | structural/exact (0, 4) insns 42/42 | restored
kbd_led_handler | null callback test after clear; conditional error code | structural/exact (23, 21) insns 22/25 | restored
kbd_led_handler | guard completion body with non-null callback | structural/exact (24, 19) insns 23/25 | restored
KBDSetLedsAsync | unsigned indexed struct command loop | structural/exact (19, 72) insns 79/81 | restored
KBDSetLedsAsync | unsigned indexed loop and direct channel flags | structural/exact (19, 72) insns 79/81 | restored
KBDSetLedsAsync | unsigned counted byte offset with typed struct access | structural/exact (19, 72) insns 79/81 | restored
KBDSetLeds | unsigned indexed struct command loop | structural/exact (19, 68) insns 78/79 | restored
KBDSetLeds | unsigned indexed loop and direct flags access | structural/exact (19, 68) insns 78/79 | restored
KBDSetLeds | unsigned indexed loop; preserve allocated command pointer | structural/exact (22, 69) insns 78/79 | restored
KPADGetProjectionPos | inline double scale and target operand order | structural/exact (0, 10) insns 19/19 | restored
KPADGetProjectionPos | reuse height temporary and inline final scale | build failed c/kpad/KPAD.c -o build/43U/src/libs/RVL_SDK/src/kpad && "/usr/bin/python3" tools/transform_dep.py build/43U/src/libs/RVL_SDK/src/kpad/KPAD.d build/43U/src/libs/RVL_SDK/src/kpad/KPAD.d
### mwcceppc.exe Compiler:
# File: libs\RVL_SDK\src\kpad\KPAD.c
# -------------------------------------
# 348: f32 x = src->x * height;
# Error: ^^^
# (10141) expression syntax error
# Too many errors printed, aborting program
User break, cancelled...
ninja: build stopped: subcommand failed.
| restored
TMCJPEGDEC_IFD1_tag_parse | ignored planar configuration and contiguous EXIF tags | structural/exact (14, 226) insns 239/242 | restored
TMCJPEGDEC_IFD1_tag_parse | ignored EXIF tag range only | structural/exact (57, 219) insns 239/242 | restored
TMCJPEGDEC_IFD1_tag_parse | unsigned tag selector and ignored EXIF range | structural/exact (57, 219) insns 239/242 | restored
TMCJPEGDEC_IFD0_tag_parse | unsigned widened tag selector | structural/exact (27, 446) insns 481/481 | restored
TMCJPEGDEC_IFD0_tag_parse | signed widened tag selector | structural/exact (27, 446) insns 481/481 | restored
TMCJPEGDEC_IFD0_tag_parse | swap initial tag/type local declarations | structural/exact (29, 446) insns 481/481 | restored
TMCJPEGDEC_exif_parse | read helper boundary: standard 16-bit helper | structural/exact (0, 46) insns 212/212 | restored
TMCJPEGDEC_exif_parse | declare IFD cursor before offset | structural/exact (0, 46) insns 212/212 | restored
TMCJPEGDEC_exif_parse | reverse byte order expression operands | structural/exact (0, 46) insns 212/212 | restored
calc_acc_horizon | operand order of acceleration dot products | structural/exact (4, 37) insns 101/101 | restored
calc_acc_horizon | reuse blend for quadratic smoothing | structural/exact (2, 35) insns 101/101 | restored
calc_acc_horizon | declare magnitude after scalar intermediates | structural/exact (2, 34) insns 101/101 | restored
read_kpad_acc | stack frame local declaration order | structural/exact (32, 82) insns 400/400 | restored
read_kpad_acc | scalar smoothing: explicit pre-update delta | structural/exact (16, 66) insns 400/400 | restored
read_kpad_acc | extension stack local moved to function scope | structural/exact (16, 66) insns 400/400 | restored
select_1obj_first | offset scale operand order | structural/exact (2, 26) insns 109/109 | restored
select_1obj_first | end pointer declared before object cursor | structural/exact (4, 27) insns 109/109 | restored
select_1obj_first | candidate positions declared before coordinates | structural/exact (2, 26) insns 109/109 | restored
select_1obj_continue | offset distance first as target operands | structural/exact (0, 17) insns 93/93 | restored
select_1obj_continue | direction block local declarations before initializers | structural/exact (0, 16) insns 93/93 | restored
select_1obj_continue | inline tangent product intermediates | structural/exact (0, 19) insns 93/93 | restored
calc_dpd_variable | explicit absolute-distance branch | structural/exact (14, 45) insns 250/250 | restored
calc_dpd_variable | vector stack declaration order | structural/exact (40, 71) insns 250/250 | restored
calc_dpd_variable | reuse distance smoothing magnitude for final displacement | structural/exact (14, 43) insns 250/250 | restored
KPADRead | gravity structures declaration order | structural/exact (15, 93) insns 459/459 | restored
KPADRead | ring count clear and cursor calculation order | structural/exact (14, 89) insns 459/459 | restored
KPADRead | explicit sample selection branch | structural/exact (11, 97) insns 459/459 | restored
KPADInit | matrix base declaration order | structural/exact (9, 65) insns 185/185 | restored
KPADInit | sensor diagonal operand order | structural/exact (9, 81) insns 185/185 | restored
KPADInit | rotation temporary separated for sine and cosine | structural/exact (9, 81) insns 185/185 | restored
KPADiSamplingCallback | status pointer declared before index | structural/exact (2, 28) insns 182/182 | restored
KPADiSamplingCallback | device declared before channel state pointer | structural/exact (2, 28) insns 182/182 | restored
KPADiSamplingCallback | sensor diagonal temporary local order | structural/exact (3, 39) insns 182/182 | restored
KBDTranslateHidCode | declaration-order search | declaration block:; KBDKeyMap* map;; u16* table;; u32 keyIndex;; u16 entry;; s32 mask;; s32 offset;; s32 group;; u32 shiftFlag;; u16 activeFlag;; ; if (kbdInitialized == FALSE) {; start (0, 9); improved (0, 3); improved (0, 2); best (0, 2) after 173 builds; kept in source:; s32 mask;; u16* table;; u16 activeFlag;; u16 entry;; KBDKeyMap* map;; s32 offset;; s32 group;; u32 shiftFlag;; u32 keyIndex;; ; if (kbdInitialized == FALSE) {;
KBDTranslateHidCode | target bit-test operand order | structural/exact (0, 1) insns 164/164 | restored
KBDTranslateHidCode | both target bit-test operand orders | structural/exact (0, 0) insns 164/164 | kept
reset_kpad | initialized declarations followed by declaration search | declaration block:; f32 upperY = 0.75f;; f32 distanceValue;; f32 zero = 0.0f;; f32 sensorDistance = kpad->referenceDistance;; f32 lowerY = -0.75f;; f32 one = 1.0f;; f32 negativeOne = -1.0f;; KPADDPDObject* object;; start (0, 10); best (0, 10) after 71 builds; source restored; best order was:; f32 upperY = 0.75f;; f32 distanceValue;; f32 zero = 0.0f;; f32 sensorDistance = kpad->referenceDistance;; f32 lowerY = -0.75f;; f32 one = 1.0f;; f32 negativeOne = -1.0f;; KPADDPDObject* object;; | restored no exact gain
KBDTranslateHidCode accepted after full clean gate --base 8e43db05. Exact objdiff 100%, ctxdiff 164/164 diffs 0; kbd instruction-exact 13->14/21, objdiff functions 14->15/21, code 2432->3088/5764, data 5296/5296. Pools identical, regressions 0, forbidden 0, readability 0, target DOL SHA1 preserved.
KBDSetModState | single expression merging old physical modifiers | structural/exact (3, 7) insns 42/42 | restored
KBDSetModState | reverse physical merge operands | structural/exact (3, 7) insns 42/42 | restored
KBDSetModState | assign physical field directly from stored state | structural/exact (0, 4) insns 42/42 | restored
kbdEventHandler | remove redundant report status temporary | structural/exact (0, 5) insns 186/186 | restored
kbdEventHandler | load status before computing channel pointer | structural/exact (0, 5) insns 186/186 | restored
KPADGetProjectionPos | name pixel aspect multiplier as local | structural/exact (0, 10) insns 19/19 | restored
KPADGetProjectionPos | name both screen geometry constants | structural/exact (7, 11) insns 19/19 | restored
KPADGetProjectionPos | vector intermediate for projection scaled components | structural/exact (7, 19) insns 23/19 | restored
read_kpad_acc | final declaration search | declaration block:; Vec raw;; Vec previous;; start (16, 66); best (16, 66) after 2 builds; source restored; best order was:; Vec raw;; Vec previous;;
calc_dpd_variable | final declaration search | declaration block:; Vec2 point;; Vec2 delta;; start (14, 45); best (14, 45) after 2 builds; source restored; best order was:; Vec2 point;; Vec2 delta;;
KPADiSamplingCallback | final declaration search | declaration block:; u8 index = kpad->ringIndex;; KPADSample* status;; u32 tier;; u32 enabled;; u32 tableIndex;; start (2, 28); improved (0, 0); best (0, 0) after 6 builds; kept in source:; u8 index = kpad->ringIndex;; u32 tier;; KPADSample* status;; u32 enabled;; u32 tableIndex;;
KBDSetModState | final declaration search | declaration block:; KBDModifierState oldState;; KBDModifierState newState;; interrupts = OSDisableInterrupts();; start (0, 4); best (0, 4) after 6 builds; source restored; best order was:; KBDModifierState oldState;; KBDModifierState newState;; interrupts = OSDisableInterrupts();;
TMCJPEGDEC_exif_parse | final declaration search | declaration block:; u16 byteOrder;; u32 ifdOffset;; const u8* entries;; u16 remaining;; u16 count;; s32 entriesSize;; u16 index;; start (0, 46); improved (0, 43); best (0, 43) after 70 builds; kept in source:; u16 byteOrder;; u32 ifdOffset;; const u8* entries;; u16 remaining;; u16 index;; s32 entriesSize;; u16 count;;
kbdProcMod | register-only declaration search | declaration block:; KBDChannel* data;; u32 modState;; s32 delta;; u8 flags;; ; u32 finalState;; s8 value;; start (0, 4); best (0, 4) after 52 builds; source restored; best order was:; KBDChannel* data;; u32 modState;; s32 delta;; u8 flags;; ; u32 finalState;; s8 value;; | restored
KBDResetChannel | objdiff 100% and actual instructions identical. gate.py reports two cr1 branch differences because odiff.dis subtracts function position from the CR operand instead of the branch target; source untouched. This accounts for instruction-exact 13 versus objdiff-exact 14 at baseline, and 14 versus 15 after translation match.
KPADiSamplingCallback | accepted fresh full gate --base 8e43db05, objdiff 100%, ctxdiff 182/182 diffs 0. KPAD exact 18->19/29, matched code 5188->5916/13056, data 7912/8032 unchanged. Regressions 0, forbidden 0, readability 0, DOL SHA1 correct.
KPADInit | extract atomic object-interval update into a real inline helper before reset_kpad | 185/185 instructions, 81 differences unchanged; sdata2 order unchanged because MWCC emits helper constant at call | restored
Final audit: all 19 remaining functions have >=3 logged distinct source-level trials. Full clean combined gate over all three units PASS (--base 8e43db05), DOL SHA1 correct; no baseline or tooling edits. Independent comparison to starting HEAD report: 0 regressions, only KPAD and kbd_lib report measures changed. See sol-low-leaves-report.md for percentages, structural differences, and pre-existing cr1 normalization caveat.

View File

@@ -0,0 +1,55 @@
full build: ok
main.dol sha1: 26116613f624061ba99c8d1a299aaa6efa85670d
[libs/RVL_SDK/src/kpad/KPAD] pool: IDENTICAL
[libs/RVL_SDK/src/kpad/KPAD] objdiff: code 5916/13056 data 7912/8032 functions 19/29 fuzzy 98.5983 linked code 0
[libs/RVL_SDK/src/kpad/KPAD] instruction-exact functions: 19/29
[libs/RVL_SDK/src/kpad/KPAD] section .bss size 7680 match 100.0
[libs/RVL_SDK/src/kpad/KPAD] section .data size 88 match 100.0
[libs/RVL_SDK/src/kpad/KPAD] section .sbss size 32 match 100.0
[libs/RVL_SDK/src/kpad/KPAD] section .sdata size 112 match 100.0
[libs/RVL_SDK/src/kpad/KPAD] section .sdata2 size 120 match 93.333336
[libs/RVL_SDK/src/kpad/KPAD] section .text size 13056 match 98.59834
[libs/RVL_SDK/src/kpad/KPAD] below 100: reset_kpad 99.48718
[libs/RVL_SDK/src/kpad/KPAD] below 100: KPADGetProjectionPos 96.57895
[libs/RVL_SDK/src/kpad/KPAD] below 100: KPADSetSensorHeight 99.23077
[libs/RVL_SDK/src/kpad/KPAD] below 100: calc_acc_horizon 97.27723
[libs/RVL_SDK/src/kpad/KPAD] below 100: read_kpad_acc 98.15
[libs/RVL_SDK/src/kpad/KPAD] below 100: select_1obj_first 98.348625
[libs/RVL_SDK/src/kpad/KPAD] below 100: select_1obj_continue 98.49462
[libs/RVL_SDK/src/kpad/KPAD] below 100: calc_dpd_variable 94.82
[libs/RVL_SDK/src/kpad/KPAD] below 100: KPADRead 97.52723
[libs/RVL_SDK/src/kpad/KPAD] below 100: KPADInit 96.51351
[libs/RVL_SDK/src/kpad/KPAD] baseline: code 5188/13056 data 7912 functions 18 fuzzy 98.4972
[libs/RVL_SDK/src/kbd/kbd_lib] pool: IDENTICAL
[libs/RVL_SDK/src/kbd/kbd_lib] objdiff: code 3088/5764 data 5296/5296 functions 15/21 fuzzy 97.6523 linked code 0
[libs/RVL_SDK/src/kbd/kbd_lib] instruction-exact functions: 14/21
[libs/RVL_SDK/src/kbd/kbd_lib] section .bss size 3968 match 100.0
[libs/RVL_SDK/src/kbd/kbd_lib] section .data size 1304 match 100.0
[libs/RVL_SDK/src/kbd/kbd_lib] section .sbss size 16 match 100.0
[libs/RVL_SDK/src/kbd/kbd_lib] section .sdata size 8 match 100.0
[libs/RVL_SDK/src/kbd/kbd_lib] section .text size 5764 match 97.65233
[libs/RVL_SDK/src/kbd/kbd_lib] below 100: kbdEventHandler 99.83871
[libs/RVL_SDK/src/kbd/kbd_lib] below 100: kbdProcMod 99.90234
[libs/RVL_SDK/src/kbd/kbd_lib] below 100: kbd_led_handler 61.12
[libs/RVL_SDK/src/kbd/kbd_lib] below 100: KBDSetLedsAsync 86.234566
[libs/RVL_SDK/src/kbd/kbd_lib] below 100: KBDSetLeds 84.6076
[libs/RVL_SDK/src/kbd/kbd_lib] below 100: KBDSetModState 99.40476
[libs/RVL_SDK/src/kbd/kbd_lib] baseline: code 2432/5764 data 5296 functions 14 fuzzy 97.6176
[libs/RVLMiddleware/TMC_JPEG/src/exif/exif_parse] pool: IDENTICAL
[libs/RVLMiddleware/TMC_JPEG/src/exif/exif_parse] objdiff: code 1348/5088 data None/None functions 3/6 fuzzy 96.2893 linked code 0
[libs/RVLMiddleware/TMC_JPEG/src/exif/exif_parse] instruction-exact functions: 3/6
[libs/RVLMiddleware/TMC_JPEG/src/exif/exif_parse] section .text size 5088 match 96.28931
[libs/RVLMiddleware/TMC_JPEG/src/exif/exif_parse] below 100: TMCJPEGDEC_exif_parse 98.679245
[libs/RVLMiddleware/TMC_JPEG/src/exif/exif_parse] below 100: TMCJPEGDEC_IFD0_tag_parse 94.241165
[libs/RVLMiddleware/TMC_JPEG/src/exif/exif_parse] below 100: TMCJPEGDEC_IFD1_tag_parse 93.099174
[libs/RVLMiddleware/TMC_JPEG/src/exif/exif_parse] baseline: code 1348/5088 data None functions 3 fuzzy 96.2893
regressions vs baseline: 0
global matched_code_percent: 87.39812 -> 87.44433
global fuzzy_match_percent: 99.36627 -> 99.36678
global complete_code_percent: 61.40923 -> 61.64133
global matched_data_percent: 91.13999 -> 91.13999
forbidden patterns added (net, per file): 0
readability warnings (net, per file; must be 0 in the final result): 0
note: config touched: config/43U/splits.txt (orchestrator reviews every config/symbols change)
note: config touched: configure.py (orchestrator reviews every config/symbols change)
GATE PASS

View File

@@ -0,0 +1,48 @@
# Leaf matching result
Source commits: c012e880, 78a83518.
Full final gate: sol-low-leaves-final-gate.txt, explicitly selecting --base 8e43db05.
The current HEAD f4fd16f8 baseline file is absent. 8e43db05 is the nearest ancestor with an existing baseline; the starting HEAD report was independently saved as /tmp/sol-low-start.json. No baseline or gate tool was modified.
Before -> after:
- KPAD instruction-exact 18/29 -> 19/29; objdiff functions 18/29 -> 19/29; code 5188/13056 -> 5916/13056; data 7912/8032 -> 7912/8032.
- kbd_lib gate instruction-exact 13/21 -> 14/21; objdiff functions 14/21 -> 15/21; code 2432/5764 -> 3088/5764; data 5296/5296 -> 5296/5296.
- exif_parse instruction-exact 3/6 -> 3/6; code 1348/5088 -> 1348/5088; data 0/0 -> 0/0.
KBDResetChannel remains objdiff 100% and its actual instructions are identical. The gate undercounts it because odiff.dis normalizes the CR operand rather than the branch destination for two cr1 branches. This pre-existing gate-tool issue is recorded without editing the tools.
KPAD .sdata2 first divergence is the real 0.383864f constant: target offset 0x0c, source offset 0x60. Extracting the interval update into a meaningful inline helper did not change emission order and was restored. No dummy constant or forced placement was introduced.
## Remaining functions
- reset_kpad: 99.48718%; 117/117 instructions; 10 floating-register differences around reference distance and ratio temporaries.
- KPADGetProjectionPos: 96.57895%; 19/19 instructions; 9 floating-register and multiplication-operand differences.
- KPADSetSensorHeight: 99.23077%; 52/52 instructions; 7 base-pointer and square-result register differences.
- calc_acc_horizon: 97.27723%; 101/101 instructions; floating-register allocation and scheduling differ.
- read_kpad_acc: 98.15%; 400/400 instructions; smoothing helper expansion and floating-register allocation differ.
- select_1obj_first: 98.348625%; 109/109 instructions; end-pointer and floating temporary register allocation differ.
- select_1obj_continue: 98.49462%; 93/93 instructions; direction and offset temporaries use different registers and operand order.
- calc_dpd_variable: 94.82%; 250/250 instructions; distance magnitude and projected-coordinate temporaries differ.
- KPADRead: 97.52723%; 459/459 instructions; copy/gravity stack locals and inline expansion register scheduling differ.
- KPADInit: 96.51351%; 185/185 instructions; callee-saved integer and floating allocation, scheduling, and constant encounter order differ.
- kbdEventHandler: 99.83871%; 186/186 instructions; 5 report-byte and channel-base scratch-register differences.
- kbdProcMod: 99.90234%; 256/256 instructions; 4 pointer/value register differences in inlined modifier-state update.
- kbd_led_handler: 61.12%; 23/25 instructions; callback null-test/release ordering and scratch register allocation differ.
- KBDSetLedsAsync: 86.234566%; 80/81 instructions; channel offset rematerialization, signed loop index, and command addressing differ.
- KBDSetLeds: 84.6076%; 75/79 instructions; pointer induction versus target indexed command loop and channel offset rematerialization differ.
- KBDSetModState: 99.40476%; 42/42 instructions; 4 pointer/value register differences at physical-modifier insertion.
- TMCJPEGDEC_exif_parse: 98.679245%; 212/212 instructions; byte-reader temporaries and callee-saved parser cursor/count registers differ.
- TMCJPEGDEC_IFD0_tag_parse: 94.241165%; 481/481 instructions; decoded tag/type temporaries and switch default branch structure differ.
- TMCJPEGDEC_IFD1_tag_parse: 93.099174%; 239/242 instructions; switch decision tree/default-return structure and byte-reader temporary allocation differ.
Every remaining function has at least three distinct source-level trials logged in sol-low-leaves-attempts.md. Unsuccessful experiments were restored. Declaration-search tool outputs and target/source ctxdiff diagnosis are recorded or referenced there.
Changed files:
- libs/RVL_SDK/src/kpad/KPAD.c
- libs/RVL_SDK/src/kbd/kbd_lib.c
- tools/decomp-assist/sol-low-leaves-attempts.md
- tools/decomp-assist/sol-low-leaves-final-gate.txt
- tools/decomp-assist/sol-low-leaves-report.md
No source change to exif_parse; no linking/configuration/header change.

View File

@@ -0,0 +1,389 @@
# Structural round 10
Starting HEAD 21c9b95b; baseline gate passes, target DOL SHA1 confirmed. All edits owned by this single worker.
## Diagnosis before source trials
libs/RevoEX/src/nwc24/NWC24Download | NWC24InitDlTask | objdiff 98.923615 | structural/exact score, instructions ((0, 31), 144, 144); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RevoEX/src/nwc24/NWC24Download | NWC24IterateDlTask | objdiff 99.303795 | structural/exact score, instructions ((0, 10), 79, 79); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RevoEX/src/nwc24/NWC24Download | NWC24UpdateDlTask | objdiff 95.00395 | structural/exact score, instructions ((19, 250), 249, 253); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RevoEX/src/nwc24/NWC24Download | NWC24PurgeOldestDlTask | objdiff 87.11364 | structural/exact score, instructions ((29, 95), 167, 176); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RevoEX/src/nwc24/NWC24Download | NWC24ManageDlTaskListForMenu | objdiff 96.74342 | structural/exact score, instructions ((12, 36), 150, 152); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RevoEX/src/nwc24/NWC24Download | NWC24iCheckDlHeaderConsistency | objdiff 98.77358 | structural/exact score, instructions ((2, 3), 212, 212); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RevoEX/src/nwc24/NWC24Download | AddTaskInternal | objdiff 97.7182 | structural/exact score, instructions ((20, 323), 398, 401); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RVL_SDK/src/nup/nup | __nupParseServerInfo__FP14NUPContextInfoPcPcUx | objdiff 98.108406 | structural/exact score, instructions ((0, 148), 452, 452); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RVL_SDK/src/nup/nup | __nupBase64Encode__FPUcPUcUl | objdiff 94.20635 | structural/exact score, instructions ((9, 21), 63, 63); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RVL_SDK/src/nup/nup | __nupGetBootVersion__FP14ESTitleVersion | objdiff None | structural/exact score, instructions ((0, 17), 163, 163); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RVL_SDK/src/nup/nup | __nupGetTitleSize__FP12NUPTitleInfo | objdiff 99.100716 | structural/exact score, instructions ((0, 22), 139, 139); full asm and diffs /tmp/sol-med-round10/diffs.txt
libs/RVL_SDK/src/nup/nup | __nupOp | objdiff 99.25799 | structural/exact score, instructions ((4, 47), 438, 438); full asm and diffs /tmp/sol-med-round10/diffs.txt
src/scene/setting/iplSetting | createBrowser__Q33ipl5scene7SettingFv | objdiff 98.8505 | structural/exact score, instructions ((15, 114), 299, 301); full asm and diffs /tmp/sol-med-round10/diffs.txt
src/scene/setting/iplSetting | draw__Q33ipl5scene7SettingFv | objdiff 91.525314 | structural/exact score, instructions ((82, 570), 595, 632); full asm and diffs /tmp/sol-med-round10/diffs.txt
src/scene/setting/iplSetting | initKeyboard__Q33ipl5scene7SettingFPCc | objdiff 98.38498 | structural/exact score, instructions ((4, 195), 215, 213); full asm and diffs /tmp/sol-med-round10/diffs.txt
src/scene/setting/iplSetting | calcKeyboard__Q33ipl5scene7SettingFv | objdiff 98.0 | structural/exact score, instructions ((15, 258), 292, 290); full asm and diffs /tmp/sol-med-round10/diffs.txt
src/scene/setting/iplSetting | convertRevIP__Q33ipl5scene7SettingFPUcPCc | objdiff 98.69863 | structural/exact score, instructions ((0, 16), 73, 73); full asm and diffs /tmp/sol-med-round10/diffs.txt
src/scene/setting/iplSetting | scanAP__Q33ipl5scene7SettingFv | objdiff 95.39338 | structural/exact score, instructions ((53, 160), 266, 272); full asm and diffs /tmp/sol-med-round10/diffs.txt
src/scene/setting/iplSetting | setUSBAP__Q33ipl5scene7SettingFv | objdiff 98.070175 | structural/exact score, instructions ((7, 21), 56, 57); full asm and diffs /tmp/sol-med-round10/diffs.txt
NWC24InitDlTask | home-directory parser inline boundary with named high/low outputs | ((0, 31), 144, 144) -> ((0, 31), 144, 144) | objdiff 98.923615 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored
NWC24InitDlTask | combine parsed identity into native 64-bit title value | ((0, 31), 144, 144) -> ((0, 31), 144, 144) | objdiff 98.923615 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored
NWC24InitDlTask | initializer-specific ownership helper argument order | ((0, 31), 144, 144) -> ((0, 31), 144, 144) | objdiff 98.923615 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored
NWC24IterateDlTask | cache header getter directly at every loop validation | ((0, 10), 79, 79) -> ((5, 3), 79, 79) | objdiff 94.81013 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored
NWC24IterateDlTask | header recomputation through work dlHead field each use | ((0, 10), 79, 79) -> ((6, 52), 83, 79) | objdiff 92.21519 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored
NWC24IterateDlTask | iterator search isolated from begin handling in inline helper | ((0, 10), 79, 79) -> ((0, 18), 79, 79) | objdiff 98.73418 | gain [] loss ['NWC24IterateDlTaskEx'] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored
NWC24UpdateDlTask | materialized group ownership at update-only inline boundary | ((19, 250), 249, 253) -> ((5, 37), 253, 253) | objdiff 98.81423 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | kept
NWC24UpdateDlTask | retry predicate shifts before mask with explicit nonnull header branch | ((5, 37), 253, 253) -> ((5, 37), 253, 253) | objdiff 98.83399 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | kept
NWC24UpdateDlTask | access identifier copied through named inline output reader | ((5, 37), 253, 253) -> ((5, 29), 253, 253) | objdiff 98.992096 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | kept
NWC24UpdateDlTask | retry checker count parameter precedes task pointer | ((5, 29), 253, 253) -> ((5, 29), 253, 253) | objdiff 98.992096 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | kept
NWC24UpdateDlTask | group ownership accepts flags before group identifier | ((5, 29), 253, 253) -> ((19, 250), 249, 253) | objdiff 95.02371 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | kept
NWC24UpdateDlTask | retry uses explicit read-validation inline boundary | BUILD FAIL /src/libs/RevoEX/src/nwc24 && "/usr/bin/python3" tools/transform_dep.py build/43U/src/libs/RevoEX/src/nwc24/NWC24Download.d build/43U/src/libs/RevoEX/src/nwc24/NWC24Download.d
### mwcceppc.exe Compiler:
# File: libs\RevoEX\src\nwc24\NWC24Download.c
# ----------------------------------------------
# 725: u32 retryMask;
# Error: ^^^
# (10141) expression syntax error
# Too many errors printed, aborting program
User break, cancelled...
ninja: build stopped: subcommand failed.
| restored
NWC24UpdateDlTask | restore task-view group boundary after flags-first frame regression | ((19, 250), 249, 253) -> ((5, 29), 253, 253) | objdiff 98.992096 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | kept
NWC24UpdateDlTask | retry read-validation expanded with declarations before statements | ((5, 29), 253, 253) -> ((5, 29), 253, 253) | objdiff 98.992096 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24UpdateDlTask | group identifier declared before result boolean | ((5, 29), 253, 253) -> ((19, 250), 249, 253) | objdiff 95.02371 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24UpdateDlTask | owner comparison materialized inside update validator | ((5, 29), 253, 253) -> ((5, 29), 253, 253) | objdiff 98.992096 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24iCheckDlHeaderConsistency | repair loop inline parameters task,header,repair with target-required out-of-line API call | ((2, 3), 212, 212) -> ((5, 6), 212, 212) | objdiff 96.95283 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24iCheckDlHeaderConsistency | repair loop inline parameters header,task,repair with target-required out-of-line API call | ((2, 3), 212, 212) -> ((5, 6), 212, 212) | objdiff 96.95283 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24iCheckDlHeaderConsistency | repair loop inline parameters header,repair,task with target-required out-of-line API call | ((2, 3), 212, 212) -> ((5, 6), 212, 212) | objdiff 96.95283 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
__nupBase64Encode__FPUcPUcUl | direct quartet stores in encoding order | ((9, 21), 63, 63) -> ((8, 17), 63, 63) | objdiff 86.53968 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | kept
__nupBase64Encode__FPUcPUcUl | counter reset after first direct output assignment | ((8, 17), 63, 63) -> ((8, 17), 63, 63) | objdiff 86.53968 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
__nupBase64Encode__FPUcPUcUl | load every quartet character before writing output and resetting counter | ((8, 17), 63, 63) -> ((17, 30), 63, 63) | objdiff 79.7619 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
__nupBase64Encode__FPUcPUcUl | byte count initialized before value accumulator | ((8, 17), 63, 63) -> ((8, 30), 63, 63) | objdiff 85.190475 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
NWC24ManageDlTaskListForMenu | deletion propagates result through caller output pointer | ((12, 36), 150, 152) -> ((12, 36), 148, 152) | objdiff 96.2829 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24ManageDlTaskListForMenu | validation and successful deletion use separate inline lifetimes | ((12, 36), 150, 152) -> ((12, 36), 150, 152) | objdiff 96.74342 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24ManageDlTaskListForMenu | common deletion result assigned after validation success branch | ((12, 36), 150, 152) -> ((12, 36), 148, 152) | objdiff 96.2829 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24PurgeOldestDlTask | inline iterator initializer with checked status at API boundary | ((29, 95), 167, 176) -> ((21, 134), 171, 176) | objdiff 90.53977 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | kept
NWC24PurgeOldestDlTask | read and delete guarded by success with iterator failure conversion at end | ((21, 134), 171, 176) -> ((64, 167), 150, 176) | objdiff 76.47159 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24PurgeOldestDlTask | read task inline returns status into explicit outer result output | ((21, 134), 171, 176) -> ((21, 134), 171, 176) | objdiff 90.59659 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
AddTaskInternal | free-slot iterator uses unsigned word with explicit validated short id | ((20, 323), 398, 401) -> ((20, 323), 398, 401) | objdiff 97.75561 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
AddTaskInternal | URL failure returned through inline string-check boundary | ((20, 323), 398, 401) -> ((17, 88), 399, 401) | objdiff 98.02992 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | kept
AddTaskInternal | free-slot count validation uses sequential guards without shared condition register | ((17, 88), 399, 401) -> ((26, 101), 405, 401) | objdiff 96.12219 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24PurgeOldestDlTask | preserve initializer then defer iterator error conversion after read/delete branch | ((21, 134), 171, 176) -> ((10, 49), 174, 176) | objdiff 96.98864 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | kept
NWC24PurgeOldestDlTask | selected deletion retains status separately from validation result | ((10, 49), 174, 176) -> ((10, 49), 174, 176) | objdiff 96.98864 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24PurgeOldestDlTask | selected read parameters id before pointer across inline call | ((10, 49), 174, 176) -> ((10, 49), 174, 176) | objdiff 96.98864 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
__nupBase64Encode__FPUcPUcUl | direct-store and cache trials reverted to starting source after no exact gain
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | tag parser output length parameter before value pointer | BUILD FAIL 319: &titleStart, &titleLength)) != 0 &&
# Error: ^
# (10248) function call '__nupFindTag({lval} char *, {lval} const char *,
# {lval} const char *, char **, unsigned long *)' does not match
# '__nupFindTag(char *, const char *, const char *, unsigned long *, char
# **)'
# Too many errors printed, aborting program
User break, cancelled...
ninja: build stopped: subcommand failed.
| restored
__nupBase64Encode__FPUcPUcUl | direct-store and cache trials reverted to starting source after no exact gain
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | tag parser output length parameter before value pointer | BUILD FAIL 21: &versionStart, &versionLength)) != 0) {
# Error: ^
# (10248) function call '__nupFindTag({lval} char *, {lval} const char *,
# {lval} const char *, char **, unsigned long *)' does not match
# '__nupFindTag(char *, const char *, const char *, unsigned long *, char
# **)'
# Too many errors printed, aborting program
User break, cancelled...
ninja: build stopped: subcommand failed.
| restored
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | tag parser tests end tag through nested success branch | ((0, 148), 452, 452) -> ((69, 431), 470, 452) | objdiff 86.891594 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | tag values returned as named range at inline boundary | ((0, 148), 452, 452) -> ((0, 148), 452, 452) | objdiff 98.108406 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored
__nupGetTitleSize__FP12NUPTitleInfo | size-specific content helper takes content id before title | ((0, 22), 139, 139) -> ((0, 22), 139, 139) | objdiff 99.100716 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored
__nupGetTitleSize__FP12NUPTitleInfo | installed-content count passed explicitly at size-helper boundary | ((0, 22), 139, 139) -> ((0, 26), 139, 139) | objdiff 98.84892 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored
__nupGetTitleSize__FP12NUPTitleInfo | reserve size computed in separate native-wide total | ((0, 22), 139, 139) -> ((0, 22), 139, 139) | objdiff 99.100716 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored
__nupGetBootVersion__FP14ESTitleVersion | installed-content count acquired before allocating list | ((0, 17), 163, 163) -> ((0, 17), 163, 163) | objdiff None | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored
__nupGetBootVersion__FP14ESTitleVersion | title-id equality tests candidate before owned-title value | ((0, 17), 163, 163) -> ((0, 17), 163, 163) | objdiff None | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored
__nupGetBootVersion__FP14ESTitleVersion | boot-version conversion moves into title-version function scope | ((0, 17), 163, 163) -> ((4, 26), 163, 163) | objdiff None | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored
__nupOp | boot-version output initialized only on successful output query | ((4, 47), 438, 438) -> ((3, 404), 437, 438) | objdiff 99.520546 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | kept
__nupOp | boot-version output conversion stores only validated word | ((3, 404), 437, 438) -> ((0, 19), 438, 438) | objdiff 99.748856 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | kept
__nupOp | title selection loop acquires title id through helper output boundary | ((0, 19), 438, 438) -> ((0, 18), 438, 438) | objdiff 99.76028 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | kept
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | tag helper length-before-value outputs with every call updated | ((0, 148), 452, 452) -> ((0, 148), 452, 452) | objdiff 98.108406 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored
__nupOp | title selection compares current title id before array entry | ((0, 18), 438, 438) -> ((0, 18), 438, 438) | objdiff 99.783104 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
__nupOp | title selection caches count after download-progress work | ((0, 18), 438, 438) -> ((0, 12), 438, 438) | objdiff 99.84018 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | kept
__nupOp | title id acquired via semantic inline output reader | ((0, 12), 438, 438) -> ((0, 19), 438, 438) | objdiff 99.748856 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
__nupOp | declsearch after structural trials | ((0, 12), 438, 438) -> ((0, 12), 438, 438)
declaration block:
u8* response = 0;
ESTmdView* tmdView = 0;
u32 currentDeviceId;
u32 needsAudit;
char* auditData = 0;
s32 result;
u16 serverBootVersion;
u16 bootTitleVersion;
u16 systemMenuVersion;
ESTitleId currentTitleId;
NUPTitleInfo* bootTitle = 0;
NUPTitleInfo* menuTitle = 0;
NUPTitleInfo* systemTitle = 0;
NUPContextInfo* context = (NUPContextInfo*)argument;
u32 deviceId;
char messageId[0x15];
NANDStatus auditStatus;
u32 i;
start (0, 12)
best (0, 12) after 180 builds; source restored; best order was:
u8* response = 0;
ESTmdView* tmdView = 0;
u32 currentDeviceId;
u32 needsAudit;
char* auditData = 0;
s32 result;
u16 serverBootVersion;
u16 bootTitleVersion;
u16 systemMenuVersion;
ESTitleId currentTitleId;
NUPTitleInfo* bootTitle = 0;
NUPTitleInfo* menuTitle = 0;
NUPTitleInfo* systemTitle = 0;
NUPContextInfo* context = (NUPContextInfo*)argument;
u32 deviceId;
char messageId[0x15];
NANDStatus auditStatus;
u32 i;
createBrowser__Q33ipl5scene7SettingFv | explicit case seven with invalid direct page returning safely | ((15, 114), 299, 301) -> ((15, 111), 303, 301) | objdiff 98.75083 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
createBrowser__Q33ipl5scene7SettingFv | projection dimensions calculated through rectangle accessors | ((15, 114), 299, 301) -> ((15, 114), 299, 301) | objdiff 98.8505 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
createBrowser__Q33ipl5scene7SettingFv | initialize default direct path before explicit seven-case switch | ((15, 114), 299, 301) -> ((9, 116), 302, 301) | objdiff 99.19933 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
draw__Q33ipl5scene7SettingFv | copy GX mode by scalar fields and sample-pattern pairs | ((82, 570), 595, 632) -> ((76, 537), 632, 632) | objdiff 91.01899 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | kept
draw__Q33ipl5scene7SettingFv | window-null default branch and separate scroll direction stores | ((76, 537), 632, 632) -> ((71, 550), 632, 632) | objdiff 91.34335 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | kept
draw__Q33ipl5scene7SettingFv | side rectangles calculate each float boundary at construction | ((71, 550), 632, 632) -> ((111, 601), 628, 632) | objdiff 85.54588 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored despite requested keep
initKeyboard__Q33ipl5scene7SettingFPCc | keyboard defaults initialized in setting structure then copied to locals | ((4, 195), 215, 213) -> ((14, 202), 219, 213) | objdiff 96.478874 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
initKeyboard__Q33ipl5scene7SettingFPCc | keyboard type stored after string and row limits in setting object | ((4, 195), 215, 213) -> ((7, 195), 215, 213) | objdiff 98.38028 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
initKeyboard__Q33ipl5scene7SettingFPCc | unknown keyboard forms return before initialized limits are consumed | ((4, 195), 215, 213) -> ((18, 155), 215, 213) | objdiff 98.3615 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
__nupOp | current system title precedes candidate in 64-bit comparison after count lifetime fix | ((0, 12), 438, 438) -> ((0, 11), 438, 438) | objdiff 99.87443 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | kept
__nupOp | selection count materialized at semantic inline output boundary | ((0, 11), 438, 438) -> ((0, 11), 438, 438) | objdiff 99.87443 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
__nupOp | selection counter declared with thread locals but assigned at selection phase | ((0, 11), 438, 438) -> ((0, 11), 438, 438) | objdiff 99.87443 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
__nupOp | separate selection loop indices after download phase | ((0, 11), 438, 438) -> ((0, 18), 438, 438) | objdiff 99.783104 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
calcKeyboard__Q33ipl5scene7SettingFv | asterisk assignment precedes explicit index increment | ((15, 258), 292, 290) -> ((9, 274), 291, 290) | objdiff 98.63793 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | kept
calcKeyboard__Q33ipl5scene7SettingFv | form text uses existing nickname as initialized fallback | ((9, 274), 291, 290) -> ((114, 271), 253, 290) | objdiff 84.82758 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
calcKeyboard__Q33ipl5scene7SettingFv | cancellation form text has its own scoped lifetime | ((9, 274), 291, 290) -> ((9, 274), 291, 290) | objdiff 98.63793 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
convertRevIP__Q33ipl5scene7SettingFPUcPCc | IPv4 parsing inline boundary takes source text before destination | ((0, 16), 73, 73) -> ((0, 10), 73, 73) | objdiff 99.178085 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
convertRevIP__Q33ipl5scene7SettingFPUcPCc | IPv4 parsing inline boundary takes destination before source text | ((0, 16), 73, 73) -> ((0, 10), 73, 73) | objdiff 99.178085 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
convertRevIP__Q33ipl5scene7SettingFPUcPCc | decimal parser takes named component pointer before conversion | ((0, 16), 73, 73) -> ((0, 16), 73, 73) | objdiff 98.69863 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored
scanAP__Q33ipl5scene7SettingFv | animation boolean accumulated through inline query | ((53, 160), 266, 272) -> ((36, 165), 257, 272) | objdiff 93.25 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | kept
scanAP__Q33ipl5scene7SettingFv | animation boolean converted through SDK BOOL return boundary | BUILD FAIL Setting.cpp:3)
### mwcceppc.exe Compiler:
# File: src\scene\setting\iplSetting.cpp
# -----------------------------------------
# 2707: ol IsSettingAnimationPlaying(layout::Object* object, int index) {
# Error: ^
# (10333) object 'ipl::scene::IsSettingAnimationPlaying(ipl::layout::Object
# *, int)' redefined
# Too many errors printed, aborting program
User break, cancelled...
ninja: build stopped: subcommand failed.
| restored
scanAP__Q33ipl5scene7SettingFv | animation query separates animator acquisition from state read | BUILD FAIL Setting.cpp:3)
### mwcceppc.exe Compiler:
# File: src\scene\setting\iplSetting.cpp
# -----------------------------------------
# 2707: ol IsSettingAnimationPlaying(layout::Object* object, int index) {
# Error: ^
# (10333) object 'ipl::scene::IsSettingAnimationPlaying(ipl::layout::Object
# *, int)' redefined
# Too many errors printed, aborting program
User break, cancelled...
ninja: build stopped: subcommand failed.
| restored
__nupOp | special-title selection inline parameters required,titles,count | ((0, 11), 438, 438) -> ((23, 187), 436, 438) | objdiff 98.6484 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
__nupOp | special-title selection inline parameters count,titles,required | ((0, 11), 438, 438) -> ((23, 187), 436, 438) | objdiff 98.6484 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
setUSBAP__Q33ipl5scene7SettingFv | completion byte dispatches through switch before status argument reload | ((7, 21), 56, 57) -> ((7, 21), 56, 57) | objdiff 98.070175 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored despite requested keep
__nupOp | special-title selection inline parameters titles,required,count | ((0, 11), 438, 438) -> ((23, 187), 436, 438) | objdiff 98.6484 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
scanAP__Q33ipl5scene7SettingFv | restore starting animation body after whole-query helper stayed out of line
scanAP__Q33ipl5scene7SettingFv | leaf animation state query variant 1 | ((53, 160), 266, 272) -> ((54, 160), 266, 272) | objdiff 93.757355 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored despite requested keep
scanAP__Q33ipl5scene7SettingFv | leaf animation state query variant 2 | ((53, 160), 266, 272) -> ((53, 160), 266, 272) | objdiff 95.39338 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored despite requested keep
scanAP__Q33ipl5scene7SettingFv | leaf animation state query variant 3 | ((53, 160), 266, 272) -> ((53, 160), 266, 272) | objdiff 95.39338 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored despite requested keep
setUSBAP__Q33ipl5scene7SettingFv | completion byte handled by one-iteration loop with explicit break | ((7, 21), 56, 57) -> ((9, 12), 57, 57) | objdiff 85.87719 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored despite requested keep
setUSBAP__Q33ipl5scene7SettingFv | completion guard uses semantic result-byte inline predicate | ((7, 21), 56, 57) -> ((0, 0), 57, 57) | objdiff 100.0 | gain ['setUSBAP__Q33ipl5scene7SettingFv'] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | kept
__nupOp | candidate identifier loaded before candidate pointer declaration | ((0, 11), 438, 438) -> ((0, 11), 438, 438) | objdiff 99.87443 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
__nupOp | selection count acquired after array pointer in loop scope | ((0, 11), 438, 438) -> ((26, 185), 435, 438) | objdiff 98.3379 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
__nupOp | two title scans share an explicit pointer cursor instead of recomputing candidate | ((0, 11), 438, 438) -> ((0, 19), 438, 438) | objdiff 99.77169 | gain [] loss [] | POOL IDENTICAL up to 28 (mine=28 base=28) | restored despite requested keep
## First exact candidate
setUSBAP: inline result-byte predicate preserves both target loads without volatile. 57/57 instructions, ctxdiff diffs 0, objdiff 100.0. All unrelated provisional code restored before full gate.
## Structural findings
NWC24InitDlTask | 144/144 instructions; only local and nested ownership-helper register colors differ. | completed source trials 3
NWC24IterateDlTask | 79/79 instructions; cached work/header r6 and r7 colors reversed. | completed source trials 3
NWC24UpdateDlTask | timestamp and ownership inline boundaries force 0x30 rather than 0x20 frame; update-only task-view group helper reaches correct frame; retry branch and coloring still differ. | completed source trials 9
NWC24PurgeOldestDlTask | initializer inline return and late iterator-error conversion explain most structural mismatch; reaches 174/176 instructions; removal result boundary remains different. | completed source trials 6
NWC24ManageDlTaskListForMenu | delete-validation/result boundary produces 150/152 instructions with r3/r5 status allocation differences. | completed source trials 3
NWC24iCheckDlHeaderConsistency | 212/212 instructions; task address scheduled after saved parameter copies instead of before. | completed source trials 3
AddTaskInternal | URL failure branch, free-slot counter conversion, timestamp and retry helper boundaries. | completed source trials 3
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | 452/452 instructions; repeated tag-helper local colors differ. | completed source trials 3
__nupBase64Encode__FPUcPUcUl | 63/63 instructions; quartet reads must be scheduled before stores, counter color differs. | completed source trials 4
__nupGetBootVersion__FP14ESTitleVersion | target symbol omits context but asm uses both parameters; actual emitted two-parameter body has 163/163 instructions and 17 color differences. | completed source trials 3
__nupGetTitleSize__FP12NUPTitleInfo | 139/139 instructions; reserve high-word temporary and installed-content helper colors differ. | completed source trials 3
__nupOp | boot output initialization and conversion branch resolved structurally; count lifetime removes 7 differences; remaining 11 differences swap count and low title-id register r7/r8. | completed source trials 16
createBrowser__Q33ipl5scene7SettingFv | 0x200/0x210 frame; explicit seventh case and invalid-page default shape; target default retains uninitialized path, which will not be reproduced. | completed source trials 3
draw__Q33ipl5scene7SettingFv | scalar GX mode copy explains most instruction-count gap; rectangle floating-point schedules and texture lifetimes differ. | completed source trials 3
initKeyboard__Q33ipl5scene7SettingFPCc | safe row/string defaults add two instructions; keyboard settings stores and local colors differ. | completed source trials 3
calcKeyboard__Q33ipl5scene7SettingFv | safe form defaults add instructions; asterisk update ordering improves 292 to 291 against 290. | completed source trials 3
convertRevIP__Q33ipl5scene7SettingFPUcPCc | 73/73 instructions; pointer/count/index colors differ; semantic wrapper reduces 16 to 10 differences. | completed source trials 3
scanAP__Q33ipl5scene7SettingFv | target materializes animation boolean; state/index store order differs; whole-query helper remains out of line and is rejected. | completed source trials 4
setUSBAP__Q33ipl5scene7SettingFv | target reloads result byte; inline byte predicate reproduces both loads, 57/57 instructions and diffs 0. | completed source trials 3
setUSBAP clean full gate PASS; instruction-exact 104 -> 105, objdiff exact 105 -> 106, code 30532 -> 30760, data unchanged, regressions/forbidden/readability 0; committed 31cd9401
NWC24InitDlTask | initial cached-header helper replaces open-coded acquisition | ((0, 31), 144, 144) -> ((0, 31), 144, 144) | objdiff 98.923615 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24InitDlTask | initial header acquired through named output parameter | ((0, 31), 144, 144) -> ((0, 31), 144, 144) | objdiff 98.923615 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24IterateDlTask | work cache acquired through semantic inline output reader | ((0, 10), 79, 79) -> ((0, 10), 79, 79) | objdiff 99.303795 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24IterateDlTask | reuse the validated cached header for later entry iteration | ((0, 10), 79, 79) -> ((2, 51), 78, 79) | objdiff 97.91139 | gain [] loss [] | POOL IDENTICAL up to 3 (mine=3 base=3) | restored despite requested keep
NWC24InitDlTask | declsearch after structural trials | ((0, 31), 144, 144) -> ((0, 31), 144, 144)
declaration block:
char homePath[64] = {0};
u32 nwc24IdHigh;
u32 nwc24IdLow;
DlTaskData* task;
DlTaskListHeader* header;
NWC24Err result;
BOOL allowed;
BOOL useContentFile;
start (0, 31)
best (0, 31) after 71 builds; source restored; best order was:
char homePath[64] = {0};
u32 nwc24IdHigh;
u32 nwc24IdLow;
DlTaskData* task;
DlTaskListHeader* header;
NWC24Err result;
BOOL allowed;
BOOL useContentFile;
NWC24IterateDlTask | declsearch after structural trials | ((0, 10), 79, 79) -> ((0, 10), 79, 79)
declaration block:
DlTaskListHeader* entriesHeader;
NWC24Work* work;
u16 taskId;
u16 maxTaskCount;
DlTaskListHeader* header;
NWC24Err result;
start (0, 10)
best (0, 10) after 36 builds; source restored; best order was:
DlTaskListHeader* entriesHeader;
NWC24Work* work;
u16 taskId;
u16 maxTaskCount;
DlTaskListHeader* header;
NWC24Err result;
## Rejected provisional work
NWC24 update timestamp/ownership, purge initializer/error flow, AddTask URL helper, nupOp boot/title selection, Setting draw/calcKeyboard changes all restored. They improved structural or fuzzy scores but never achieved a new exact function. Saved snapshots under /tmp/sol-med-round10 are evidence only and will not be committed.
No configuration, symbols, shared headers, original data placement, link flags, or other translation units edited.
Readability: no new comments, asm, padding, volatile, uninitialized reads, raw pointer offsets, auto-named identifiers, or function deletion.
NWC24iCheckDlHeaderConsistency | declsearch after structural trials | ((2, 3), 212, 212) -> ((2, 3), 212, 212)
declaration block:
NWC24DlTask task;
NWC24DlTask* taskPointer = &task;
NWC24DlId taskId;
NWC24Err result;
DlTaskListHeader* currentHeader;
DlTaskListHeader* listHeader = header;
BOOL shouldRepair = repair;
start (2, 3)
best (2, 3) after 52 builds; source restored; best order was:
NWC24DlTask task;
NWC24DlTask* taskPointer = &task;
NWC24DlId taskId;
NWC24Err result;
DlTaskListHeader* currentHeader;
DlTaskListHeader* listHeader = header;
BOOL shouldRepair = repair;
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | declsearch after structural trials | ((0, 148), 452, 452) -> ((0, 148), 452, 452)
definition of __nupParseServerInfo__FP14NUPContextInfoPcPcUx not found
__nupGetTitleSize__FP12NUPTitleInfo | declsearch after structural trials | ((0, 22), 139, 139) -> ((0, 22), 139, 139)
definition of __nupGetTitleSize__FP12NUPTitleInfo not found
convertRevIP__Q33ipl5scene7SettingFPUcPCc | declsearch after structural trials | ((0, 16), 73, 73) -> ((0, 16), 73, 73)
declaration block:
char ascii[20];
int count = 0;
int index;
start (0, 16)
best (0, 16) after 6 builds; source restored; best order was:
char ascii[20];
int count = 0;
int index;
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | declsearch explicit lines after mangled-name parser failure | ((0, 148), 452, 452) -> ((0, 148), 452, 452)
declaration block:
s32 result = 0;
char* start;
char* afterEnd;
char* cursor;
size_t valueLength;
size_t titleCount;
start (0, 148)
best (0, 148) after 36 builds; source restored; best order was:
s32 result = 0;
char* start;
char* afterEnd;
char* cursor;
size_t valueLength;
size_t titleCount;
__nupGetTitleSize__FP12NUPTitleInfo | declsearch explicit lines after mangled-name parser failure | ((0, 22), 139, 139) -> ((0, 22), 139, 139)
declaration block:
s32 result = 0;
s32 contentIndex;
start (0, 22)
best (0, 22) after 2 builds; source restored; best order was:
s32 result = 0;
s32 contentIndex;
__nupBase64Encode__FPUcPUcUl | declsearch explicit lines after mangled-name parser failure | ((9, 21), 63, 63) -> ((9, 21), 63, 63)
declaration block:
u8* end = input + length;
u32 value = 0;
u32 count = 0;
start (9, 21)
best (9, 21) after 6 builds; source restored; best order was:
u8* end = input + length;
u32 value = 0;
u32 count = 0;
__nupGetBootVersion__FP14ESTitleVersion | declsearch actual body against target with explicit name mapping, no source symbol rename | ((0, 17), 163, 163) -> ((0, 17), 163, 163)
declaration block:
s32 result;
ESTmdView* tmdView = 0;
start (0, 17)
best (0, 17) after 2 builds; source restored; best order was:
s32 result;
ESTmdView* tmdView = 0;
convertRevIP__Q33ipl5scene7SettingFPUcPCc | retain source-before-destination IPv4 helper for final declaration search | ((0, 16), 73, 73) -> ((0, 10), 73, 73) | objdiff 99.178085 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | kept
convertRevIP__Q33ipl5scene7SettingFPUcPCc | IPv4 helper leading declaration block includes start and destination cursor | ((0, 10), 73, 73) -> ((0, 10), 73, 73) | objdiff 99.178085 | gain [] loss [] | POOL IDENTICAL up to 108 (mine=108 base=108) | restored despite requested keep
convertRevIP__Q33ipl5scene7SettingFPUcPCc | declaration search on semantic parsing helper after source trials | ((0, 10), 73, 73) -> ((0, 10), 73, 73)
declaration block:
char ascii[20];
int count = 0;
int index;
start (0, 10)
best (0, 10) after 6 builds; source restored; best order was:
char ascii[20];
int count = 0;
int index;
## Final open-function audit
NWC24InitDlTask | objdiff 98.923615 | distinct successful-build source attempts 5
NWC24IterateDlTask | objdiff 99.303795 | distinct successful-build source attempts 5
NWC24UpdateDlTask | objdiff 95.00395 | distinct successful-build source attempts 9
NWC24PurgeOldestDlTask | objdiff 87.11364 | distinct successful-build source attempts 5
NWC24ManageDlTaskListForMenu | objdiff 96.74342 | distinct successful-build source attempts 3
NWC24iCheckDlHeaderConsistency | objdiff 98.77358 | distinct successful-build source attempts 3
AddTaskInternal | objdiff 97.7182 | distinct successful-build source attempts 3
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | objdiff 98.108406 | distinct successful-build source attempts 3
__nupBase64Encode__FPUcPUcUl | objdiff 94.20635 | distinct successful-build source attempts 4
__nupGetBootVersion__FP14ESTitleVersion | objdiff None | distinct successful-build source attempts 3
__nupGetTitleSize__FP12NUPTitleInfo | objdiff 99.100716 | distinct successful-build source attempts 3
__nupOp | objdiff 99.25799 | distinct successful-build source attempts 16
createBrowser__Q33ipl5scene7SettingFv | objdiff 98.8505 | distinct successful-build source attempts 3
draw__Q33ipl5scene7SettingFv | objdiff 91.525314 | distinct successful-build source attempts 3
initKeyboard__Q33ipl5scene7SettingFPCc | objdiff 98.38498 | distinct successful-build source attempts 3
calcKeyboard__Q33ipl5scene7SettingFv | objdiff 98.0 | distinct successful-build source attempts 3
convertRevIP__Q33ipl5scene7SettingFPUcPCc | objdiff 98.69863 | distinct successful-build source attempts 5
scanAP__Q33ipl5scene7SettingFv | objdiff 95.39338 | distinct successful-build source attempts 4
All 18 open functions have at least three distinct source attempts. Declaration-order searches followed structural trials. Purge trial with accidental early source slicing was rejected and excluded from this audit. All source changes outside the committed result-byte predicate restored.
Final clean full gate over all three: GATE PASS; DOL target SHA1, all pools identical, regressions/forbidden/readability 0. Only Setting unit changed among 1027 reports. setUSBAP: objdiff 100.0, 57/57 instructions, ctxdiff diffs 0.
Fresh comparator caveat: setUpdate_NoUpdateDialog_ raw 120-byte bodies are identical and corrected disassembler score is (0,0). ctxdiff misreads blt cr1 first operand as branch target; two apparent differences depend on function offset. Prior round NaN explanation not supported by current output. Tooling left unchanged.

View File

@@ -0,0 +1,56 @@
full build: ok
main.dol sha1: 26116613f624061ba99c8d1a299aaa6efa85670d
[libs/RevoEX/src/nwc24/NWC24Download] pool: IDENTICAL
[libs/RevoEX/src/nwc24/NWC24Download] objdiff: code 6828/12496 data 80/80 functions 23/30 fuzzy 98.2676 linked code 0
[libs/RevoEX/src/nwc24/NWC24Download] instruction-exact functions: 23/30
[libs/RevoEX/src/nwc24/NWC24Download] section .data size 56 match 100.0
[libs/RevoEX/src/nwc24/NWC24Download] section .sbss size 8 match 100.0
[libs/RevoEX/src/nwc24/NWC24Download] section .sdata size 16 match 100.0
[libs/RevoEX/src/nwc24/NWC24Download] section .text size 12496 match 98.26761
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24InitDlTask 98.923615
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24IterateDlTask 99.303795
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24UpdateDlTask 95.00395
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24PurgeOldestDlTask 87.11364
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24ManageDlTaskListForMenu 96.74342
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24iCheckDlHeaderConsistency 98.77358
[libs/RevoEX/src/nwc24/NWC24Download] below 100: AddTaskInternal 97.7182
[libs/RevoEX/src/nwc24/NWC24Download] baseline: code 6828/12496 data 80 functions 23 fuzzy 98.2676
[libs/RVL_SDK/src/nup/nup] pool: IDENTICAL
[libs/RVL_SDK/src/nup/nup] objdiff: code 5744/10764 data 1720/1720 functions 18/23 fuzzy 93.3222 linked code 0
[libs/RVL_SDK/src/nup/nup] instruction-exact functions: 18/23
[libs/RVL_SDK/src/nup/nup] section .data size 1592 match 100.0
[libs/RVL_SDK/src/nup/nup] section .rodata size 88 match 100.0
[libs/RVL_SDK/src/nup/nup] section .sbss size 8 match 100.0
[libs/RVL_SDK/src/nup/nup] section .sdata size 32 match 100.0
[libs/RVL_SDK/src/nup/nup] section .text size 10764 match 93.32218
[libs/RVL_SDK/src/nup/nup] below 100: __nupParseServerInfo__FP14NUPContextInfoPcPcUx 98.108406
[libs/RVL_SDK/src/nup/nup] below 100: __nupBase64Encode__FPUcPUcUl 94.20635
[libs/RVL_SDK/src/nup/nup] below 100: __nupGetBootVersion__FP14ESTitleVersion None
[libs/RVL_SDK/src/nup/nup] below 100: __nupGetTitleSize__FP12NUPTitleInfo 99.100716
[libs/RVL_SDK/src/nup/nup] below 100: __nupOp 99.25799
[libs/RVL_SDK/src/nup/nup] baseline: code 5744/10764 data 1720 functions 18 fuzzy 93.3222
[src/scene/setting/iplSetting] pool: IDENTICAL
[src/scene/setting/iplSetting] objdiff: code 30760/37884 data 1040/5696 functions 106/112 fuzzy 99.1581 linked code 0
[src/scene/setting/iplSetting] instruction-exact functions: 105/112
[src/scene/setting/iplSetting] section .bss size 456 match 100.0
[src/scene/setting/iplSetting] section .data size 4016 match 5.146636
[src/scene/setting/iplSetting] section .rodata size 640 match 32.25412
[src/scene/setting/iplSetting] section .sbss size 16 match 100.0
[src/scene/setting/iplSetting] section .sdata size 504 match 100.0
[src/scene/setting/iplSetting] section .sdata2 size 64 match 100.0
[src/scene/setting/iplSetting] section .text size 37884 match 99.15806
[src/scene/setting/iplSetting] below 100: createBrowser__Q33ipl5scene7SettingFv 98.8505
[src/scene/setting/iplSetting] below 100: draw__Q33ipl5scene7SettingFv 91.525314
[src/scene/setting/iplSetting] below 100: initKeyboard__Q33ipl5scene7SettingFPCc 98.38498
[src/scene/setting/iplSetting] below 100: calcKeyboard__Q33ipl5scene7SettingFv 98.0
[src/scene/setting/iplSetting] below 100: convertRevIP__Q33ipl5scene7SettingFPUcPCc 98.69863
[src/scene/setting/iplSetting] below 100: scanAP__Q33ipl5scene7SettingFv 95.39338
[src/scene/setting/iplSetting] baseline: code 30532/37884 data 1040 functions 105 fuzzy 99.1465
regressions vs baseline: 0
global matched_code_percent: 87.12394 -> 87.13156
global fuzzy_match_percent: 99.36623 -> 99.36638
global complete_code_percent: 61.40923 -> 61.40923
global matched_data_percent: 91.13999 -> 91.13999
forbidden patterns added (net, per file): 0
readability warnings (net, per file; must be 0 in the final result): 0
GATE PASS

View File

@@ -0,0 +1,111 @@
# Structural round 10
Committed one new exact function: `Setting::setUSBAP`, with an inline result-byte predicate that preserves the target's separate guard and argument loads. The source change adds five lines and changes one condition. No volatile access, new assembly, hand-placed data, header or configuration changes.
| Unit | Instruction-exact before -> after | Objdiff exact before -> after | Matched code bytes before -> after | Matched data bytes before -> after |
| --- | --- | --- | --- | --- |
| libs/RevoEX/src/nwc24/NWC24Download | 23 -> 23 / 30 | 23 -> 23 / 30 | 6828 -> 6828 / 12496 | 80 -> 80 / 80 |
| libs/RVL_SDK/src/nup/nup | 18 -> 18 / 23 | 18 -> 18 / 23 | 5744 -> 5744 / 10764 | 1720 -> 1720 / 1720 |
| src/scene/setting/iplSetting | 104 -> 105 / 112 | 105 -> 106 / 112 | 30532 -> 30760 / 37884 | 1040 -> 1040 / 5696 |
## Remaining functions
NWC24InitDlTask | 98.923615 | 144/144 instructions; local and ownership-helper register colors.
NWC24IterateDlTask | 99.303795 | 79/79 instructions; work/header r6/r7 colors reversed.
NWC24UpdateDlTask | 95.00395 | 249/253 instructions; 0x30/0x20 frame, ownership/timestamp inline boundaries, retry branch and mask operands.
NWC24PurgeOldestDlTask | 87.11364 | 167/176 instructions; iterator initializer, shared read/removal result and error conversion boundaries.
NWC24ManageDlTaskListForMenu | 96.74342 | 150/152 instructions; inline validation/removal status lifetime and argument registers.
NWC24iCheckDlHeaderConsistency | 98.77358 | 212/212 instructions; three prologue instructions scheduled in a different order.
AddTaskInternal | 97.7182 | 398/401 instructions; URL failure branch, free-slot short counter, update helper boundaries.
__nupParseServerInfo__FP14NUPContextInfoPcPcUx | 98.108406 | 452/452 instructions; colors across repeated tag-helper expansion.
__nupBase64Encode__FPUcPUcUl | 94.20635 | 63/63 instructions; quartet load/store schedule and counter register.
__nupGetBootVersion__FP14ESTitleVersion | unpaired | target name omits context although asm uses both parameters; actual two-parameter body has 163/163 instructions and 17 register differences.
__nupGetTitleSize__FP12NUPTitleInfo | 99.100716 | 139/139 instructions; wide-add high word and installed-content search colors.
__nupOp | 99.25799 | 438/438 instructions; output initialization and conversion branches plus title selection colors. Provisional structural fixes reached 11 register differences, then were restored without exact gain.
createBrowser__Q33ipl5scene7SettingFv | 98.8505 | 299/301 instructions; frame 0x200/0x210 and direct-page switch/default shape. Uninitialized default was not reproduced.
draw__Q33ipl5scene7SettingFv | 91.525314 | 595/632 instructions; GX mode scalar copy, scroll/window branches, rectangle and texture lifetimes.
initKeyboard__Q33ipl5scene7SettingFPCc | 98.38498 | 215/213 instructions; safe limit defaults, settings stores and local colors.
calcKeyboard__Q33ipl5scene7SettingFv | 98.0 | 292/290 instructions; safe form defaults, asterisk update and cancellation pointer lifetime.
convertRevIP__Q33ipl5scene7SettingFPUcPCc | 98.69863 | 73/73 instructions; component counter and buffer/output pointer colors.
scanAP__Q33ipl5scene7SettingFv | 95.39338 | 266/272 instructions; animation boolean materialization and animation/state store order.
## Attempts and scope
Every remaining function has at least three distinct logged source attempts that built successfully. The final audit excludes the discarded purge trial with incorrect source slicing. Structural diagnosis preceded edits. Declaration searches ran last; explicit source line ranges bypassed the tool's SDK-symbol name parser limitation. For the boot-version body, the target lookup was mapped only in the temporary Python runner, without renaming source functions.
All rejected or fuzzy-only code changes were restored. No output from another translation unit was changed. Starting untracked round 8 and round 9 records were preserved.
Detailed attempts: `sol-med-structural-round10.attempts.md`. Complete source trial diffs and target assembly: `/tmp/sol-med-round10/diffs.txt`. Provisional source snapshots remain in `/tmp/sol-med-round10` for diagnostic evidence only.
## Validation and commits
Code commit: `31cd9401`, `match usb access point completion handling`.
The first clean full gate passed: build successful, DOL SHA1 `26116613f624061ba99c8d1a299aaa6efa85670d`, identical Setting pool, zero regressions, zero forbidden patterns and zero readability problems. `setUSBAP` has 57/57 instructions, ctxdiff diffs 0 and exact-name objdiff 100.0.
Final clean full gate over all three units is recorded in `sol-med-structural-round10.final-gate.txt`. Final clean full gate: `GATE PASS`. All three pools identical; full build successful; target DOL SHA1 retained; zero regressions, forbidden patterns and readability problems. Independent comparison of all 1027 unit reports confirms that only Setting changed. Exact `setUSBAP` was rechecked after the clean rebuild.
## Measurement uncertainties
Setting's instruction comparator reports one fewer exact function than objdiff. Fresh verification finds identical 120-byte bodies for `setUpdate_NoUpdateDialog_`, with structural/exact score `(0, 0)` in the operand-corrected disassembler. The gate/ctxdiff disassembler reads the first CR operand of `blt cr1` as an immediate rather than using the branch target operand; different function offsets therefore create two false differences. Prior round records attributed this to NaN; current evidence supports the CR-operand parsing explanation. No verification tooling was changed. Setting data remains 1040/5696; original weak/inline data may have been deduplicated by the linker. Linking is outside this phase. The boot-version target's one-parameter mangled name does not describe its two-parameter machine code.
## Final gate
```text
full build: ok
main.dol sha1: 26116613f624061ba99c8d1a299aaa6efa85670d
[libs/RevoEX/src/nwc24/NWC24Download] pool: IDENTICAL
[libs/RevoEX/src/nwc24/NWC24Download] objdiff: code 6828/12496 data 80/80 functions 23/30 fuzzy 98.2676 linked code 0
[libs/RevoEX/src/nwc24/NWC24Download] instruction-exact functions: 23/30
[libs/RevoEX/src/nwc24/NWC24Download] section .data size 56 match 100.0
[libs/RevoEX/src/nwc24/NWC24Download] section .sbss size 8 match 100.0
[libs/RevoEX/src/nwc24/NWC24Download] section .sdata size 16 match 100.0
[libs/RevoEX/src/nwc24/NWC24Download] section .text size 12496 match 98.26761
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24InitDlTask 98.923615
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24IterateDlTask 99.303795
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24UpdateDlTask 95.00395
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24PurgeOldestDlTask 87.11364
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24ManageDlTaskListForMenu 96.74342
[libs/RevoEX/src/nwc24/NWC24Download] below 100: NWC24iCheckDlHeaderConsistency 98.77358
[libs/RevoEX/src/nwc24/NWC24Download] below 100: AddTaskInternal 97.7182
[libs/RevoEX/src/nwc24/NWC24Download] baseline: code 6828/12496 data 80 functions 23 fuzzy 98.2676
[libs/RVL_SDK/src/nup/nup] pool: IDENTICAL
[libs/RVL_SDK/src/nup/nup] objdiff: code 5744/10764 data 1720/1720 functions 18/23 fuzzy 93.3222 linked code 0
[libs/RVL_SDK/src/nup/nup] instruction-exact functions: 18/23
[libs/RVL_SDK/src/nup/nup] section .data size 1592 match 100.0
[libs/RVL_SDK/src/nup/nup] section .rodata size 88 match 100.0
[libs/RVL_SDK/src/nup/nup] section .sbss size 8 match 100.0
[libs/RVL_SDK/src/nup/nup] section .sdata size 32 match 100.0
[libs/RVL_SDK/src/nup/nup] section .text size 10764 match 93.32218
[libs/RVL_SDK/src/nup/nup] below 100: __nupParseServerInfo__FP14NUPContextInfoPcPcUx 98.108406
[libs/RVL_SDK/src/nup/nup] below 100: __nupBase64Encode__FPUcPUcUl 94.20635
[libs/RVL_SDK/src/nup/nup] below 100: __nupGetBootVersion__FP14ESTitleVersion None
[libs/RVL_SDK/src/nup/nup] below 100: __nupGetTitleSize__FP12NUPTitleInfo 99.100716
[libs/RVL_SDK/src/nup/nup] below 100: __nupOp 99.25799
[libs/RVL_SDK/src/nup/nup] baseline: code 5744/10764 data 1720 functions 18 fuzzy 93.3222
[src/scene/setting/iplSetting] pool: IDENTICAL
[src/scene/setting/iplSetting] objdiff: code 30760/37884 data 1040/5696 functions 106/112 fuzzy 99.1581 linked code 0
[src/scene/setting/iplSetting] instruction-exact functions: 105/112
[src/scene/setting/iplSetting] section .bss size 456 match 100.0
[src/scene/setting/iplSetting] section .data size 4016 match 5.146636
[src/scene/setting/iplSetting] section .rodata size 640 match 32.25412
[src/scene/setting/iplSetting] section .sbss size 16 match 100.0
[src/scene/setting/iplSetting] section .sdata size 504 match 100.0
[src/scene/setting/iplSetting] section .sdata2 size 64 match 100.0
[src/scene/setting/iplSetting] section .text size 37884 match 99.15806
[src/scene/setting/iplSetting] below 100: createBrowser__Q33ipl5scene7SettingFv 98.8505
[src/scene/setting/iplSetting] below 100: draw__Q33ipl5scene7SettingFv 91.525314
[src/scene/setting/iplSetting] below 100: initKeyboard__Q33ipl5scene7SettingFPCc 98.38498
[src/scene/setting/iplSetting] below 100: calcKeyboard__Q33ipl5scene7SettingFv 98.0
[src/scene/setting/iplSetting] below 100: convertRevIP__Q33ipl5scene7SettingFPUcPCc 98.69863
[src/scene/setting/iplSetting] below 100: scanAP__Q33ipl5scene7SettingFv 95.39338
[src/scene/setting/iplSetting] baseline: code 30532/37884 data 1040 functions 105 fuzzy 99.1465
regressions vs baseline: 0
global matched_code_percent: 87.12394 -> 87.13156
global fuzzy_match_percent: 99.36623 -> 99.36638
global complete_code_percent: 61.40923 -> 61.40923
global matched_data_percent: 91.13999 -> 91.13999
forbidden patterns added (net, per file): 0
readability warnings (net, per file; must be 0 in the final result): 0
GATE PASS
```

View File

@@ -0,0 +1,53 @@
import contextlib
import io
import unittest
from unittest.mock import Mock, mock_open, patch
import pool_diff
class PoolDiffTests(unittest.TestCase):
def read_pool(self, data):
elf = Mock()
section = None if data is None else Mock()
if section is not None:
section.data.return_value = data
elf.get_section_by_name.return_value = section
with patch('builtins.open', mock_open(read_data=b'')), patch.object(pool_diff, 'ELFFile', return_value=elf):
result = pool_diff.pool('test.o')
elf.get_section_by_name.assert_called_once_with('.data')
return result
def compare(self, left, right):
with patch.object(pool_diff.sys, 'argv', ['pool_diff.py', 'left.o', 'right.o']), \
patch.object(pool_diff, 'pool', side_effect=[left, right]), \
contextlib.redirect_stdout(io.StringIO()):
return pool_diff.main()
def test_missing_data_has_no_strings(self):
self.assertEqual(self.read_pool(None), [])
def test_empty_data_has_no_strings(self):
self.assertEqual(self.read_pool(b''), [])
def test_existing_string_extraction(self):
self.assertEqual(self.read_pool(b'abc\x00hello\x00world\x00'), [(4, 'hello'), (10, 'world')])
def test_two_missing_pools_match(self):
self.assertEqual(self.compare([], []), 0)
def test_identical_pools_match(self):
self.assertEqual(self.compare([(0, 'hello')], [(0, 'hello')]), 0)
def test_changed_string_fails(self):
self.assertEqual(self.compare([(0, 'hello')], [(0, 'world')]), 1)
def test_missing_left_pool_does_not_hide_strings(self):
self.assertEqual(self.compare([], [(0, 'hello')]), 1)
def test_missing_right_pool_does_not_hide_strings(self):
self.assertEqual(self.compare([(0, 'hello')], []), 1)
if __name__ == '__main__':
unittest.main()