Compare commits

...

3 Commits

Author SHA1 Message Date
asm2c
93ce647108 CDBDatabase: convert CleanUpEmptyDirectories to matching C
Exact match (133/133, diffs 0). Uses labeled error strings so the
DOL string pool stays identical to baserom.
2026-10-01 17:14:23 -05:00
coah
41256e2038 CDBDatabase: reuse labeled error strings for Close/FindByKey
Point CDBReportError at the existing lbl_ string pool entries so the
linked DOL matches baserom SHA1 26116613f624061ba99c8d1a299aaa6efa85670d.
2026-10-01 17:08:07 -05:00
coah
ac797feb86 CDBDatabase: convert Close and FindByKey to matching C
Replace asm bodies for CDBDatabaseClose and CDBDatabaseFindByKey with
equivalent C that matches instruction-exact (ctxdiff diffs 0). Unit stays
33/33 matched with 100% code and data.
2026-10-01 17:01:18 -05:00

View File

@@ -8,10 +8,10 @@ extern u32 CDBGetInitialCode();
extern void CDBLock();
extern CDBErr CDBDatabaseAllocate(CDBDatabase* database, u32 flags);
extern void CDBUnlock();
extern void CDBDatabaseFree();
extern CDBErr CDBDatabaseFree(CDBDatabase* database);
extern void CDBRecordCreateAtOnce();
extern void CDBRecordInitDescriptor();
extern void CDBRecordIsExistFile();
extern void CDBRecordInitDescriptor(CDBRecord* record, CDBDatabase* database, CDBRecordKey* key);
extern BOOL CDBRecordIsExistFile(CDBRecord* record);
extern void CDBRecordOpenReadOnly();
extern void CDBRecordKeyArrayInit();
extern void CDBRecordKeyArraySetReverse();
@@ -157,59 +157,27 @@ CDBErr CDBDatabaseOpen(CDBDatabase* database) {
return result;
}
asm CDBErr CDBDatabaseClose(CDBDatabase* database) {
#ifdef __MWERKS__
nofralloc
stwu r1, -0x10(r1)
mflr r0
stw r0, 0x14(r1)
stw r31, 0xc(r1)
stw r30, 0x8(r1)
mr r30, r3
bl CDBLock
lwz r31, 0x8(r30)
cmpwi r31, 0x0
beq L_8148746C
addis r3, r31, 0x1
lwz r0, -0x3ff0(r3)
cmpwi r0, 0x0
bne L_8148749C
L_8148746C:
li r3, 0x2
bl CDBIsPrintDebugMessage
cmpwi r3, 0x0
beq L_81487494
li r3, 0x2
bl CDBReport_
lis r3, lbl_8166B528@ha
addi r3, r3, lbl_8166B528@l
crclr 4*cr1+eq
bl OSReport
L_81487494:
li r31, 0x1b
b L_814874C4
L_8148749C:
mr r3, r30
bl CDBDatabaseFree
cmpwi r3, 0x0
beq L_814874B4
mr r31, r3
b L_814874C4
L_814874B4:
addis r3, r31, 0x1
li r0, 0x0
stw r0, -0x3ff0(r3)
li r31, 0x0
L_814874C4:
bl CDBUnlock
mr r3, r31
lwz r31, 0xc(r1)
lwz r30, 0x8(r1)
lwz r0, 0x14(r1)
mtlr r0
addi r1, r1, 0x10
blr
#endif
CDBErr CDBDatabaseClose(CDBDatabase* database) {
CDBErr result;
CDBErr status;
CDBDatabaseState* instance;
CDBLock();
instance = database->instance;
if (instance == NULL || instance->flags == 0) {
CDBReportError(lbl_8166B528);
result = CDB_ERROR_27;
} else {
status = CDBDatabaseFree(database);
if (status != CDB_ERROR_OK) {
result = status;
} else {
instance->flags = 0;
result = CDB_ERROR_OK;
}
}
CDBUnlock();
return result;
}
CDBErr CDBDatabasePrivateCreateRecordAtOnce(CDBDatabase* database, CDBRecord* record, const char* typeStr, const char* fileTypeStr, u8* recordData, u32 recordDataSize, char* makerCodeStr, char* gameCodeStr) {
@@ -525,72 +493,24 @@ asm CDBErr CDBDatabaseCreateRecordImAtOnce_() {
#endif
}
asm CDBErr CDBDatabaseFindByKey() {
#ifdef __MWERKS__
nofralloc
stwu r1, -0x20(r1)
mflr r0
stw r0, 0x24(r1)
stw r31, 0x1c(r1)
mr r31, r5
stw r30, 0x18(r1)
mr r30, r4
stw r29, 0x14(r1)
mr r29, r3
bl CDBLock
mr r3, r31
bl CDBRecordKeyIsValid
cmpwi r3, 0x0
bne L_81487ABC
li r3, 0x2
bl CDBIsPrintDebugMessage
cmpwi r3, 0x0
beq L_81487AB4
li r3, 0x2
bl CDBReport_
lis r3, lbl_8166B5A8@ha
addi r3, r3, lbl_8166B5A8@l
crclr 4*cr1+eq
bl OSReport
L_81487AB4:
li r31, 0x5
b L_81487B14
L_81487ABC:
mr r3, r30
mr r4, r29
mr r5, r31
bl CDBRecordInitDescriptor
mr r3, r30
bl CDBRecordIsExistFile
cmpwi r3, 0x0
bne L_81487B10
li r3, 0x2
bl CDBIsPrintDebugMessage
cmpwi r3, 0x0
beq L_81487B08
li r3, 0x2
bl CDBReport_
lis r3, lbl_8166B5B8@ha
mr r4, r31
addi r3, r3, lbl_8166B5B8@l
crclr 4*cr1+eq
bl OSReport
L_81487B08:
li r31, 0x23
b L_81487B14
L_81487B10:
li r31, 0x0
L_81487B14:
bl CDBUnlock
mr r3, r31
lwz r31, 0x1c(r1)
lwz r30, 0x18(r1)
lwz r29, 0x14(r1)
lwz r0, 0x24(r1)
mtlr r0
addi r1, r1, 0x20
blr
#endif
CDBErr CDBDatabaseFindByKey(CDBDatabase* database, CDBRecord* record, CDBRecordKey* recordKey) {
CDBErr result;
CDBLock();
if (!CDBRecordKeyIsValid(recordKey)) {
CDBReportError(lbl_8166B5A8);
result = CDB_ERROR_5;
} else {
CDBRecordInitDescriptor(record, database, recordKey);
if (!CDBRecordIsExistFile(record)) {
CDBReportError(lbl_8166B5B8, recordKey->keyString);
result = CDB_ERROR_CANNOT_OPEN_FILE;
} else {
result = CDB_ERROR_OK;
}
}
CDBUnlock();
return result;
}
CDBErr CDBDatabaseSearchConditionsIsMatch(CDBSearchConditions* conditions, char* key) {
@@ -2771,160 +2691,81 @@ CDBErr CDBDatabaseCleanUpEmptyDirectoriesMonth(char* year, CDBLocation location,
return CDB_ERROR_OK;
}
asm CDBErr CDBDatabaseCleanUpEmptyDirectories(CDBDatabase* database, CDBRecordLocation recordLocation) {
#ifdef __MWERKS__
nofralloc
stwu r1, -0x20(r1)
mflr r0
cmpwi r3, 0x0
stw r0, 0x24(r1)
stw r31, 0x1c(r1)
mr r31, r3
stw r30, 0x18(r1)
stw r29, 0x14(r1)
mr r29, r4
lwz r5, CDBDatabaseWorkBuf(r0)
addi r30, r5, 0x430c
bne L_8148A13C
li r3, 0x1
b L_8148A2FC
L_8148A13C:
bl CDBLock
lwz r3, 0x8(r31)
cmpwi r3, 0x0
beq L_8148A158
addis r3, r3, 0x1
lwz r31, -0x3ff0(r3)
b L_8148A15C
L_8148A158:
li r31, 0x0
L_8148A15C:
bl CDBUnlock
cmpwi r31, 0x0
bne L_8148A198
li r3, 0x2
bl CDBIsPrintDebugMessage
cmpwi r3, 0x0
beq L_8148A190
li r3, 0x2
bl CDBReport_
lis r3, lbl_8166B5D0@ha
addi r3, r3, lbl_8166B5D0@l
crclr 4*cr1+eq
bl OSReport
L_8148A190:
li r3, 0x1b
b L_8148A2FC
L_8148A198:
cmpwi r31, 0x1
bne L_8148A1D0
li r3, 0x2
bl CDBIsPrintDebugMessage
cmpwi r3, 0x0
beq L_8148A1C8
li r3, 0x2
bl CDBReport_
lis r3, lbl_8166B618@ha
addi r3, r3, lbl_8166B618@l
crclr 4*cr1+eq
bl OSReport
L_8148A1C8:
li r3, 0x1a
b L_8148A2FC
L_8148A1D0:
clrlwi. r0, r29, 31
beq L_8148A24C
mr r3, r30
li r4, 0x1
bl CDBFSFindFirstRoot
b L_8148A234
L_8148A1E8:
mr r3, r30
bl CDBFindDataIsDirectory
cmpwi r3, 0x0
beq L_8148A22C
mr r3, r30
bl CDBFindDataGetName
bl CDBFSIsYearDirName
cmpwi r3, 0x0
beq L_8148A22C
mr r3, r30
bl CDBFindDataGetName
li r4, 0x1
li r5, 0x0
bl CDBDatabaseCleanUpEmptyDirectoriesMonth
cmpwi r3, 0x0
beq L_8148A22C
b L_8148A2FC
L_8148A22C:
mr r3, r30
bl CDBFSFindNext
L_8148A234:
mr r3, r30
bl CDBFindDataIsEnd
cmpwi r3, 0x0
beq L_8148A1E8
mr r3, r30
bl CDBFSFindClose
L_8148A24C:
bl CDBVFSync
li r31, 0x0
bl CDBFSSDIsMounted
cmpwi r3, 0x0
beq L_8148A270
bl CDBFSSDIsEjected
cmpwi r3, 0x0
bne L_8148A270
li r31, 0x1
L_8148A270:
cmpwi r31, 0x0
beq L_8148A2F4
rlwinm. r0, r29, 0, 30, 30
beq L_8148A2F4
mr r3, r30
li r4, 0x2
bl CDBFSFindFirstRoot
b L_8148A2DC
L_8148A290:
mr r3, r30
bl CDBFindDataIsDirectory
cmpwi r3, 0x0
beq L_8148A2D4
mr r3, r30
bl CDBFindDataGetName
bl CDBFSIsYearDirName
cmpwi r3, 0x0
beq L_8148A2D4
mr r3, r30
bl CDBFindDataGetName
li r4, 0x2
li r5, 0x0
bl CDBDatabaseCleanUpEmptyDirectoriesMonth
cmpwi r3, 0x0
beq L_8148A2D4
b L_8148A2FC
L_8148A2D4:
mr r3, r30
bl CDBFSFindNext
L_8148A2DC:
mr r3, r30
bl CDBFindDataIsEnd
cmpwi r3, 0x0
beq L_8148A290
mr r3, r30
bl CDBFSFindClose
L_8148A2F4:
bl CDBVFSync
li r3, 0x0
L_8148A2FC:
lwz r0, 0x24(r1)
lwz r31, 0x1c(r1)
lwz r30, 0x18(r1)
lwz r29, 0x14(r1)
mtlr r0
addi r1, r1, 0x20
blr
#endif
CDBErr CDBDatabaseCleanUpEmptyDirectories(CDBDatabase* database, CDBRecordLocation recordLocation) {
CDBDatabase* db;
CDBFindData* find;
int flags;
CDBDatabaseState* instance;
CDBErr result;
BOOL sdAvailable;
db = database;
find = &CDBDatabaseWorkBuf->year;
if (db == NULL) {
return CDB_ERROR_1;
}
CDBLock();
instance = db->instance;
if (instance != NULL) {
flags = instance->flags;
} else {
flags = 0;
}
CDBUnlock();
if (flags == 0) {
CDBReportError(lbl_8166B5D0);
return CDB_ERROR_27;
}
if (flags == 1) {
CDBReportError(lbl_8166B618);
return CDB_ERROR_26;
}
if ((recordLocation & 1) != 0) {
CDBFSFindFirstRoot(find, 1);
while (CDBFindDataIsEnd(find) == 0) {
if (CDBFindDataIsDirectory(find) != 0) {
if (CDBFSIsYearDirName(CDBFindDataGetName(find)) != 0) {
result = CDBDatabaseCleanUpEmptyDirectoriesMonth(CDBFindDataGetName(find), 1, NULL);
if (result != CDB_ERROR_OK) {
return result;
}
}
}
CDBFSFindNext(find);
}
CDBFSFindClose(find);
}
CDBVFSync();
sdAvailable = 0;
if (CDBFSSDIsMounted() != 0) {
if (CDBFSSDIsEjected() == 0) {
sdAvailable = 1;
}
}
if (sdAvailable != 0) {
if ((recordLocation & 2) != 0) {
CDBFSFindFirstRoot(find, 2);
while (CDBFindDataIsEnd(find) == 0) {
if (CDBFindDataIsDirectory(find) != 0) {
if (CDBFSIsYearDirName(CDBFindDataGetName(find)) != 0) {
result = CDBDatabaseCleanUpEmptyDirectoriesMonth(CDBFindDataGetName(find), 2, NULL);
if (result != CDB_ERROR_OK) {
return result;
}
}
}
CDBFSFindNext(find);
}
CDBFSFindClose(find);
}
}
CDBVFSync();
return CDB_ERROR_OK;
}
#pragma section data_type ".data"