Decode address/sdChannelSelect nested-switch guards + retail bug fossil (stays NonMatching) #970

Merged
devin-ai-integration[bot] merged 1 commits from scene4-clean into main 2026-10-02 22:13:22 +00:00
devin-ai-integration[bot] commented 2026-10-02 22:11:50 +00:00 (Migrated from github.com)

Summary

Decodes for iplAddress, iplAddressEdit, iplSDChannelSelect — all stay NonMatching (documented tie walls remain) but several functions are now instruction-identical.

Key decodes:

  • Address::start_drag_event: nested single-case switch over mState/mMode emits the orig's b<cond>+b two-branch guard — insn-identical (7-word r26↔r29 web-home residual).
  • Address::onEventDerived: TRIG→ON_POINT no-break fallthrough plus || polarity fold — insn-identical, 81 regname residuals.
  • AddressEdit::set_err_msg: u32 messageId declared uninitialized with default: break — this is a faithful reproduction of the retail bug: base asm's default path branches straight to getMessage with r4 never written (verified in build/43U/obj).
  • movePane_onDrag width-accumulate scoping, FriendListCache::update member-chain regroup (getInfo(index) calls instead of a cached info pointer), create/get_friendinfo marshal shapes.

Verified: full ninja build, main.dol sha1 26116613f624061ba99c8d1a299aaa6efa85670d, data 100% on all three units, zero lbl_/volatile/score-only constructs. Walls documented in tools/decomp-assist/scene4.attempts.md (bne;b guard folding, remat-vs-pin, callee web-order swaps).

Link to Devin session: https://app.devin.ai/sessions/222dce3cd2364f14bc9a8d5ef82cda00
Open in Devin Desktop: https://app.devin.ai/desktop/session/222dce3cd2364f14bc9a8d5ef82cda00?variant=devin
Requested by: @coah80

## Summary Decodes for `iplAddress`, `iplAddressEdit`, `iplSDChannelSelect` — all stay `NonMatching` (documented tie walls remain) but several functions are now instruction-identical. Key decodes: - `Address::start_drag_event`: nested single-case `switch` over `mState`/`mMode` emits the orig's `b<cond>+b` two-branch guard — insn-identical (7-word `r26↔r29` web-home residual). - `Address::onEventDerived`: `TRIG→ON_POINT` no-break fallthrough plus `||` polarity fold — insn-identical, 81 regname residuals. - `AddressEdit::set_err_msg`: `u32 messageId` declared **uninitialized** with `default: break` — this is a faithful reproduction of the retail bug: base asm's default path branches straight to `getMessage` with `r4` never written (verified in `build/43U/obj`). - `movePane_onDrag` width-accumulate scoping, `FriendListCache::update` member-chain regroup (`getInfo(index)` calls instead of a cached `info` pointer), `create`/`get_friendinfo` marshal shapes. Verified: full ninja build, `main.dol` sha1 `26116613f624061ba99c8d1a299aaa6efa85670d`, data 100% on all three units, zero `lbl_`/volatile/score-only constructs. Walls documented in `tools/decomp-assist/scene4.attempts.md` (bne;b guard folding, remat-vs-pin, callee web-order swaps). Link to Devin session: https://app.devin.ai/sessions/222dce3cd2364f14bc9a8d5ef82cda00 Open in Devin Desktop: https://app.devin.ai/desktop/session/222dce3cd2364f14bc9a8d5ef82cda00?variant=devin Requested by: @coah80
devin-ai-integration[bot] commented 2026-10-02 22:11:53 +00:00 (Migrated from github.com)

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring
<!-- devin-pr-monitoring-controls --> I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)". - [ ] Disable automatic comment, CI, and merge conflict monitoring
coah80 commented 2026-10-02 22:13:20 +00:00 (Migrated from github.com)

Reviewed and merged: rebased on main, full build ok, DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d, 0 regressions, 0 forbidden patterns.

Reviewed and merged: rebased on main, full build ok, DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d, 0 regressions, 0 forbidden patterns.
Sign in to join this conversation.