Decode address/sdChannelSelect nested-switch guards + retail bug fossil (stays NonMatching) #970
Reference in New Issue
Block a user
Delete Branch "scene4-clean"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Decodes for
iplAddress,iplAddressEdit,iplSDChannelSelect— all stayNonMatching(documented tie walls remain) but several functions are now instruction-identical.Key decodes:
Address::start_drag_event: nested single-caseswitchovermState/mModeemits the orig'sb<cond>+btwo-branch guard — insn-identical (7-wordr26↔r29web-home residual).Address::onEventDerived:TRIG→ON_POINTno-break fallthrough plus||polarity fold — insn-identical, 81 regname residuals.AddressEdit::set_err_msg:u32 messageIddeclared uninitialized withdefault: break— this is a faithful reproduction of the retail bug: base asm's default path branches straight togetMessagewithr4never written (verified inbuild/43U/obj).movePane_onDragwidth-accumulate scoping,FriendListCache::updatemember-chain regroup (getInfo(index)calls instead of a cachedinfopointer),create/get_friendinfomarshal shapes.Verified: full ninja build,
main.dolsha126116613f624061ba99c8d1a299aaa6efa85670d, data 100% on all three units, zerolbl_/volatile/score-only constructs. Walls documented intools/decomp-assist/scene4.attempts.md(bne;b guard folding, remat-vs-pin, callee web-order swaps).Link to Devin session: https://app.devin.ai/sessions/222dce3cd2364f14bc9a8d5ef82cda00
Open in Devin Desktop: https://app.devin.ai/desktop/session/222dce3cd2364f14bc9a8d5ef82cda00?variant=devin
Requested by: @coah80
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Reviewed and merged: rebased on main, full build ok, DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d, 0 regressions, 0 forbidden patterns.