[codex] Match Kitayama normal state #175

Merged
coah80 merged 1 commits from agent/worker59-next-unit into main 2026-09-22 08:13:59 +00:00
coah80 commented 2026-09-22 08:12:40 +00:00 (Migrated from github.com)

What changed

Marks src/scene/kitayamaTest/iplKitayamaTest.cpp as Matching and adds a scoped MWCC ppc_iro_level 2 pragma around KitayamaTest::calcNormal().

The pragma resolves the final register allocation difference while keeping the implementation readable C++ and adding no inline assembly.

Validation

  • Kitayama unit objdiff: code 2520/2520 (100%), data 632/632 (100%), functions 12/12 (100%), complete/link 100%.
  • calcNormal__Q33ipl5scene12KitayamaTestFv: 0 differing instructions out of 464 (0x740 bytes).
  • pool_diff.py: POOL IDENTICAL up to 17 (mine=17 base=17).
  • Focused object build passed with /home/cole/projects/tests/.venv/bin/ninja -C . build/43U/src/src/scene/kitayamaTest/iplKitayamaTest.o.
  • Full 43U DOL link completed. The repository-wide SHA check remains failing because other units are still incomplete; this branch produced 8945f3c07cdec1fd09312c60e0035cf3ab08b016 versus the final target 26116613f624061ba99c8d1a299aaa6efa85670d.
  • git diff --check passed.

Note

Match Kitayama normal state by setting iplKitayamaTest to Matching and IRO level 2

  • Reclassifies the kitayamaTest scene object from Equivalent to Matching in configure.py, enabling per-method compiler overrides.
  • Wraps ipl.KitayamaTest.calcNormal in PPC pragma push/pop and sets IRO level to 2 in iplKitayamaTest.cpp to match the expected normal state output.
  • Behavioral Change: reclassification from Equivalent to Matching means the build now treats iplKitayamaTest.cpp output as match-critical rather than equivalent; reviewers should verify the IRO level 2 pragma produces the expected binary output.

Macroscope summarized 7a30824.

## What changed Marks `src/scene/kitayamaTest/iplKitayamaTest.cpp` as `Matching` and adds a scoped MWCC `ppc_iro_level 2` pragma around `KitayamaTest::calcNormal()`. The pragma resolves the final register allocation difference while keeping the implementation readable C++ and adding no inline assembly. ## Validation - Kitayama unit objdiff: code `2520/2520` (100%), data `632/632` (100%), functions `12/12` (100%), complete/link `100%`. - `calcNormal__Q33ipl5scene12KitayamaTestFv`: `0` differing instructions out of `464` (`0x740` bytes). - `pool_diff.py`: `POOL IDENTICAL up to 17 (mine=17 base=17)`. - Focused object build passed with `/home/cole/projects/tests/.venv/bin/ninja -C . build/43U/src/src/scene/kitayamaTest/iplKitayamaTest.o`. - Full 43U DOL link completed. The repository-wide SHA check remains failing because other units are still incomplete; this branch produced `8945f3c07cdec1fd09312c60e0035cf3ab08b016` versus the final target `26116613f624061ba99c8d1a299aaa6efa85670d`. - `git diff --check` passed. <!-- Macroscope's pull request summary starts here --> <!-- Macroscope will only edit the content between these invisible markers, and the markers themselves will not be visible in the GitHub rendered markdown. --> <!-- If you delete either of the start / end markers from your PR's description, Macroscope will append its summary at the bottom of the description. --> > [!NOTE] > ### Match Kitayama normal state by setting `iplKitayamaTest` to Matching and IRO level 2 > - Reclassifies the `kitayamaTest` scene object from `Equivalent` to `Matching` in [configure.py](https://github.com/coah80/wii-ipl/pull/175/files#diff-4d5f3192809ec1b9add6b33007e0c50031ad9a0a2f3f55a481b506468824db2c), enabling per-method compiler overrides. > - Wraps `ipl.KitayamaTest.calcNormal` in PPC pragma push/pop and sets IRO level to 2 in [iplKitayamaTest.cpp](https://github.com/coah80/wii-ipl/pull/175/files#diff-057457348975e9de12c6705f871a2e648c2a59c0c351942f01a236d483444cd5) to match the expected normal state output. > - Behavioral Change: reclassification from `Equivalent` to `Matching` means the build now treats `iplKitayamaTest.cpp` output as match-critical rather than equivalent; reviewers should verify the IRO level 2 pragma produces the expected binary output. > > <!-- Macroscope's review summary starts here --> > > <sup><a href="https://app.macroscope.com">Macroscope</a> summarized 7a30824.</sup> > <!-- Macroscope's review summary ends here --> > <!-- Macroscope's pull request summary ends here -->
Sign in to join this conversation.