Match remaining focus object helpers #39

Merged
coah80 merged 1 commits from codex/worker-focus-object-20260921 into main 2026-09-21 22:27:48 +00:00
coah80 commented 2026-09-21 22:27:26 +00:00 (Migrated from github.com)

Improves exact matching in src/scene/board/iplFocusObject.cpp. Exact focus-object code: 17,860/20,332 -> 19,436/20,332 (+1,576 bytes); exact functions: 85/89 -> 87/89 (+2). Remaining mismatches are cmn_calc and make_parsed_text. Full 43U build passed, pool/context checks passed, and build/43U/main.dol SHA1 is 26116613f624061ba99c8d1a299aaa6efa85670d.

Note

Refactor focus object attachment loop and init_url_proc text-pane setup

  • Reworks the attachment-processing loop in the board-record initialization to read each attachment directly from the record header rather than through a temporary pointer; the same addresses are still passed to message-board and picture helpers.
  • Rewrites the text-pane local in init_url_proc as an explicit assignment in both runtime-type branches and inlines the type-info lookup into the derived-type test. The selected pane is unchanged.
  • Risk: none identified — both changes are structural refactors with no intended behavioral difference.

Macroscope summarized 12bdbae.

Improves exact matching in src/scene/board/iplFocusObject.cpp. Exact focus-object code: 17,860/20,332 -> 19,436/20,332 (+1,576 bytes); exact functions: 85/89 -> 87/89 (+2). Remaining mismatches are cmn_calc and make_parsed_text. Full 43U build passed, pool/context checks passed, and build/43U/main.dol SHA1 is 26116613f624061ba99c8d1a299aaa6efa85670d. <!-- Macroscope's pull request summary starts here --> <!-- Macroscope will only edit the content between these invisible markers, and the markers themselves will not be visible in the GitHub rendered markdown. --> <!-- If you delete either of the start / end markers from your PR's description, Macroscope will append its summary at the bottom of the description. --> > [!NOTE] > ### Refactor focus object attachment loop and `init_url_proc` text-pane setup > - Reworks the attachment-processing loop in the board-record initialization to read each attachment directly from the record header rather than through a temporary pointer; the same addresses are still passed to message-board and picture helpers. > - Rewrites the text-pane local in `init_url_proc` as an explicit assignment in both runtime-type branches and inlines the type-info lookup into the derived-type test. The selected pane is unchanged. > - Risk: none identified — both changes are structural refactors with no intended behavioral difference. > > <!-- Macroscope's review summary starts here --> > > <sup><a href="https://app.macroscope.com">Macroscope</a> summarized 12bdbae.</sup> > <!-- Macroscope's review summary ends here --> > <!-- Macroscope's pull request summary ends here -->
Sign in to join this conversation.