cleanup(tiInputForm): name float/color sdata constants #626

Merged
coah80 merged 2 commits from cleanup/tiinputform-floats into main 2026-10-01 23:25:29 +00:00
coah80 commented 2026-10-01 23:10:20 +00:00 (Migrated from github.com)

Renames

Unit-prefixed float/color constants in tiInputForm.cpp + symbols.txt so they do not collide with other units' globals (scHalfF / scTwoF already in ChanAppBox):

  • lbl_* / short sc* floats → scInputFormZeroF, scInputFormHalfF, scInputFormTwoF, …
  • color bytes → scInputFormColorRU8 / GU8 / BU8 / AU8

Left alone: unused lbl_816973A4 / lbl_816973AC (N_KOR/N_CHN decls only).

Verification

  • ninja build/43U/ok → ok
  • DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d
## Renames Unit-prefixed float/color constants in `tiInputForm.cpp` + `symbols.txt` so they do not collide with other units' globals (`scHalfF` / `scTwoF` already in ChanAppBox): - `lbl_*` / short `sc*` floats → `scInputFormZeroF`, `scInputFormHalfF`, `scInputFormTwoF`, … - color bytes → `scInputFormColorRU8` / `GU8` / `BU8` / `AU8` Left alone: unused `lbl_816973A4` / `lbl_816973AC` (N_KOR/N_CHN decls only). ## Verification - `ninja build/43U/ok` → ok - DOL sha1 `26116613f624061ba99c8d1a299aaa6efa85670d`
coah80 commented 2026-10-01 23:14:43 +00:00 (Migrated from github.com)

Rebased onto latest main; verified ok + sha1 26116613f624061ba99c8d1a299aaa6efa85670d.

Rebased onto latest main; verified ok + sha1 `26116613f624061ba99c8d1a299aaa6efa85670d`.
coah80 commented 2026-10-01 23:15:20 +00:00 (Migrated from github.com)

Changes requested: 0x81694900/0x81694904 belong to iplChanAppBox (its .sdata2 split is 0x81694900-0x81694910, and iplChanAppBox.cpp defines scHalfF/scTwoF), not tiInputForm. Renaming them to scInputForm* in symbols.txt breaks that unit's data pairing (iplChanAppBox matched data 536 -> 520). Please drop those two renames and keep only the tiInputForm-owned constants (0x81694D28+).

Changes requested: `0x81694900/0x81694904` belong to iplChanAppBox (its .sdata2 split is 0x81694900-0x81694910, and iplChanAppBox.cpp defines `scHalfF`/`scTwoF`), not tiInputForm. Renaming them to `scInputForm*` in symbols.txt breaks that unit's data pairing (iplChanAppBox matched data 536 -> 520). Please drop those two renames and keep only the tiInputForm-owned constants (0x81694D28+).
coah80 commented 2026-10-01 23:22:05 +00:00 (Migrated from github.com)

Addressed review: restored scHalfF/scTwoF at 0x81694900/0x81694904 for ChanAppBox; left only tiInputForm-owned scInputForm* at 0x81694D28+. Rebased onto latest main; verified ok + sha1 26116613f624061ba99c8d1a299aaa6efa85670d. ChanAppBox matched data 536/536.

Addressed review: restored `scHalfF`/`scTwoF` at 0x81694900/0x81694904 for ChanAppBox; left only tiInputForm-owned `scInputForm*` at 0x81694D28+. Rebased onto latest main; verified ok + sha1 26116613f624061ba99c8d1a299aaa6efa85670d. ChanAppBox matched data 536/536.
coah80 commented 2026-10-01 23:25:26 +00:00 (Migrated from github.com)

Reviewed and merged: rebased on main, full build ok, DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d, 0 regressions, 0 forbidden patterns.

Reviewed and merged: rebased on main, full build ok, DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d, 0 regressions, 0 forbidden patterns.
coah80 commented 2026-10-01 23:25:50 +00:00 (Migrated from github.com)

Rebased onto latest main; verified ok + sha1 26116613f624061ba99c8d1a299aaa6efa85670d.

Rebased onto latest main; verified ok + sha1 26116613f624061ba99c8d1a299aaa6efa85670d.
Sign in to join this conversation.