cleanup(tiInputForm): name float/color sdata constants #626
Reference in New Issue
Block a user
Delete Branch "cleanup/tiinputform-floats"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Renames
Unit-prefixed float/color constants in
tiInputForm.cpp+symbols.txtso they do not collide with other units' globals (scHalfF/scTwoFalready in ChanAppBox):lbl_*/ shortsc*floats →scInputFormZeroF,scInputFormHalfF,scInputFormTwoF, …scInputFormColorRU8/GU8/BU8/AU8Left alone: unused
lbl_816973A4/lbl_816973AC(N_KOR/N_CHN decls only).Verification
ninja build/43U/ok→ ok26116613f624061ba99c8d1a299aaa6efa85670dRebased onto latest main; verified ok + sha1
26116613f624061ba99c8d1a299aaa6efa85670d.Changes requested:
0x81694900/0x81694904belong to iplChanAppBox (its .sdata2 split is 0x81694900-0x81694910, and iplChanAppBox.cpp definesscHalfF/scTwoF), not tiInputForm. Renaming them toscInputForm*in symbols.txt breaks that unit's data pairing (iplChanAppBox matched data 536 -> 520). Please drop those two renames and keep only the tiInputForm-owned constants (0x81694D28+).Addressed review: restored
scHalfF/scTwoFat 0x81694900/0x81694904 for ChanAppBox; left only tiInputForm-ownedscInputForm*at 0x81694D28+. Rebased onto latest main; verified ok + sha1 26116613f624061ba99c8d1a299aaa6efa85670d. ChanAppBox matched data 536/536.Reviewed and merged: rebased on main, full build ok, DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d, 0 regressions, 0 forbidden patterns.
Rebased onto latest main; verified ok + sha1 26116613f624061ba99c8d1a299aaa6efa85670d.