Repair two function symbol identities without changing extents #720
Reference in New Issue
Block a user
Delete Branch "agent/bittle/symbol-name-repairs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Metadata only — no new code or matching gain
Two reconstructed labels prevent exact-name tooling from finding the existing source functions:
pdm_disk_convert_block_into_sector. Its address remains 0x815C79D8, size 0xB0. The existing C function is already 44/44 instructions exact. After correction, all 17/17 functions infa/pdm_diskpass exact-name ctxdiff with zero differences.__nupGetBootVersion__FP14ESTitleVersionto__nupGetBootVersion__FP14NUPContextInfoP14ESTitleVersion. Address remains 0x815F0A40, size 0x28C, scope local. The original caller moves context into r3 and title into r4 before the call; the callee saves r4 as its title pointer and reads the context's owned-title count/array from r3+0x28/r3+0x2C. This is a two-parameter ABI, matching the existing C++ definition and emitted symbol.The NUP function is not a new match: it still has 163/163 instructions with 17 register-allocation differences, and now receives its honest exact-name objdiff score of 99.35583% instead of being unmapped. NUP's fuzzy unit score rises 93.442955 -> 99.46117% solely from attribution; exact code remains 7,496/10,764, exact functions 19/23, and data 1,720/1,720.
Verification on
184bee01config/43U/symbols.txtchange; no address, size, split, scope, source, or padding changesTested/published tree
428c78ab4c8605abe94c3426d2d4ae944219fbbe. Kept separate from source-matching PRs, as requested. Whole-project completion remains incomplete.Reviewed and merged: rebased on main, full build ok, DOL sha1 26116613f624061ba99c8d1a299aaa6efa85670d, 0 regressions, 0 forbidden patterns.