| 1 |
trial |
baseline_location |
category |
decision |
source_change |
code_bytes_before_after |
data_bytes_before_after |
function_score_changes |
ELF_sections_changed |
pool_target_identical |
pool_baseline_identical |
| 2 |
board-carrier-declared |
src/scene/board/iplBoard.cpp:432 |
targeted source cleanup |
restored |
- struct RecordReadState { | - BOOL recordInterrupts; | - u32 dataSize; | - BOOL waitInterrupts; | - BOOL slotInterrupts; | - int recordSecond; | - int recordMin; | - int recordHour; | - u32 recordGC; | - CDBId cdbId; | - char recordType[8]; | - utility::Date recordDate; | - CDBRecordKey recordKey; | - } state; | - state.recordGC = 0; | + BOOL recordInterrupts; | + u32 dataSize; | + BOOL waitInterrupts; | + BOOL slotInterrupts; | + int recordSecond; | + int recordMin; | + int recordHour; | + u32 recordGC; | + CDBId cdbId; | + char recordType[8]; | + utility::Date recordDate; | + CDBRecordKey recordKey; | + recordGC = 0; | - state.recordType[0] = 0; | - state.recordType[1] = 0; | - state.recordType[2] = 0; | - state.recordType[3] = 0; | - state.recordType[4] = 0; | - state.recordType[5] = 0; | - state.recordType[6] = 0; | - state.recordType[7] = 0; | + recordType[0] = 0; | + recordType[1] = 0; | + recordType[2] = 0; | + recordType[3] = 0; | + recordType[4] = 0; | + recordType[5] = 0; | + recordType[6] = 0; | + recordType[7] = 0; | - CDBRecordGetCalendarTimeForce(record, &state.recordDate.year, &state.recordDate.month, &state.recordDate.day, | - &state.recordHour, &state.recordMin, &state.recordSecond); | - CDBRecordGetKeyForce(record, &state.recordKey); | - CDBRecordGetTypeForce(record, state.recordType); | - CDBRecordGetGameCodeForce(record, (char*)&state.recordGC); | + CDBReco [see trial candidate in /tmp/rx56/trials] |
20276 -> 19144 |
896 -> 896 |
appendRecord__Q33ipl5scene5BoardFP10_CDBRecord 100% -> 97.678444% |
.strtab, .text |
True |
True |
| 3 |
board-carrier-reversed |
src/scene/board/iplBoard.cpp:432 |
targeted source cleanup |
restored |
- struct RecordReadState { | - BOOL recordInterrupts; | - u32 dataSize; | - BOOL waitInterrupts; | - BOOL slotInterrupts; | - int recordSecond; | - int recordMin; | - int recordHour; | - u32 recordGC; | - CDBId cdbId; | - char recordType[8]; | - utility::Date recordDate; | - CDBRecordKey recordKey; | - } state; | - state.recordGC = 0; | + CDBRecordKey recordKey; | + utility::Date recordDate; | + char recordType[8]; | + CDBId cdbId; | + u32 recordGC; | + int recordHour; | + int recordMin; | + int recordSecond; | + BOOL slotInterrupts; | + BOOL waitInterrupts; | + u32 dataSize; | + BOOL recordInterrupts; | + recordGC = 0; | - state.recordType[0] = 0; | - state.recordType[1] = 0; | - state.recordType[2] = 0; | - state.recordType[3] = 0; | - state.recordType[4] = 0; | - state.recordType[5] = 0; | - state.recordType[6] = 0; | - state.recordType[7] = 0; | + recordType[0] = 0; | + recordType[1] = 0; | + recordType[2] = 0; | + recordType[3] = 0; | + recordType[4] = 0; | + recordType[5] = 0; | + recordType[6] = 0; | + recordType[7] = 0; | - CDBRecordGetCalendarTimeForce(record, &state.recordDate.year, &state.recordDate.month, &state.recordDate.day, | - &state.recordHour, &state.recordMin, &state.recordSecond); | - CDBRecordGetKeyForce(record, &state.recordKey); | - CDBRecordGetTypeForce(record, state.recordType); | - CDBRecordGetGameCodeForce(record, (char*)&state.recordGC); | + CDBReco [see trial candidate in /tmp/rx56/trials] |
20276 -> 19144 |
896 -> 896 |
appendRecord__Q33ipl5scene5BoardFP10_CDBRecord 100% -> 97.837456% |
.strtab, .text |
True |
True |
| 4 |
aoss-integrity-declared |
src/scene/setting/AOSS.c:1854 |
targeted source cleanup |
restored |
- struct { u32 expected; u32 actual; } integrity; | + u32 expectedChecksum; | + u32 actualChecksum; | - integrity.expected = message->checksum; | + expectedChecksum = message->checksum; | - integrity.actual = 0xffffffff; | + actualChecksum = 0xffffffff; | - integrity.actual = (integrity.actual >> 8) ^ s_crcTable[(integrity.actual ^ decryptedData[crcIndex]) & 0xff]; | + actualChecksum = (actualChecksum >> 8) ^ s_crcTable[(actualChecksum ^ decryptedData[crcIndex]) & 0xff]; | - if (((integrity.actual ^ 0xffffffff) & 0xff) != integrity.expected) { | + if (((actualChecksum ^ 0xffffffff) & 0xff) != expectedChecksum) { |
7720 -> 6436 |
3928 -> 3928 |
AOSSDecryptMessage 100% -> 99.75078% |
.strtab, .text |
True |
True |
| 5 |
aoss-integrity-reversed |
src/scene/setting/AOSS.c:1854 |
targeted source cleanup |
restored |
- struct { u32 expected; u32 actual; } integrity; | + u32 actualChecksum; | + u32 expectedChecksum; | - integrity.expected = message->checksum; | + expectedChecksum = message->checksum; | - integrity.actual = 0xffffffff; | + actualChecksum = 0xffffffff; | - integrity.actual = (integrity.actual >> 8) ^ s_crcTable[(integrity.actual ^ decryptedData[crcIndex]) & 0xff]; | + actualChecksum = (actualChecksum >> 8) ^ s_crcTable[(actualChecksum ^ decryptedData[crcIndex]) & 0xff]; | - if (((integrity.actual ^ 0xffffffff) & 0xff) != integrity.expected) { | + if (((actualChecksum ^ 0xffffffff) & 0xff) != expectedChecksum) { |
7720 -> 6436 |
3928 -> 3928 |
AOSSDecryptMessage 100% -> 99.75078% |
.strtab, .text |
True |
True |
| 6 |
aoss-construction-declared |
src/scene/setting/AOSS.c:2330 |
targeted source cleanup |
restored |
- struct { | - AOSSSocketAddress destination; | - AOSSHelloRecord hello; | - u8 accessPointName[8]; | - AOSSKeySchedule schedule; | - } construction; | + AOSSSocketAddress destination; | + AOSSHelloRecord hello; | + u8 accessPointName[8]; | + AOSSKeySchedule schedule; | - memset(&construction.hello, 0, sizeof(construction.hello)); | + memset(&hello, 0, sizeof(hello)); | - construction.hello.data.fields.type = 2; | - construction.hello.data.fields.reserved01 = 0; | - construction.hello.data.fields.length = SOHtoNs(4); | - construction.hello.data.fields.supportedModes = s_runtime.flags; | - construction.hello.data.fields.supportedModes = SOHtoNl(construction.hello.data.fields.supportedModes); | + hello.data.fields.type = 2; | + hello.data.fields.reserved01 = 0; | + hello.data.fields.length = SOHtoNs(4); | + hello.data.fields.supportedModes = s_runtime.flags; | + hello.data.fields.supportedModes = SOHtoNl(hello.data.fields.supportedModes); | - checksum = (checksum >> 8) ^ crcTable[(checksum ^ construction.hello.data.bytes[part * 2 + index]) & 0xff]; | + checksum = (checksum >> 8) ^ crcTable[(checksum ^ hello.data.bytes[part * 2 + index]) & 0xff]; | - construction.schedule.bytes = (u8*)AOSSi_Alloc(8); | - if (construction.schedule.bytes != 0) { | + schedule.bytes = (u8*)AOSSi_Alloc(8); | + if (schedule.bytes != 0) { | - AOSSInitKeySchedule(&construction.schedule, (const u8*)&s_pack [see trial candidate in /tmp/rx56/trials] |
7720 -> 7720 |
3928 -> 3928 |
AOSSSendHelloRequest 92.48351% -> 91.69231% |
.strtab, .text |
True |
True |
| 7 |
aoss-construction-reversed |
src/scene/setting/AOSS.c:2330 |
targeted source cleanup |
restored |
- struct { | - AOSSSocketAddress destination; | - AOSSHelloRecord hello; | - u8 accessPointName[8]; | - AOSSKeySchedule schedule; | - } construction; | + AOSSKeySchedule schedule; | + u8 accessPointName[8]; | + AOSSHelloRecord hello; | + AOSSSocketAddress destination; | - memset(&construction.hello, 0, sizeof(construction.hello)); | + memset(&hello, 0, sizeof(hello)); | - construction.hello.data.fields.type = 2; | - construction.hello.data.fields.reserved01 = 0; | - construction.hello.data.fields.length = SOHtoNs(4); | - construction.hello.data.fields.supportedModes = s_runtime.flags; | - construction.hello.data.fields.supportedModes = SOHtoNl(construction.hello.data.fields.supportedModes); | + hello.data.fields.type = 2; | + hello.data.fields.reserved01 = 0; | + hello.data.fields.length = SOHtoNs(4); | + hello.data.fields.supportedModes = s_runtime.flags; | + hello.data.fields.supportedModes = SOHtoNl(hello.data.fields.supportedModes); | - checksum = (checksum >> 8) ^ crcTable[(checksum ^ construction.hello.data.bytes[part * 2 + index]) & 0xff]; | + checksum = (checksum >> 8) ^ crcTable[(checksum ^ hello.data.bytes[part * 2 + index]) & 0xff]; | - construction.schedule.bytes = (u8*)AOSSi_Alloc(8); | - if (construction.schedule.bytes != 0) { | + schedule.bytes = (u8*)AOSSi_Alloc(8); | + if (schedule.bytes != 0) { | - AOSSInitKeySchedule(&construction.schedule, (const u8*)&s_pack [see trial candidate in /tmp/rx56/trials] |
7720 -> 7720 |
3928 -> 3928 |
AOSSSendHelloRequest 92.48351% -> 91.72527% |
.strtab, .text |
True |
True |
| 8 |
cdb-decoded-declared |
libs/RevoEX/src/cdb/CDBDatabase.c:353 |
targeted source cleanup |
restored |
- struct { | - u16 makerCode; | - u32 gameCode; | - CDBDate date; | - char type[8]; | - } decoded; | - CDBConvKeyStrToEpochValue(key, &decoded.date); | - if (conditions->beginDate > decoded.date || decoded.date > conditions->endDate) return CDB_ERROR_OK; | + u16 makerCode; | + u32 gameCode; | + CDBDate date; | + char type[8]; | + CDBConvKeyStrToEpochValue(key, &date); | + if (conditions->beginDate > date || date > conditions->endDate) return CDB_ERROR_OK; | - CDBConvKeyStrToMakerCode(key, (u32*)&decoded.makerCode); | - if (conditions->makerCode != decoded.makerCode) return CDB_ERROR_OK; | + CDBConvKeyStrToMakerCode(key, (u32*)&makerCode); | + if (conditions->makerCode != makerCode) return CDB_ERROR_OK; | - CDBConvKeyStrToGameCode(key, &decoded.gameCode); | - if (conditions->gameCode != decoded.gameCode) return CDB_ERROR_OK; | + CDBConvKeyStrToGameCode(key, &gameCode); | + if (conditions->gameCode != gameCode) return CDB_ERROR_OK; | - CDBConvKeyStrToType(key, decoded.type); | - if (CDBCompareTypeStr(conditions->type, decoded.type)) return CDB_ERROR_OK; | + CDBConvKeyStrToType(key, type); | + if (CDBCompareTypeStr(conditions->type, type)) return CDB_ERROR_OK; |
12152 -> 11896 |
312 -> 312 |
CDBDatabaseSearchConditionsIsMatch 100% -> 99.90625% |
.text |
True |
True |
| 9 |
cdb-decoded-reversed |
libs/RevoEX/src/cdb/CDBDatabase.c:353 |
targeted source cleanup |
restored |
- struct { | - u16 makerCode; | - u32 gameCode; | - CDBDate date; | - char type[8]; | - } decoded; | - CDBConvKeyStrToEpochValue(key, &decoded.date); | - if (conditions->beginDate > decoded.date || decoded.date > conditions->endDate) return CDB_ERROR_OK; | + char type[8]; | + CDBDate date; | + u32 gameCode; | + u16 makerCode; | + CDBConvKeyStrToEpochValue(key, &date); | + if (conditions->beginDate > date || date > conditions->endDate) return CDB_ERROR_OK; | - CDBConvKeyStrToMakerCode(key, (u32*)&decoded.makerCode); | - if (conditions->makerCode != decoded.makerCode) return CDB_ERROR_OK; | + CDBConvKeyStrToMakerCode(key, (u32*)&makerCode); | + if (conditions->makerCode != makerCode) return CDB_ERROR_OK; | - CDBConvKeyStrToGameCode(key, &decoded.gameCode); | - if (conditions->gameCode != decoded.gameCode) return CDB_ERROR_OK; | + CDBConvKeyStrToGameCode(key, &gameCode); | + if (conditions->gameCode != gameCode) return CDB_ERROR_OK; | - CDBConvKeyStrToType(key, decoded.type); | - if (CDBCompareTypeStr(conditions->type, decoded.type)) return CDB_ERROR_OK; | + CDBConvKeyStrToType(key, type); | + if (CDBCompareTypeStr(conditions->type, type)) return CDB_ERROR_OK; |
12152 -> 11896 |
312 -> 312 |
CDBDatabaseSearchConditionsIsMatch 100% -> 99.96875% |
.text |
True |
True |
| 10 |
cdb-key-strings-declared |
libs/RevoEX/src/cdb/CDBRecordKey.c:32 |
targeted source cleanup |
restored |
- struct { | - char mcStr[4]; | - char typeStr[8]; | - char gcStr[8]; | - } strings; | + char mcStr[4]; | + char typeStr[8]; | + char gcStr[8]; | - CDBConvMCValueToMCStr(makerCode, strings.mcStr); | - CDBConvGCValueToGCStr(gameCode, strings.gcStr); | + CDBConvMCValueToMCStr(makerCode, mcStr); | + CDBConvGCValueToGCStr(gameCode, gcStr); | - strcpy(strings.typeStr, fileType); | - CDBToLower(((char*)strings.typeStr), typeLength); | + strcpy(typeStr, fileType); | + CDBToLower(((char*)typeStr), typeLength); | - sprintf(recordKey->keyString, "%010u_%s_%s_%03d.%s", epoch, strings.gcStr, strings.mcStr, serialNumber, strings.typeStr); | + sprintf(recordKey->keyString, "%010u_%s_%s_%03d.%s", epoch, gcStr, mcStr, serialNumber, typeStr); |
2424 -> 2164 |
64 -> 64 |
CDBRecordKeyInit 100% -> 99.92308% |
.strtab, .text |
True |
True |
| 11 |
cdb-key-strings-reversed |
libs/RevoEX/src/cdb/CDBRecordKey.c:32 |
targeted source cleanup |
restored |
- struct { | - char mcStr[4]; | - char typeStr[8]; | - char gcStr[8]; | - } strings; | + char gcStr[8]; | + char typeStr[8]; | + char mcStr[4]; | - CDBConvMCValueToMCStr(makerCode, strings.mcStr); | - CDBConvGCValueToGCStr(gameCode, strings.gcStr); | + CDBConvMCValueToMCStr(makerCode, mcStr); | + CDBConvGCValueToGCStr(gameCode, gcStr); | - strcpy(strings.typeStr, fileType); | - CDBToLower(((char*)strings.typeStr), typeLength); | + strcpy(typeStr, fileType); | + CDBToLower(((char*)typeStr), typeLength); | - sprintf(recordKey->keyString, "%010u_%s_%s_%03d.%s", epoch, strings.gcStr, strings.mcStr, serialNumber, strings.typeStr); | + sprintf(recordKey->keyString, "%010u_%s_%s_%03d.%s", epoch, gcStr, mcStr, serialNumber, typeStr); |
2424 -> 2164 |
64 -> 64 |
CDBRecordKeyInit 100% -> 99.92308% |
.strtab, .text |
True |
True |
| 12 |
mbox-carrier-declared |
libs/RevoEX/src/nwc24/NWC24MBoxCtrl.c:564 |
targeted source cleanup |
restored |
- struct { | - volatile u32 oldestId; | - MBCHeader* header; | - } mailbox; | + volatile u32 oldestId; | + MBCHeader* header; | - err = GetCachedMBCHeader(type, &mailbox.header); | + err = GetCachedMBCHeader(type, &header); | - if (mailbox.header->numMessages >= mailbox.header->capacity) | + if (header->numMessages >= header->capacity) | - if (mailbox.header->freeBytes <= required) | + if (header->freeBytes <= required) | - while (mailbox.header->numMessages >= mailbox.header->capacity || mailbox.header->freeBytes <= required) { | - GetOldestMsgId(mailbox.header, &mailbox.oldestId); | - err = DeleteMsg(type, mailbox.oldestId, FALSE); | + while (header->numMessages >= header->capacity || header->freeBytes <= required) { | + GetOldestMsgId(header, &oldestId); | + err = DeleteMsg(type, oldestId, FALSE); | - err = GetCachedMBCHeader(type, &mailbox.header); | + err = GetCachedMBCHeader(type, &header); |
10604 -> 10332 |
192 -> 192 |
NWC24iMBoxCheck 100% -> 99.911766% |
.strtab, .text |
True |
True |
| 13 |
mbox-carrier-reversed |
libs/RevoEX/src/nwc24/NWC24MBoxCtrl.c:564 |
targeted source cleanup |
restored |
- struct { | - volatile u32 oldestId; | - MBCHeader* header; | - } mailbox; | + MBCHeader* header; | + volatile u32 oldestId; | - err = GetCachedMBCHeader(type, &mailbox.header); | + err = GetCachedMBCHeader(type, &header); | - if (mailbox.header->numMessages >= mailbox.header->capacity) | + if (header->numMessages >= header->capacity) | - if (mailbox.header->freeBytes <= required) | + if (header->freeBytes <= required) | - while (mailbox.header->numMessages >= mailbox.header->capacity || mailbox.header->freeBytes <= required) { | - GetOldestMsgId(mailbox.header, &mailbox.oldestId); | - err = DeleteMsg(type, mailbox.oldestId, FALSE); | + while (header->numMessages >= header->capacity || header->freeBytes <= required) { | + GetOldestMsgId(header, &oldestId); | + err = DeleteMsg(type, oldestId, FALSE); | - err = GetCachedMBCHeader(type, &mailbox.header); | + err = GetCachedMBCHeader(type, &header); |
10604 -> 10604 |
192 -> 192 |
|
.strtab |
True |
True |
| 14 |
ncd-union-separate |
libs/RevoEX/src/ncd/ncdsystem.c:55 |
targeted source cleanup |
restored |
- union { | - BOOL enabled; | - NCDConfig* config; | - } state; | + BOOL enabled; | + NCDConfig* config; | - state.enabled = OSDisableInterrupts(); | + enabled = OSDisableInterrupts(); | - OSRestoreInterrupts(state.enabled); | + OSRestoreInterrupts(enabled); | - state.config = ncdCommonBuffer; | + config = ncdCommonBuffer; | - state.config->selectedMedia = 0; | + config->selectedMedia = 0; | - state.config->selectedMedia = ifConfig->selectedMedia; | - profile = state.config->profiles; | + config->selectedMedia = ifConfig->selectedMedia; | + profile = config->profiles; | - state.config->linkTimeout = ifConfig->linkTimeout; | + config->linkTimeout = ifConfig->linkTimeout; | - if (state.config->profiles[i].flags & 0x80) { | + if (config->profiles[i].flags & 0x80) { | - state.config->profiles[i].flags &= ~1; | + config->profiles[i].flags &= ~1; | - state.config->profiles[i].flags |= 1; | + config->profiles[i].flags |= 1; | - state.config->profiles[0].flags |= 0x80; | + config->profiles[0].flags |= 0x80; | - state.config->profiles[0].flags &= ~1; | - memcpy(&state.config->profiles[0].netif.wireless, &ifConfig->netif, 0x15c); | + config->profiles[0].flags &= ~1; | + memcpy(&config->profiles[0].netif.wireless, &ifConfig->netif, 0x15c); | - state.config->profiles[0].flags |= 1; | - memcpy(&state.config->profiles[0].netif.wired, &ifConfig->netif, 4); | + config->profiles[0].flags |= 1; [see trial candidate in /tmp/rx56/trials] |
4180 -> 3560 |
496 -> 496 |
NCDSetIfConfig 100% -> 99.935486% |
.strtab, .text |
True |
True |
| 15 |
ncd-union-reverse |
libs/RevoEX/src/ncd/ncdsystem.c:55 |
targeted source cleanup |
restored |
- union { | - BOOL enabled; | - NCDConfig* config; | - } state; | + NCDConfig* config; | + BOOL enabled; | - state.enabled = OSDisableInterrupts(); | + enabled = OSDisableInterrupts(); | - OSRestoreInterrupts(state.enabled); | + OSRestoreInterrupts(enabled); | - state.config = ncdCommonBuffer; | + config = ncdCommonBuffer; | - state.config->selectedMedia = 0; | + config->selectedMedia = 0; | - state.config->selectedMedia = ifConfig->selectedMedia; | - profile = state.config->profiles; | + config->selectedMedia = ifConfig->selectedMedia; | + profile = config->profiles; | - state.config->linkTimeout = ifConfig->linkTimeout; | + config->linkTimeout = ifConfig->linkTimeout; | - if (state.config->profiles[i].flags & 0x80) { | + if (config->profiles[i].flags & 0x80) { | - state.config->profiles[i].flags &= ~1; | + config->profiles[i].flags &= ~1; | - state.config->profiles[i].flags |= 1; | + config->profiles[i].flags |= 1; | - state.config->profiles[0].flags |= 0x80; | + config->profiles[0].flags |= 0x80; | - state.config->profiles[0].flags &= ~1; | - memcpy(&state.config->profiles[0].netif.wireless, &ifConfig->netif, 0x15c); | + config->profiles[0].flags &= ~1; | + memcpy(&config->profiles[0].netif.wireless, &ifConfig->netif, 0x15c); | - state.config->profiles[0].flags |= 1; | - memcpy(&state.config->profiles[0].netif.wired, &ifConfig->netif, 4); | + config->profiles[0].flags |= 1; [see trial candidate in /tmp/rx56/trials] |
4180 -> 3560 |
496 -> 496 |
NCDSetIfConfig 100% -> 99.935486% |
.strtab, .text |
True |
True |
| 16 |
browser-unused |
src/iplwww/www_window.cpp:52 |
targeted source cleanup |
restored |
- struct { | - int v0, v1; | - } unused = {0, 0}; |
3392 -> 3128 |
1264 -> 1264 |
__ct__Q37ext_ead3www13BrowserWindowFPQ37ext_ead3www13BrowserThread 100% -> 96.969696% |
.rela.text, .strtab, .symtab, .text |
True |
True |
| 17 |
nhttp-token-carrier |
libs/RevoEX/src/nhttp/NHTTP_thread.c:989 |
targeted source cleanup |
restored |
- struct TokenMatch { | - BOOL matched; | - }; | - struct TokenMatch match = {FALSE}; | + BOOL matched = FALSE; | - match.matched = TRUE; | - context->keepAlive = match.matched; | + matched = TRUE; | + context->keepAlive = matched; | - else context->keepAlive = match.matched; | + else context->keepAlive = matched; |
11292 -> 10528 |
504 -> 504 |
NHTTPi_ThreadParseHeaderProc 100% -> 98.58639% |
.rela.text, .strtab, .text |
True |
True |
| 18 |
casts-0 |
libs/MSL/src/MSL_Common/mbstring.c:45 |
cast candidate |
compile rejected |
- src_ptr = (char*)src; | + src_ptr = src; | - source = (wchar_t*)pwcs; | + source = pwcs; |
|
|
|
|
not measured |
not measured |
| 19 |
casts-0-single-0 |
libs/MSL/src/MSL_Common/mbstring.c:45 |
cast candidate |
compile rejected |
- src_ptr = (char*)src; | + src_ptr = src; |
|
|
|
|
not measured |
not measured |
| 20 |
casts-0-single-1 |
libs/MSL/src/MSL_Common/mbstring.c:79 |
cast candidate |
compile rejected |
- source = (wchar_t*)pwcs; | + source = pwcs; |
|
|
|
|
not measured |
not measured |
| 21 |
casts-1 |
libs/MSL/src/MSL_Common/scanf.c:745 |
cast candidate |
compile rejected |
- *(char*)arg_ptr = chars_read; | + *arg_ptr = chars_read; | - isc.NextChar = (char*)s; | + isc.NextChar = s; |
|
|
|
|
not measured |
not measured |
| 22 |
casts-1-single-0 |
libs/MSL/src/MSL_Common/scanf.c:745 |
cast candidate |
kept |
- *(char*)arg_ptr = chars_read; | + *arg_ptr = chars_read; |
5484 -> 5484 |
388 -> 388 |
|
|
True |
True |
| 23 |
casts-1-single-1 |
libs/MSL/src/MSL_Common/scanf.c:802 |
cast candidate |
compile rejected |
- isc.NextChar = (char*)s; | + isc.NextChar = s; |
|
|
|
|
not measured |
not measured |
| 24 |
casts-2 |
libs/MSL/src/MSL_Common/string.c:370 |
cast candidate |
compile rejected |
- return ((char*)str); | + return (str); |
|
|
|
|
not measured |
not measured |
| 25 |
casts-3 |
libs/MSL/src/MSL_Common/strtold.c:643 |
cast candidate |
compile rejected |
- isc.NextChar = (char*)str; | + isc.NextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 26 |
casts-3-single-0 |
libs/MSL/src/MSL_Common/strtold.c:643 |
cast candidate |
compile rejected |
- isc.NextChar = (char*)str; | + isc.NextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 27 |
casts-3-single-1 |
libs/MSL/src/MSL_Common/strtold.c:643 |
cast candidate |
compile rejected |
- isc.NextChar = (char*)str; | + isc.NextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 28 |
casts-4 |
libs/MSL/src/MSL_Common/strtoul.c:308 |
cast candidate |
compile rejected |
- isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 29 |
casts-4-single-0 |
libs/MSL/src/MSL_Common/strtoul.c:308 |
cast candidate |
compile rejected |
- isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 30 |
casts-4-single-1 |
libs/MSL/src/MSL_Common/strtoul.c:308 |
cast candidate |
compile rejected |
- isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 31 |
casts-4-single-2 |
libs/MSL/src/MSL_Common/strtoul.c:308 |
cast candidate |
compile rejected |
- isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 32 |
casts-4-single-3 |
libs/MSL/src/MSL_Common/strtoul.c:308 |
cast candidate |
compile rejected |
- isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 33 |
casts-4-single-4 |
libs/MSL/src/MSL_Common/strtoul.c:308 |
cast candidate |
compile rejected |
- isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 34 |
casts-4-single-5 |
libs/MSL/src/MSL_Common/strtoul.c:308 |
cast candidate |
compile rejected |
- isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; | - isc.spNextChar = (char*)str; | + isc.spNextChar = str; | - *end = (char*)str + count; | + *end = str + count; |
|
|
|
|
not measured |
not measured |
| 35 |
casts-5 |
libs/MSL/src/MSL_Common/wmem.c:20 |
cast candidate |
kept |
- return (wchar_t*)ptr; | + return ptr; |
144 -> 144 |
0 -> 0 |
|
|
True |
True |
| 36 |
casts-6 |
libs/MSL/src/MSL_Common/wprintf.c:987 |
cast candidate |
compile rejected |
- if (!(curr_format = wcschr((wchar_t*)format_ptr, L'%'))) { | + if (!(curr_format = wcschr(format_ptr, L'%'))) { |
|
|
|
|
not measured |
not measured |
| 37 |
casts-7 |
libs/MSL/src/MSL_Common/wstring.c:135 |
cast candidate |
compile rejected |
- return (wchar_t*)s1; | + return s1; | - return (wchar_t*)p1; | + return p1; |
|
|
|
|
not measured |
not measured |
| 38 |
casts-7-single-0 |
libs/MSL/src/MSL_Common/wstring.c:135 |
cast candidate |
compile rejected |
- return (wchar_t*)s1; | + return s1; |
|
|
|
|
not measured |
not measured |
| 39 |
casts-7-single-1 |
libs/MSL/src/MSL_Common/wstring.c:154 |
cast candidate |
compile rejected |
- return (wchar_t*)p1; | + return p1; |
|
|
|
|
not measured |
not measured |
| 40 |
casts-8 |
libs/NW4R/src/snd/snd_AxVoice.cpp:509 |
cast candidate |
compile rejected |
- mVoiceChannelParam[channelIndex].waveData = (void*)baseAddress; | + mVoiceChannelParam[channelIndex].waveData = baseAddress; |
|
|
|
|
not measured |
not measured |
| 41 |
casts-9 |
libs/NW4R/src/snd/snd_WsdTrack.cpp:31 |
cast candidate |
kept |
- mWsdData = (void*)wsdData; | + mWsdData = wsdData; |
2408 -> 2408 |
40 -> 40 |
|
|
True |
True |
| 42 |
casts-10 |
libs/NW4R/src/ut/ut_ArchiveFont.cpp:80 |
cast candidate |
kept |
- dataSheets = (const u32*)((u32)dataSheetsOff + (u32)fontData); | - data0A = (const u32*)((u32)data0AOff + (u32)fontData); | - data0C = (const u32*)((u32)data0COff + (u32)fontData); | + dataSheets = (const u32*)(dataSheetsOff + (u32)fontData); | + data0A = (const u32*)(data0AOff + (u32)fontData); | + data0C = (const u32*)(data0COff + (u32)fontData); | - flagsSheets = (const u32*)((u32)flagsSheetsOff + (u32)fontData); | - flags0A = (const u32*)((u32)flags0AOff + (u32)fontData); | - flags0C = (const u32*)((u32)flags0COff + (u32)fontData); | + flagsSheets = (const u32*)(flagsSheetsOff + (u32)fontData); | + flags0A = (const u32*)(flags0AOff + (u32)fontData); | + flags0C = (const u32*)(flags0COff + (u32)fontData); | - flagWord |= *(const u32*)((const u8*)offsetFlags + ROUNDDOWN(j * stepSheets, 4)); | + flagWord |= *(const u32*)(offsetFlags + ROUNDDOWN(j * stepSheets, 4)); | - flagWord |= *(const u32*)((const u8*)offsetFlags + ROUNDDOWN(j * step0A, 4)); | + flagWord |= *(const u32*)(offsetFlags + ROUNDDOWN(j * step0A, 4)); | - offsetData = (const u32*)data0A + i * 32; | + offsetData = data0A + i * 32; | - flagWord |= *(const u32*)((const u8*)offsetFlags + ROUNDDOWN(j * step0C, 4)); | + flagWord |= *(const u32*)(offsetFlags + ROUNDDOWN(j * step0C, 4)); | - offsetData = (const u32*)data0C + i * 32; | + offsetData = data0C + i * 32; |
2312 -> 2312 |
144 -> 144 |
|
|
True |
True |
| 43 |
casts-11 |
libs/RVLFaceLib/src/RFL_Database.c:358 |
cast candidate |
compile rejected |
- ((RFLiCharInfo*)src)->personal.localonly = TRUE; | + (src)->personal.localonly = TRUE; |
|
|
|
|
not measured |
not measured |
| 44 |
casts-12 |
libs/RVL_SDK/src/bte/bta_sys_main.c:93 |
cast candidate |
compile rejected |
- bta_sys_cb.reg[id] = (tBTA_SYS_REG *)p_reg; | + bta_sys_cb.reg[id] = p_reg; |
|
|
|
|
not measured |
not measured |
| 45 |
casts-13 |
libs/RVL_SDK/src/card/CARDWrite.c:97 |
cast candidate |
kept |
- DCStoreRange((void*)buf, (u32)length); | + DCStoreRange(buf, (u32)length); | - card->buffer = (void*)buf; | + card->buffer = buf; |
828 -> 828 |
0 -> 0 |
|
|
True |
True |
| 46 |
casts-14 |
libs/RVL_SDK/src/dvd/dvd_broadway.c:382 |
cast candidate |
kept |
- ioVec[2].base = (u8*)certificates; | + ioVec[2].base = certificates; | - ioVec[3].base = (u8*)certificates; | + ioVec[3].base = certificates; |
8900 -> 8900 |
4248 -> 4248 |
|
|
True |
True |
| 47 |
casts-15 |
libs/RVL_SDK/src/dvd/dvdfs.c:329 |
cast candidate |
restored |
- state = ((DVDCommandBlock*)block)->state; | + state = (block)->state; |
3488 -> 3488 |
472 -> 472 |
|
.strtab |
True |
True |
| 48 |
casts-16 |
libs/RVL_SDK/src/es/es.c:1273 |
cast candidate |
kept |
- vec[1].base = (u8*)iv; | + vec[1].base = iv; | - vec[2].base = (u8*)input; | + vec[2].base = input; | - vec[3].base = (u8*)iv; | + vec[3].base = iv; | - vec[4].base = (u8*)output; | + vec[4].base = output; | - vec[1].base = (u8*)iv; | + vec[1].base = iv; | - vec[2].base = (u8*)input; | + vec[2].base = input; | - vec[3].base = (u8*)iv; | + vec[3].base = iv; | - vec[4].base = (u8*)output; | + vec[4].base = output; |
7572 -> 7572 |
16 -> 16 |
|
|
True |
True |
| 49 |
casts-17 |
libs/RVL_SDK/src/euart/euart.c:104 |
cast candidate |
compile rejected |
- for (it = (char*)p; it - msg < n; it++) { | + for (it = p; it - msg < n; it++) { |
|
|
|
|
not measured |
not measured |
| 50 |
casts-18 |
libs/RVL_SDK/src/os/OSExec.c:473 |
cast candidate |
compile rejected |
- LaunchCommon(titleId, launchCode, (const char**)argv, FALSE); | + LaunchCommon(titleId, launchCode, argv, FALSE); | - LaunchCommon(EXEC_SYSTEM_MENU_ID, launchArg, (const char**)argv, FALSE); | + LaunchCommon(EXEC_SYSTEM_MENU_ID, launchArg, argv, FALSE); |
|
|
|
|
not measured |
not measured |
| 51 |
casts-18-single-0 |
libs/RVL_SDK/src/os/OSExec.c:473 |
cast candidate |
compile rejected |
- LaunchCommon(titleId, launchCode, (const char**)argv, FALSE); | + LaunchCommon(titleId, launchCode, argv, FALSE); | - LaunchCommon(EXEC_SYSTEM_MENU_ID, launchArg, (const char**)argv, FALSE); | + LaunchCommon(EXEC_SYSTEM_MENU_ID, launchArg, argv, FALSE); |
|
|
|
|
not measured |
not measured |
| 52 |
casts-18-single-1 |
libs/RVL_SDK/src/os/OSExec.c:473 |
cast candidate |
compile rejected |
- LaunchCommon(titleId, launchCode, (const char**)argv, FALSE); | + LaunchCommon(titleId, launchCode, argv, FALSE); | - LaunchCommon(EXEC_SYSTEM_MENU_ID, launchArg, (const char**)argv, FALSE); | + LaunchCommon(EXEC_SYSTEM_MENU_ID, launchArg, argv, FALSE); |
|
|
|
|
not measured |
not measured |
| 53 |
casts-19 |
libs/RVL_SDK/src/os/OSFont.c:385 |
cast candidate |
compile rejected |
- return (char*)string; | + return string; | - return (char*)string; | + return string; | - string = ParseString(encode, (char*)string, &font, &fontCode); | + string = ParseString(encode, string, &font, &fontCode); | - return (char*)string; | + return string; |
|
|
|
|
not measured |
not measured |
| 54 |
casts-19-single-0 |
libs/RVL_SDK/src/os/OSFont.c:385 |
cast candidate |
compile rejected |
- return (char*)string; | + return string; | - return (char*)string; | + return string; | - string = ParseString(encode, (char*)string, &font, &fontCode); | + string = ParseString(encode, string, &font, &fontCode); | - return (char*)string; | + return string; |
|
|
|
|
not measured |
not measured |
| 55 |
casts-19-single-1 |
libs/RVL_SDK/src/os/OSFont.c:385 |
cast candidate |
compile rejected |
- return (char*)string; | + return string; | - return (char*)string; | + return string; | - string = ParseString(encode, (char*)string, &font, &fontCode); | + string = ParseString(encode, string, &font, &fontCode); | - return (char*)string; | + return string; |
|
|
|
|
not measured |
not measured |
| 56 |
casts-19-single-2 |
libs/RVL_SDK/src/os/OSFont.c:385 |
cast candidate |
compile rejected |
- return (char*)string; | + return string; | - return (char*)string; | + return string; | - string = ParseString(encode, (char*)string, &font, &fontCode); | + string = ParseString(encode, string, &font, &fontCode); | - return (char*)string; | + return string; |
|
|
|
|
not measured |
not measured |
| 57 |
casts-19-single-3 |
libs/RVL_SDK/src/os/OSFont.c:385 |
cast candidate |
compile rejected |
- return (char*)string; | + return string; | - return (char*)string; | + return string; | - string = ParseString(encode, (char*)string, &font, &fontCode); | + string = ParseString(encode, string, &font, &fontCode); | - return (char*)string; | + return string; |
|
|
|
|
not measured |
not measured |
| 58 |
casts-20 |
libs/RVL_SDK/src/os/OSUtf.c:63 |
cast candidate |
compile rejected |
- return (char*)utf8; | + return utf8; | - return (u16*)utf16; | + return utf16; |
|
|
|
|
not measured |
not measured |
| 59 |
casts-20-single-0 |
libs/RVL_SDK/src/os/OSUtf.c:63 |
cast candidate |
compile rejected |
- return (char*)utf8; | + return utf8; |
|
|
|
|
not measured |
not measured |
| 60 |
casts-20-single-1 |
libs/RVL_SDK/src/os/OSUtf.c:92 |
cast candidate |
compile rejected |
- return (u16*)utf16; | + return utf16; |
|
|
|
|
not measured |
not measured |
| 61 |
casts-21 |
libs/RVL_SDK/src/rso/RSOLink.c:464 |
cast candidate |
compile rejected |
- RSORelocateSmallDataSection(rsoImp, i, (RSOObjectHeader*)rsoExp); | + RSORelocateSmallDataSection(rsoImp, i, rsoExp); | - if (((u32)x != 0) && (x != y)) { | + if ((x != 0) && (x != y)) { |
|
|
|
|
not measured |
not measured |
| 62 |
casts-21-single-0 |
libs/RVL_SDK/src/rso/RSOLink.c:464 |
cast candidate |
compile rejected |
- RSORelocateSmallDataSection(rsoImp, i, (RSOObjectHeader*)rsoExp); | + RSORelocateSmallDataSection(rsoImp, i, rsoExp); |
|
|
|
|
not measured |
not measured |
| 63 |
casts-21-single-1 |
libs/RVL_SDK/src/rso/RSOLink.c:744 |
cast candidate |
kept |
- if (((u32)x != 0) && (x != y)) { | + if ((x != 0) && (x != y)) { |
5604 -> 5604 |
288 -> 288 |
|
|
True |
True |
| 64 |
casts-22 |
libs/RVL_SDK/src/usb/usb.c:347 |
cast candidate |
compile rejected |
- DCFlushRange((void*)buffer, length); | - return __IntrBlkMsgInt(fd, endpoint, length, (void*)buffer, USB_IOCTLV_BLKMSG, callback, callbackArg, TRUE); | + DCFlushRange(buffer, length); | + return __IntrBlkMsgInt(fd, endpoint, length, buffer, USB_IOCTLV_BLKMSG, callback, callbackArg, TRUE); |
|
|
|
|
not measured |
not measured |
| 65 |
casts-22-single-0 |
libs/RVL_SDK/src/usb/usb.c:347 |
cast candidate |
compile rejected |
- DCFlushRange((void*)buffer, length); | - return __IntrBlkMsgInt(fd, endpoint, length, (void*)buffer, USB_IOCTLV_BLKMSG, callback, callbackArg, TRUE); | + DCFlushRange(buffer, length); | + return __IntrBlkMsgInt(fd, endpoint, length, buffer, USB_IOCTLV_BLKMSG, callback, callbackArg, TRUE); |
|
|
|
|
not measured |
not measured |
| 66 |
casts-22-single-1 |
libs/RVL_SDK/src/usb/usb.c:347 |
cast candidate |
compile rejected |
- DCFlushRange((void*)buffer, length); | - return __IntrBlkMsgInt(fd, endpoint, length, (void*)buffer, USB_IOCTLV_BLKMSG, callback, callbackArg, TRUE); | + DCFlushRange(buffer, length); | + return __IntrBlkMsgInt(fd, endpoint, length, buffer, USB_IOCTLV_BLKMSG, callback, callbackArg, TRUE); |
|
|
|
|
not measured |
not measured |
| 67 |
casts-23 |
libs/RVL_SDK/src/vi/vi.c:1042 |
cast candidate |
kept |
- register54 = (u32)originalRegister54 & ~1; | + register54 = originalRegister54 & ~1; | - register54 = ((u32)originalRegister54 & ~1) | 1; | + register54 = (originalRegister54 & ~1) | 1; | - register54 = (u32)originalRegister54 & ~1; | + register54 = originalRegister54 & ~1; |
11296 -> 11296 |
1944 -> 1944 |
|
|
True |
True |
| 68 |
casts-24 |
libs/RVL_SDK/src/wad/wad.c:2958 |
cast candidate |
kept |
- u8* tail = (u8*)words; | + u8* tail = words; |
24500 -> 24500 |
528 -> 528 |
|
|
True |
True |
| 69 |
casts-25 |
libs/RVL_SDK/src/wenc/wenc.c:46 |
cast candidate |
compile rejected |
- pSrc = (s16*)pbyPcmData; | + pSrc = pbyPcmData; |
|
|
|
|
not measured |
not measured |
| 70 |
casts-26 |
libs/RVL_SDK/src/wpad/WPADEncrypt.c:399 |
cast candidate |
kept |
- buffer = (u8*)data; | + buffer = data; |
4264 -> 4264 |
4912 -> 4912 |
|
|
True |
True |
| 71 |
casts-27 |
libs/RevoEX/src/cdb/CDBDatabase.c:329 |
cast candidate |
compile rejected |
- return CDBRecordCreateAtOnce(record, database, typeStr, (char*)fileTypeStr, date, gameCode, makerCode, recordData, recordDataSize); | + return CDBRecordCreateAtOnce(record, database, typeStr, fileTypeStr, date, gameCode, makerCode, recordData, recordDataSize); |
|
|
|
|
not measured |
not measured |
| 72 |
casts-28 |
libs/RevoEX/src/ncd/ncdsystem.c:51 |
cast candidate |
compile rejected |
- return ExecConfigCommand("NCDWriteConfig", (NCDConfig*)config, 6); | + return ExecConfigCommand("NCDWriteConfig", config, 6); |
|
|
|
|
not measured |
not measured |
| 73 |
casts-29 |
libs/RevoEX/src/nwc24/NWC24FileAPI.c:301 |
cast candidate |
compile rejected |
- result = VFWriteFile(file->vf, (void*)src, size); | + result = VFWriteFile(file->vf, src, size); |
|
|
|
|
not measured |
not measured |
| 74 |
casts-30 |
libs/RevoEX/src/nwc24/NWC24Mime.c:645 |
cast candidate |
kept |
- while ((s32)inputSize > 0 && remainingCapacity > 0 && *input != '\0') { | + while (inputSize > 0 && remainingCapacity > 0 && *input != '\0') { | - DecodeWord((char*)charsetData, charsetDataSize, (char*)output, remainingCapacity, &copiedSize, (char*)input, inputSize, &consumedSize); | + DecodeWord((char*)charsetData, charsetDataSize, (char*)output, remainingCapacity, &copiedSize, input, inputSize, &consumedSize); |
6124 -> 6124 |
88 -> 88 |
|
|
True |
True |
| 75 |
casts-31 |
libs/RevoEX/src/nwc24/NWC24MsgCommit.c:723 |
cast candidate |
compile rejected |
- NWC24Base64Encode((u8*)data, chunk, (u8*)(buffer + offset), 76, &length); | + NWC24Base64Encode(data, chunk, (u8*)(buffer + offset), 76, &length); | - NWC24Base64Encode((u8*)data, chunk, (u8*)(buffer + offset), 76, &length); | + NWC24Base64Encode(data, chunk, (u8*)(buffer + offset), 76, &length); | - err = NWC24Base64Encode((u8*)cursor, 57, (u8*)buffer, 76, &length); | + err = NWC24Base64Encode(cursor, 57, (u8*)buffer, 76, &length); | - err = NWC24Base64Encode((u8*)cursor, size, (u8*)buffer, 76, &length); | + err = NWC24Base64Encode(cursor, size, (u8*)buffer, 76, &length); | - err = NWC24EncodeQuotedPrintable(buffer, 1024, &length, (u8*)cursor, remaining, &consumed); | + err = NWC24EncodeQuotedPrintable(buffer, 1024, &length, cursor, remaining, &consumed); |
|
|
|
|
not measured |
not measured |
| 76 |
casts-31-single-0 |
libs/RevoEX/src/nwc24/NWC24MsgCommit.c:723 |
cast candidate |
compile rejected |
- NWC24Base64Encode((u8*)data, chunk, (u8*)(buffer + offset), 76, &length); | + NWC24Base64Encode(data, chunk, (u8*)(buffer + offset), 76, &length); | - NWC24Base64Encode((u8*)data, chunk, (u8*)(buffer + offset), 76, &length); | + NWC24Base64Encode(data, chunk, (u8*)(buffer + offset), 76, &length); |
|
|
|
|
not measured |
not measured |
| 77 |
casts-31-single-1 |
libs/RevoEX/src/nwc24/NWC24MsgCommit.c:723 |
cast candidate |
compile rejected |
- NWC24Base64Encode((u8*)data, chunk, (u8*)(buffer + offset), 76, &length); | + NWC24Base64Encode(data, chunk, (u8*)(buffer + offset), 76, &length); | - NWC24Base64Encode((u8*)data, chunk, (u8*)(buffer + offset), 76, &length); | + NWC24Base64Encode(data, chunk, (u8*)(buffer + offset), 76, &length); |
|
|
|
|
not measured |
not measured |
| 78 |
casts-31-single-2 |
libs/RevoEX/src/nwc24/NWC24MsgCommit.c:871 |
cast candidate |
compile rejected |
- err = NWC24Base64Encode((u8*)cursor, 57, (u8*)buffer, 76, &length); | + err = NWC24Base64Encode(cursor, 57, (u8*)buffer, 76, &length); | - err = NWC24Base64Encode((u8*)cursor, size, (u8*)buffer, 76, &length); | + err = NWC24Base64Encode(cursor, size, (u8*)buffer, 76, &length); | - err = NWC24EncodeQuotedPrintable(buffer, 1024, &length, (u8*)cursor, remaining, &consumed); | + err = NWC24EncodeQuotedPrintable(buffer, 1024, &length, cursor, remaining, &consumed); |
|
|
|
|
not measured |
not measured |
| 79 |
casts-31-single-3 |
libs/RevoEX/src/nwc24/NWC24MsgCommit.c:871 |
cast candidate |
compile rejected |
- err = NWC24Base64Encode((u8*)cursor, 57, (u8*)buffer, 76, &length); | + err = NWC24Base64Encode(cursor, 57, (u8*)buffer, 76, &length); | - err = NWC24Base64Encode((u8*)cursor, size, (u8*)buffer, 76, &length); | + err = NWC24Base64Encode(cursor, size, (u8*)buffer, 76, &length); | - err = NWC24EncodeQuotedPrintable(buffer, 1024, &length, (u8*)cursor, remaining, &consumed); | + err = NWC24EncodeQuotedPrintable(buffer, 1024, &length, cursor, remaining, &consumed); |
|
|
|
|
not measured |
not measured |
| 80 |
casts-31-single-4 |
libs/RevoEX/src/nwc24/NWC24MsgCommit.c:871 |
cast candidate |
compile rejected |
- err = NWC24Base64Encode((u8*)cursor, 57, (u8*)buffer, 76, &length); | + err = NWC24Base64Encode(cursor, 57, (u8*)buffer, 76, &length); | - err = NWC24Base64Encode((u8*)cursor, size, (u8*)buffer, 76, &length); | + err = NWC24Base64Encode(cursor, size, (u8*)buffer, 76, &length); | - err = NWC24EncodeQuotedPrintable(buffer, 1024, &length, (u8*)cursor, remaining, &consumed); | + err = NWC24EncodeQuotedPrintable(buffer, 1024, &length, cursor, remaining, &consumed); |
|
|
|
|
not measured |
not measured |
| 81 |
casts-32 |
libs/RevoEX/src/nwc24/NWC24MsgSubject.c:860 |
cast candidate |
compile rejected |
- result = NWC24EncodeWord(second, secondSize, &outputLength, charsetName, 0x40, 'B', (u8*)encodedInput, workHalf - 1); | + result = NWC24EncodeWord(second, secondSize, &outputLength, charsetName, 0x40, 'B', encodedInput, workHalf - 1); | - result = NWC24EncodeWord(second + total, secondSize - total, &outputLength, charsetName, 0x40, 'B', (u8*)encodedInput, workHalf - 1); | + result = NWC24EncodeWord(second + total, secondSize - total, &outputLength, charsetName, 0x40, 'B', encodedInput, workHalf - 1); |
|
|
|
|
not measured |
not measured |
| 82 |
casts-32-single-0 |
libs/RevoEX/src/nwc24/NWC24MsgSubject.c:860 |
cast candidate |
compile rejected |
- result = NWC24EncodeWord(second, secondSize, &outputLength, charsetName, 0x40, 'B', (u8*)encodedInput, workHalf - 1); | + result = NWC24EncodeWord(second, secondSize, &outputLength, charsetName, 0x40, 'B', encodedInput, workHalf - 1); | - result = NWC24EncodeWord(second + total, secondSize - total, &outputLength, charsetName, 0x40, 'B', (u8*)encodedInput, workHalf - 1); | + result = NWC24EncodeWord(second + total, secondSize - total, &outputLength, charsetName, 0x40, 'B', encodedInput, workHalf - 1); |
|
|
|
|
not measured |
not measured |
| 83 |
casts-32-single-1 |
libs/RevoEX/src/nwc24/NWC24MsgSubject.c:860 |
cast candidate |
compile rejected |
- result = NWC24EncodeWord(second, secondSize, &outputLength, charsetName, 0x40, 'B', (u8*)encodedInput, workHalf - 1); | + result = NWC24EncodeWord(second, secondSize, &outputLength, charsetName, 0x40, 'B', encodedInput, workHalf - 1); | - result = NWC24EncodeWord(second + total, secondSize - total, &outputLength, charsetName, 0x40, 'B', (u8*)encodedInput, workHalf - 1); | + result = NWC24EncodeWord(second + total, secondSize - total, &outputLength, charsetName, 0x40, 'B', encodedInput, workHalf - 1); |
|
|
|
|
not measured |
not measured |
| 84 |
casts-33 |
libs/RevoEX/src/nwc24/NWC24Parser.c:212 |
cast candidate |
compile rejected |
- char* pStr2 = (char*)string2; | - char* pStr1 = (char*)string1; | + char* pStr2 = string2; | + char* pStr1 = string1; |
|
|
|
|
not measured |
not measured |
| 85 |
casts-33-single-0 |
libs/RevoEX/src/nwc24/NWC24Parser.c:212 |
cast candidate |
compile rejected |
- char* pStr2 = (char*)string2; | + char* pStr2 = string2; |
|
|
|
|
not measured |
not measured |
| 86 |
casts-33-single-1 |
libs/RevoEX/src/nwc24/NWC24Parser.c:213 |
cast candidate |
compile rejected |
- char* pStr1 = (char*)string1; | + char* pStr1 = string1; |
|
|
|
|
not measured |
not measured |
| 87 |
casts-34 |
libs/RevoEX/src/vf/common/pf_service.c:14 |
cast candidate |
kept |
- *((pf_u8*)sSrc + cnt) = *((pf_u8*)sSrc + cnt + 1); | - *((pf_u8*)sSrc + cnt + 1) = tmp_src; | + *(sSrc + cnt) = *(sSrc + cnt + 1); | + *(sSrc + cnt + 1) = tmp_src; |
280 -> 280 |
0 -> 0 |
|
|
True |
True |
| 88 |
casts-35 |
libs/RevoEX/src/vf/common/pf_str.c:123 |
cast candidate |
kept |
- VFipf_vol_set.codeset.oem2unicode((pf_s8*)s, &wc); | + VFipf_vol_set.codeset.oem2unicode(s, &wc); | - VFipf_vol_set.codeset.oem2unicode((pf_s8*)s, &wc); | + VFipf_vol_set.codeset.oem2unicode(s, &wc); |
1332 -> 1332 |
0 -> 0 |
|
|
True |
True |
| 89 |
casts-36 |
libs/RevoEX/src/vf/common/pf_w_clib.c:23 |
cast candidate |
kept |
- const pf_u16* p1 = (pf_u16*)s1; | - const pf_u16* p2 = (pf_u16*)s2; | + const pf_u16* p1 = s1; | + const pf_u16* p2 = s2; |
148 -> 148 |
0 -> 0 |
|
|
True |
True |
| 90 |
casts-37 |
libs/RevoEX/src/vf/develop/d_hash.c:188 |
cast candidate |
compile rejected |
- VFipf_memcpy(&hashTable[newHash], (u16*)i_Name, 0x10U); | + VFipf_memcpy(&hashTable[newHash], i_Name, 0x10U); |
|
|
|
|
not measured |
not measured |
| 91 |
casts-38 |
libs/RevoEX/src/vf/develop/d_vf.c:865 |
cast candidate |
compile rejected |
- return (char*)ret_p; | + return ret_p; |
|
|
|
|
not measured |
not measured |
| 92 |
casts-39 |
libs/RevoEX/src/vf/develop/nand_drv.c:666 |
cast candidate |
compile rejected |
- nandError = A32_NANDWrite(fileInfo_p, (u8*)buf, size, p_disk); | + nandError = A32_NANDWrite(fileInfo_p, buf, size, p_disk); |
|
|
|
|
not measured |
not measured |
| 93 |
casts-40 |
libs/RevoEX/src/vf/dskmng/pdm_disk.c:355 |
cast candidate |
kept |
- err = lp_disk->disk_tbl.p_func->format(p_disk, (pf_u8*)param); | + err = lp_disk->disk_tbl.p_func->format(p_disk, param); |
5584 -> 5584 |
0 -> 0 |
|
|
True |
True |
| 94 |
casts-41 |
libs/RevoEX/src/vf/fatfs/pf_cache.c:447 |
cast candidate |
compile rejected |
- VFipf_memcpy(p_page->p_buf, (pf_u8*)p_buf, p_vol->bpb.bytes_per_sector); | + VFipf_memcpy(p_page->p_buf, p_buf, p_vol->bpb.bytes_per_sector); | - VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], (pf_u8*)p_buf, | + VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], p_buf, | - VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], (pf_u8*)p_buf, | + VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], p_buf, |
|
|
|
|
not measured |
not measured |
| 95 |
casts-41-single-0 |
libs/RevoEX/src/vf/fatfs/pf_cache.c:447 |
cast candidate |
compile rejected |
- VFipf_memcpy(p_page->p_buf, (pf_u8*)p_buf, p_vol->bpb.bytes_per_sector); | + VFipf_memcpy(p_page->p_buf, p_buf, p_vol->bpb.bytes_per_sector); | - VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], (pf_u8*)p_buf, | + VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], p_buf, | - VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], (pf_u8*)p_buf, | + VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], p_buf, |
|
|
|
|
not measured |
not measured |
| 96 |
casts-41-single-1 |
libs/RevoEX/src/vf/fatfs/pf_cache.c:447 |
cast candidate |
compile rejected |
- VFipf_memcpy(p_page->p_buf, (pf_u8*)p_buf, p_vol->bpb.bytes_per_sector); | + VFipf_memcpy(p_page->p_buf, p_buf, p_vol->bpb.bytes_per_sector); | - VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], (pf_u8*)p_buf, | + VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], p_buf, | - VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], (pf_u8*)p_buf, | + VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], p_buf, |
|
|
|
|
not measured |
not measured |
| 97 |
casts-41-single-2 |
libs/RevoEX/src/vf/fatfs/pf_cache.c:447 |
cast candidate |
compile rejected |
- VFipf_memcpy(p_page->p_buf, (pf_u8*)p_buf, p_vol->bpb.bytes_per_sector); | + VFipf_memcpy(p_page->p_buf, p_buf, p_vol->bpb.bytes_per_sector); | - VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], (pf_u8*)p_buf, | + VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], p_buf, | - VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], (pf_u8*)p_buf, | + VFipf_memcpy(&p_page->buffer[(sector - p_page->sector) << p_vol->bpb.log2_bytes_per_sector], p_buf, |
|
|
|
|
not measured |
not measured |
| 98 |
casts-42 |
libs/RevoEX/src/vf/fatfs/pf_entry_iterator.c:82 |
cast candidate |
kept |
- is_valid = VFiPFENT_CompareAttr(attr, (pf_u8)attr_required); | + is_valid = VFiPFENT_CompareAttr(attr, attr_required); |
8560 -> 8560 |
40 -> 40 |
|
|
True |
True |
| 99 |
casts-43 |
libs/RevoEX/src/vf/fatfs/pf_path.c:89 |
cast candidate |
restored |
- VFipf_vol_set.codeset.oem2unicode((pf_s8*)src, dst); | + VFipf_vol_set.codeset.oem2unicode(src, dst); | - tmp_wc = (pf_u16)tmp_wc; | + tmp_wc = tmp_wc; | - if (VFiPFPATH_UNI_ConvertFWchar((pf_u16)wc, &twc) == 1) { | + if (VFiPFPATH_UNI_ConvertFWchar(wc, &twc) == 1) { |
10636 -> 10636 |
64 -> 64 |
|
.line, .symtab, .strtab |
True |
True |
| 100 |
casts-43-single-0 |
libs/RevoEX/src/vf/fatfs/pf_path.c:89 |
cast candidate |
kept |
- VFipf_vol_set.codeset.oem2unicode((pf_s8*)src, dst); | + VFipf_vol_set.codeset.oem2unicode(src, dst); |
10636 -> 10636 |
64 -> 64 |
|
|
True |
True |
| 101 |
casts-43-single-1 |
libs/RevoEX/src/vf/fatfs/pf_path.c:172 |
cast candidate |
restored |
- tmp_wc = (pf_u16)tmp_wc; | + tmp_wc = tmp_wc; |
10636 -> 10636 |
64 -> 64 |
|
.line, .symtab |
True |
True |
| 102 |
casts-43-single-2 |
libs/RevoEX/src/vf/fatfs/pf_path.c:182 |
cast candidate |
restored |
- if (VFiPFPATH_UNI_ConvertFWchar((pf_u16)wc, &twc) == 1) { | + if (VFiPFPATH_UNI_ConvertFWchar(wc, &twc) == 1) { |
10636 -> 10636 |
64 -> 64 |
|
.line, .strtab |
True |
True |
| 103 |
casts-44 |
libs/RevoEX/src/vf/fatfs/pf_sector.c:46 |
cast candidate |
compile rejected |
- VFipf_memcpy(&p_page->p_buf[offset], (pf_u8*)p_buf, size); | + VFipf_memcpy(&p_page->p_buf[offset], p_buf, size); |
|
|
|
|
not measured |
not measured |
| 104 |
casts-45 |
libs/RevoEX/src/vf/fatfs/pf_volume.c:545 |
cast candidate |
compile rejected |
- VFipf_memcpy(p_vol->label, (pf_u8*)buf, 11U); | + VFipf_memcpy(p_vol->label, buf, 11U); |
|
|
|
|
not measured |
not measured |
| 105 |
casts-46 |
libs/RevoEX/src/wd/WDScan.c:285 |
cast candidate |
kept |
- infoElement = (WDInfoElement*)((u8*)ptr + offset); | + infoElement = (WDInfoElement*)(ptr + offset); |
2180 -> 2180 |
16 -> 16 |
|
|
True |
True |
| 106 |
casts-47 |
src/BS2/BS2Fatal.c:85 |
cast candidate |
kept |
- string = OSGetFontTexel((char*)string, image, 0, 6, &width); | + string = OSGetFontTexel(string, image, 0, 6, &width); |
3116 -> 3116 |
2448 -> 2448 |
|
|
True |
True |
| 107 |
casts-48 |
src/bannerSound/AudioWaveUtility.cpp:388 |
cast candidate |
compile rejected |
- BinaryReader reader((u8*)data); | + BinaryReader reader(data); | - fileEnd = (u8*)data + fileSize; | + fileEnd = data + fileSize; | - if ((dataLen - ((u8*)self->mpDataCur - (u8*)data)) / (self->mNumChans * 2) < self->mFrames) { | + if ((dataLen - ((u8*)self->mpDataCur - data)) / (self->mNumChans * 2) < self->mFrames) { |
|
|
|
|
not measured |
not measured |
| 108 |
casts-48-single-0 |
src/bannerSound/AudioWaveUtility.cpp:260 |
cast candidate |
compile rejected |
- BinaryReader reader((u8*)dataOffset); | + BinaryReader reader(dataOffset); | - u8* fileEnd = (u8*)dataOffset + fileSize; | + u8* fileEnd = dataOffset + fileSize; | - BinaryReader reader((u8*)data); | + BinaryReader reader(data); | - fileEnd = (u8*)data + fileSize; | + fileEnd = data + fileSize; | - if ((dataLen - ((u8*)self->mpDataCur - (u8*)data)) / (self->mNumChans * 2) < self->mFrames) { | + if ((dataLen - ((u8*)self->mpDataCur - data)) / (self->mNumChans * 2) < self->mFrames) { | - BinaryReaderLittleEndian reader((u8*)data); | + BinaryReaderLittleEndian reader(data); | - u8* fileEnd = (u8*)data + fileSize; | + u8* fileEnd = data + fileSize; | - BinaryReaderLittleEndian reader((u8*)data); | + BinaryReaderLittleEndian reader(data); | - u8* fileEnd = (u8*)data + fileSize; | + u8* fileEnd = data + fileSize; | - if ((dataLen - ((u8*)mpDataCur - (u8*)data)) / (mNumChans * 2) < mFrames) { | + if ((dataLen - ((u8*)mpDataCur - data)) / (mNumChans * 2) < mFrames) { |
|
|
|
|
not measured |
not measured |
| 109 |
casts-48-single-1 |
src/bannerSound/AudioWaveUtility.cpp:260 |
cast candidate |
compile rejected |
- BinaryReader reader((u8*)dataOffset); | + BinaryReader reader(dataOffset); | - u8* fileEnd = (u8*)dataOffset + fileSize; | + u8* fileEnd = dataOffset + fileSize; | - BinaryReader reader((u8*)data); | + BinaryReader reader(data); | - fileEnd = (u8*)data + fileSize; | + fileEnd = data + fileSize; | - if ((dataLen - ((u8*)self->mpDataCur - (u8*)data)) / (self->mNumChans * 2) < self->mFrames) { | + if ((dataLen - ((u8*)self->mpDataCur - data)) / (self->mNumChans * 2) < self->mFrames) { | - BinaryReaderLittleEndian reader((u8*)data); | + BinaryReaderLittleEndian reader(data); | - u8* fileEnd = (u8*)data + fileSize; | + u8* fileEnd = data + fileSize; | - BinaryReaderLittleEndian reader((u8*)data); | + BinaryReaderLittleEndian reader(data); | - u8* fileEnd = (u8*)data + fileSize; | + u8* fileEnd = data + fileSize; | - if ((dataLen - ((u8*)mpDataCur - (u8*)data)) / (mNumChans * 2) < mFrames) { | + if ((dataLen - ((u8*)mpDataCur - data)) / (mNumChans * 2) < mFrames) { |
|
|
|
|
not measured |
not measured |
| 110 |
casts-48-single-2 |
src/bannerSound/AudioWaveUtility.cpp:260 |
cast candidate |
compile rejected |
- BinaryReader reader((u8*)dataOffset); | + BinaryReader reader(dataOffset); | - u8* fileEnd = (u8*)dataOffset + fileSize; | + u8* fileEnd = dataOffset + fileSize; | - BinaryReader reader((u8*)data); | + BinaryReader reader(data); | - fileEnd = (u8*)data + fileSize; | + fileEnd = data + fileSize; | - if ((dataLen - ((u8*)self->mpDataCur - (u8*)data)) / (self->mNumChans * 2) < self->mFrames) { | + if ((dataLen - ((u8*)self->mpDataCur - data)) / (self->mNumChans * 2) < self->mFrames) { | - BinaryReaderLittleEndian reader((u8*)data); | + BinaryReaderLittleEndian reader(data); | - u8* fileEnd = (u8*)data + fileSize; | + u8* fileEnd = data + fileSize; | - BinaryReaderLittleEndian reader((u8*)data); | + BinaryReaderLittleEndian reader(data); | - u8* fileEnd = (u8*)data + fileSize; | + u8* fileEnd = data + fileSize; | - if ((dataLen - ((u8*)mpDataCur - (u8*)data)) / (mNumChans * 2) < mFrames) { | + if ((dataLen - ((u8*)mpDataCur - data)) / (mNumChans * 2) < mFrames) { |
|
|
|
|
not measured |
not measured |
| 111 |
casts-49 |
src/channelScript/CHANSVm.c:3175 |
cast candidate |
compile rejected |
- return VmStringObjectDup(VmInst, VmReturnObj, (CHANSVmObjHdr *)VmParentObj) ? vmTrue : vmFalse; | + return VmStringObjectDup(VmInst, VmReturnObj, VmParentObj) ? vmTrue : vmFalse; |
|
|
|
|
not measured |
not measured |
| 112 |
casts-50 |
src/iplwww/www_arcreader.cpp:80 |
cast candidate |
compile rejected |
- if (ARCInitHandle((void*)data, mHandles + i)) { | + if (ARCInitHandle(data, mHandles + i)) { |
|
|
|
|
not measured |
not measured |
| 113 |
casts-51 |
src/scene/board/iplFocusObject.cpp:1329 |
cast candidate |
kept |
- mpChJpData = (NWC24CHJumpObj*)((u8*)pArc + ARCGetStartOffset(&arcFile)); | + mpChJpData = (NWC24CHJumpObj*)(pArc + ARCGetStartOffset(&arcFile)); |
20332 -> 20332 |
2576 -> 2576 |
|
|
True |
True |
| 114 |
casts-52 |
src/scene/channelSelect/iplChannelObj.cpp:246 |
cast candidate |
compile rejected |
- mpBasePane = (nw4r::lyt::Pane*)basePane; | + mpBasePane = basePane; |
|
|
|
|
not measured |
not measured |
| 115 |
casts-53 |
src/scene/textBalloon/iplBalloon.cpp:51 |
cast candidate |
compile rejected |
- mpText = (wchar_t*)text; | + mpText = text; |
|
|
|
|
not measured |
not measured |
| 116 |
casts-54 |
src/system/iplCdbWrapper.cpp:38 |
cast candidate |
restored |
- if (((int)nandResult == NAND_RESULT_BUSY || (int)nandResult == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { | + if ((nandResult == NAND_RESULT_BUSY || nandResult == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { |
256 -> 100 |
0 -> 0 |
_condition__Q33ipl3cdb7wrapperF6CDBErri 100% -> 92.69231% |
.text, .symtab, .rela.text |
True |
True |
| 117 |
casts-54-single-0 |
src/system/iplCdbWrapper.cpp:38 |
cast candidate |
restored |
- if (((int)nandResult == NAND_RESULT_BUSY || (int)nandResult == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { | + if ((nandResult == NAND_RESULT_BUSY || nandResult == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { |
256 -> 100 |
0 -> 0 |
_condition__Q33ipl3cdb7wrapperF6CDBErri 100% -> 92.69231% |
.text, .symtab, .rela.text |
True |
True |
| 118 |
casts-54-single-1 |
src/system/iplCdbWrapper.cpp:38 |
cast candidate |
restored |
- if (((int)nandResult == NAND_RESULT_BUSY || (int)nandResult == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { | + if ((nandResult == NAND_RESULT_BUSY || nandResult == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { |
256 -> 100 |
0 -> 0 |
_condition__Q33ipl3cdb7wrapperF6CDBErri 100% -> 92.69231% |
.text, .symtab, .rela.text |
True |
True |
| 119 |
casts-55 |
src/system/iplNandSDWorker.cpp:3936 |
cast candidate |
compile rejected |
- ret = read_file(fd, fileKind, iconBinOffset, thumbnailSize, ((SDAppBackupData*)appBnrOut)->thumbnail); | + ret = read_file(fd, fileKind, iconBinOffset, thumbnailSize, (appBnrOut)->thumbnail); | - Rvl_decode(uncmpr, (u8*)cmpr + offset); | + Rvl_decode(uncmpr, cmpr + offset); |
|
|
|
|
not measured |
not measured |
| 120 |
casts-55-single-0 |
src/system/iplNandSDWorker.cpp:3936 |
cast candidate |
kept |
- ret = read_file(fd, fileKind, iconBinOffset, thumbnailSize, ((SDAppBackupData*)appBnrOut)->thumbnail); | + ret = read_file(fd, fileKind, iconBinOffset, thumbnailSize, (appBnrOut)->thumbnail); |
51428 -> 51428 |
12312 -> 12312 |
|
|
True |
True |
| 121 |
casts-55-single-1 |
src/system/iplNandSDWorker.cpp:4672 |
cast candidate |
compile rejected |
- Rvl_decode(uncmpr, (u8*)cmpr + offset); | + Rvl_decode(uncmpr, cmpr + offset); |
|
|
|
|
not measured |
not measured |
| 122 |
casts-56 |
src/system/iplNandWrapper.cpp:116 |
cast candidate |
restored |
- if (((int)result == NAND_RESULT_BUSY || (int)result == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { | + if ((result == NAND_RESULT_BUSY || result == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { |
2888 -> 2760 |
0 -> 0 |
_condition__Q33ipl4nand7wrapperFii 100% -> 84.21875% |
.text, .symtab, .rela.text |
True |
True |
| 123 |
casts-56-single-0 |
src/system/iplNandWrapper.cpp:116 |
cast candidate |
restored |
- if (((int)result == NAND_RESULT_BUSY || (int)result == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { | + if ((result == NAND_RESULT_BUSY || result == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { |
2888 -> 2760 |
0 -> 0 |
_condition__Q33ipl4nand7wrapperFii 100% -> 84.21875% |
.text, .symtab, .rela.text |
True |
True |
| 124 |
casts-56-single-1 |
src/system/iplNandWrapper.cpp:116 |
cast candidate |
restored |
- if (((int)result == NAND_RESULT_BUSY || (int)result == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { | + if ((result == NAND_RESULT_BUSY || result == NAND_RESULT_ALLOC_FAILED) && tries < MAX_TRIES) { |
2888 -> 2760 |
0 -> 0 |
_condition__Q33ipl4nand7wrapperFii 100% -> 84.21875% |
.text, .symtab, .rela.text |
True |
True |
| 125 |
duplicate-0 |
libs/MSL/src/MSL_Common/strtold.c:556 |
duplicate branch |
restored |
- return result; | - return result; | + return result; |
5284 -> 5284 |
112 -> 112 |
|
.strtab |
True |
True |
| 126 |
duplicate-1 |
libs/MSL/src/MSL_Common/strtold.c:420 |
duplicate branch |
restored |
- c = fetch(); | - c = fetch(); | + c = fetch(); |
5284 -> 176 |
112 -> 88 |
__strtold 100% -> 99.23649% |
.strtab, .rela.text, .text, .symtab, extabindex |
True |
True |
| 127 |
duplicate-2 |
libs/MSL/src/MSL_Common/strtold.c:386 |
duplicate branch |
restored |
- c = fetch(); | - c = fetch(); | + c = fetch(); |
5284 -> 176 |
112 -> 88 |
__strtold 100% -> 99.23649% |
.strtab, .rela.text, .text, .symtab, extabindex |
True |
True |
| 128 |
duplicate-3 |
libs/MSL/src/MSL_Common/time.c:326 |
duplicate branch |
restored |
- localtime_tm.tm_isdst = __isdst(); | - return &localtime_tm; | - localtime_tm.tm_isdst = __isdst(); | - return &localtime_tm; | + localtime_tm.tm_isdst = __isdst(); | + return &localtime_tm; |
6440 -> 6292 |
988 -> 808 |
localtime 100% -> 80.37838% |
.strtab, extab, .rela.text, .text, .symtab, extabindex |
True |
True |
| 129 |
duplicate-4 |
libs/MSL/src/MSL_Common_Embedded/Math/e_fmod.c:131 |
duplicate branch |
restored |
- lx = (hx<<(32-n))|(lx>>n); hx = sx; | + lx = (hx<<(32-n))|(lx>>n); | - lx = hx>>(n-32); hx = sx; | + lx = hx>>(n-32); | + hx = sx; |
816 -> 0 |
16 -> 16 |
__ieee754_fmod 100% -> 95.43137% |
.text, .symtab |
True |
True |
| 130 |
duplicate-5 |
libs/NW4R/src/snd/snd_AxVoice.cpp:748 |
duplicate branch |
restored |
- targetVol = volume * mVeTargetVolume * (AX_MAX_VOLUME - 1); | - targetVol = volume * mVeTargetVolume * (AX_MAX_VOLUME - 1); | + targetVol = volume * mVeTargetVolume * (AX_MAX_VOLUME - 1); |
13568 -> 12996 |
104 -> 104 |
UpdateAxVe__Q44nw4r3snd6detail7AxVoiceFv 100% -> 85.02098% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 131 |
duplicate-6 |
libs/NW4R/src/snd/snd_WsdFile.cpp:52 |
duplicate branch |
restored |
- soundInfo->fxSendA = 0; | - soundInfo->fxSendB = 0; | - soundInfo->fxSendC = 0; | - soundInfo->mainSend = 127; | - soundInfo->fxSendA = 0; | - soundInfo->fxSendB = 0; | - soundInfo->fxSendC = 0; | - soundInfo->mainSend = 127; | + soundInfo->fxSendA = 0; | + soundInfo->fxSendB = 0; | + soundInfo->fxSendC = 0; | + soundInfo->mainSend = 127; |
840 -> 552 |
8 -> 8 |
ReadWaveSoundInfo__Q44nw4r3snd6detail13WsdFileReaderCFPQ44nw4r3snd6detail13WaveSoundInfoi 100% -> 83.06944% |
.rela.text, .text, .symtab |
True |
True |
| 132 |
duplicate-7 |
libs/RVLFaceLib/src/RFL_HiddenDatabase.c:503 |
duplicate branch |
restored |
- curNode->next = -1; | - curNode->next = -1; | + curNode->next = -1; |
3356 -> 3108 |
340 -> 136 |
create_ 100% -> 88.629036% |
.rela.text, .text, .symtab, extabindex |
True |
True |
| 133 |
duplicate-8 |
libs/RVL_SDK/src/ax/AXAlloc.c:112 |
duplicate branch |
restored |
- __AXStackHead[priority] = vpb; | - __AXStackHead[priority] = vpb; | + __AXStackHead[priority] = vpb; |
1208 -> 668 |
264 -> 264 |
AXAcquireVoice 100% -> 96.125%; AXSetVoicePriority 100% -> 90.76923% |
.rela.text, .text, .symtab |
True |
True |
| 134 |
duplicate-9 |
libs/RVL_SDK/src/bte/hcisu_h2.c:300 |
duplicate branch |
restored |
- p_cb->rx_state[pipe] = 0; | - p_cb->rx_state[pipe] = 0; | + p_cb->rx_state[pipe] = 0; |
1692 -> 772 |
208 -> 208 |
hcisu_h2_receive_msg 100% -> 98.82609% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 135 |
duplicate-10 |
libs/RVL_SDK/src/bte/l2c_csm.c:815 |
duplicate branch |
restored |
- p_buf = GKI_dequeue(&p_ccb->xmit_hold_q); | - p_buf = GKI_dequeue(&p_ccb->xmit_hold_q); | + p_buf = GKI_dequeue(&p_ccb->xmit_hold_q); |
5340 -> 4920 |
2104 -> 2104 |
forward_peer_data 100% -> 97.09524% |
.rela.text, .text, .symtab |
True |
True |
| 136 |
duplicate-11 |
libs/RVL_SDK/src/bte/l2c_link.c:356 |
duplicate branch |
restored |
- L2C_LINK_SEND_ACL_DATA(p_buf); | - L2C_LINK_SEND_ACL_DATA(p_buf); | + L2C_LINK_SEND_ACL_DATA(p_buf); |
4492 -> 4228 |
624 -> 624 |
l2c_link_send_to_lower 100% -> 83.86364% |
.rela.text, .text, .symtab |
True |
True |
| 137 |
duplicate-12 |
libs/RVL_SDK/src/bte/rfc_ts_frames.c:550 |
duplicate branch |
restored |
- return RFC_EVENT_UIH; | - return RFC_EVENT_UIH; | + return RFC_EVENT_UIH; |
5704 -> 4308 |
232 -> 232 |
rfc_parse_data 100% -> 99.33811% |
.rela.text, .text, .symtab |
True |
True |
| 138 |
duplicate-13 |
libs/RVL_SDK/src/bte/sdp_discovery.c:706 |
duplicate branch |
restored |
- p += MAX_UUID_SIZE - 4; | - p += MAX_UUID_SIZE - 4; | + p += MAX_UUID_SIZE - 4; |
4728 -> 3296 |
352 -> 0 |
add_attr 100% -> 99.70112% |
.strtab, .rela.text, .text, .symtab, .rela.data |
True |
True |
| 139 |
duplicate-14 |
libs/RVL_SDK/src/dvd/dvd.c:1771 |
duplicate branch |
restored |
- stateReady(); | - stateReady(); | + stateReady(); |
21692 -> 19164 |
20688 -> 20688 |
cbForStateBusy 100% -> 99.81013% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 140 |
duplicate-15 |
libs/RVL_SDK/src/dvd/dvd.c:1711 |
duplicate branch |
restored |
- return; | - return; | + return; |
21692 -> 21692 |
20688 -> 20688 |
|
.strtab |
True |
True |
| 141 |
duplicate-16 |
libs/RVL_SDK/src/dvd/dvd.c:600 |
duplicate branch |
restored |
- return; | - return; | + return; |
21692 -> 21692 |
20688 -> 20688 |
|
.strtab |
True |
True |
| 142 |
duplicate-17 |
libs/RVL_SDK/src/kpad/KPAD.c:1435 |
duplicate branch |
restored |
- coreButtons = 0; | - coreButtons = 0; | + coreButtons = 0; |
13056 -> 11220 |
8032 -> 8032 |
KPADRead 100% -> 99.54248% |
.rela.text, .text, .symtab |
True |
True |
| 143 |
duplicate-18 |
libs/RVL_SDK/src/nand/NANDCore.c:357 |
duplicate branch |
restored |
- return TRUE; | - return TRUE; | + return TRUE; |
4472 -> 4268 |
800 -> 800 |
nandOnShutdown 100% -> 93.62745% |
.rela.text, .text, .symtab |
True |
True |
| 144 |
duplicate-19 |
libs/RVL_SDK/src/nand/NANDCore.c:58 |
duplicate branch |
kept |
- break; | - break; | + break; |
4472 -> 4472 |
800 -> 800 |
|
|
True |
True |
| 145 |
duplicate-20 |
libs/RVL_SDK/src/nand/NANDLogging.c:136 |
duplicate branch |
restored |
- } else if (s_fd >= 0) { | - busy_flag = TRUE; | - } else { | - busy_flag = TRUE; | - } | + } else busy_flag = TRUE; |
2228 -> 1980 |
1048 -> 1048 |
NANDLoggingAddMessageAsync 100% -> 67.1129% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 146 |
duplicate-21 |
libs/RVL_SDK/src/os/OSAudioSystem.c:43 |
duplicate branch |
restored |
- ACRIOP_WRITE_REG32(HW_PLLAI, reg); | - ACRIOP_WRITE_REG32(HW_PLLAI, reg); | + ACRIOP_WRITE_REG32(HW_PLLAI, reg); |
1204 -> 660 |
128 -> 128 |
__AIClockInit 100% -> 97.64706% |
.text |
True |
True |
| 147 |
duplicate-22 |
libs/RVL_SDK/src/sc/scsystem.c:172 |
duplicate branch |
restored |
- __SCClearDirtyFlag(); | - OSRestoreInterrupts(enabled); | - __SCClearDirtyFlag(); | + } | + __SCClearDirtyFlag(); | - OSRestoreInterrupts(enabled); | - } | + OSRestoreInterrupts(enabled); |
7440 -> 7156 |
34072 -> 34072 |
SCCheckStatus 100% -> 94.22535% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 148 |
duplicate-23 |
libs/RVL_SDK/src/sdi/sdi_api.c:146 |
duplicate branch |
restored |
- __sdReq = 0; | - __sdReq = 0; | + __sdReq = 0; |
5948 -> 5348 |
248 -> 248 |
ISD_GetDeviceStatus 100% -> 90.545456%; ISD_ProbeCard 100% -> 26.978947% |
.debug, .strtab, .line, .rela.debug, .rela.text, .text, .symtab |
True |
True |
| 149 |
duplicate-24 |
libs/RVL_SDK/src/si/SIBios.c:529 |
duplicate branch |
restored |
- CallTypeAndStatusCallback(chan, Type[chan]); | - CallTypeAndStatusCallback(chan, Type[chan]); | + CallTypeAndStatusCallback(chan, Type[chan]); |
5488 -> 4800 |
680 -> 680 |
GetTypeCallback 100% -> 89.50581% |
.rela.text, .text, .symtab |
True |
True |
| 150 |
duplicate-25 |
libs/RVL_SDK/src/vi/vi3in1.c:460 |
duplicate branch |
restored |
- __VISendI2CData(0xe0, data, 2); | - WaitMicroTime(2); | - __VISendI2CData(0xe0, data, 2); | - WaitMicroTime(2); | + __VISendI2CData(0xe0, data, 2); | + WaitMicroTime(2); |
6976 -> 5776 |
1512 -> 1512 |
__VISetRevolutionModeSimple 100% -> 96.985016%; __VISetRGBOverDrive 100% -> 75.454544% |
.rela.text, .text, .symtab |
True |
True |
| 151 |
duplicate-26 |
libs/RVL_SDK/src/wpad/WPADHIDParser.c:877 |
duplicate branch |
restored |
- (*p_status)->obj[i].traceId = i; | - (*p_status)->obj[i].traceId = i; | + (*p_status)->obj[i].traceId = i; |
21664 -> 20536 |
1664 -> 1664 |
__parse_dpd_data 100% -> 94.05674% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 152 |
duplicate-27 |
libs/RVL_SDK/src/wpad/WPADHIDParser.c:515 |
duplicate branch |
restored |
- WPADiSendWriteData(cmdq, p_wpd->encryptionKey, 6, 0x4A40040, abortInitExtension); | - WPADiSendWriteData(cmdq, p_wpd->encryptionKey + 6, 6, 0x4A40046, abortInitExtension); | - WPADiSendWriteData(cmdq, p_wpd->encryptionKey + 12, 4, 0x4A4004C, abortInitExtension); | - WPADiSendReadData(cmdq, p_wpd->wmReadDataBuf, 32, 0x4A40020, p_wpd->extensionCB); | - WPADiSendWriteData(cmdq, p_wpd->encryptionKey, 6, 0x4A40040, abortInitExtension); | - WPADiSendWriteData(cmdq, p_wpd->encryptionKey + 6, 6, 0x4A40046, abortInitExtension); | - WPADiSendWriteData(cmdq, p_wpd->encryptionKey + 12, 4, 0x4A4004C, abortInitExtension); | - WPADiSendReadData(cmdq, p_wpd->wmReadDataBuf, 32, 0x4A40020, p_wpd->extensionCB); | + WPADiSendWriteData(cmdq, p_wpd->encryptionKey, 6, 0x4A40040, abortInitExtension); | + WPADiSendWriteData(cmdq, p_wpd->encryptionKey + 6, 6, 0x4A40046, abortInitExtension); | + WPADiSendWriteData(cmdq, p_wpd->encryptionKey + 12, 4, 0x4A4004C, abortInitExtension); | + WPADiSendReadData(cmdq, p_wpd->wmReadDataBuf, 32, 0x4A40020, p_wpd->extensionCB); |
21664 -> 20912 |
1664 -> 1664 |
getExtType 100% -> 84.276596% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 153 |
duplicate-28 |
libs/RVL_SDK/src/wud/WUD.c:241 |
duplicate branch |
restored |
- if (status == SC_STATUS_OK) { | - p->deleteState = WUD_STATE_DELETE_DONE; | - } else { | - p->deleteState = WUD_STATE_DELETE_DONE; | - } | + p->deleteState = WUD_STATE_DELETE_DONE; |
18852 -> 18852 |
12016 -> 12016 |
|
.strtab |
True |
True |
| 154 |
duplicate-29 |
libs/RevoEX/src/ncd/ncdsystem.c:253 |
duplicate branch |
restored |
- memcpy(&ipConfig->ip, &config->profiles[idx].ip, 0x14); | - memcpy(&ipConfig->ip, &config->profiles[idx].ip, 0x14); | + memcpy(&ipConfig->ip, &config->profiles[idx].ip, 0x14); |
4180 -> 3836 |
496 -> 496 |
NCDGetCurrentIpConfig 100% -> 83.46512% |
.rela.text, .text, .symtab |
True |
True |
| 155 |
duplicate-30 |
libs/RevoEX/src/ncd/ncdsystem.c:202 |
duplicate branch |
restored |
- memcpy(&profile->ip, &ipConfig->ip, 0x14); | - memcpy(&profile->ip, &ipConfig->ip, 0x14); | + memcpy(&profile->ip, &ipConfig->ip, 0x14); |
4180 -> 3496 |
496 -> 496 |
NCDSetIpConfig 100% -> 95.2924% |
.rela.text, .text, .symtab |
True |
True |
| 156 |
duplicate-31 |
libs/RevoEX/src/ncd/ncdsystem.c:180 |
duplicate branch |
restored |
- memcpy(&profile->ip, &ipConfig->ip, 0x14); | - memcpy(&profile->ip, &ipConfig->ip, 0x14); | + memcpy(&profile->ip, &ipConfig->ip, 0x14); |
4180 -> 3496 |
496 -> 496 |
NCDSetIpConfig 100% -> 95.2924% |
.rela.text, .text, .symtab |
True |
True |
| 157 |
duplicate-32 |
libs/RevoEX/src/nhttp/NHTTP_thread.c:726 |
duplicate branch |
restored |
- if (request->proxyEnabled) { context->error = NHTTP_ERROR_CONNECT_PROXY; return FALSE; } | + if (request->proxyEnabled) { context->error = NHTTP_ERROR_CONNECT_PROXY; } | - context->error = NHTTP_ERROR_CONNECT; return FALSE; | + context->error = NHTTP_ERROR_CONNECT; | + return FALSE; |
11292 -> 10908 |
504 -> 504 |
NHTTPi_ThreadConnectProc 100% -> 96.760414% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 158 |
duplicate-33 |
libs/RevoEX/src/nwc24/NWC24Mime.c:288 |
duplicate branch |
restored |
- encodedOffset++; | - encodedOffset++; | + encodedOffset++; |
6124 -> 5540 |
88 -> 88 |
QDecode 100% -> 99.28082% |
.rela.text, .text, .symtab |
True |
True |
| 159 |
duplicate-34 |
libs/RevoEX/src/nwc24/NWC24StdAPI.c:204 |
duplicate branch |
restored |
- charsWritten++; | - charsWritten++; | + charsWritten++; |
3772 -> 2388 |
136 -> 136 |
convNum 100% -> 99.69653% |
.rela.text, .text, .symtab |
True |
True |
| 160 |
duplicate-35 |
libs/RevoEX/src/vf/develop/sd_drv.c:110 |
duplicate branch |
restored |
- *sectorSize = 0x200; | - *totalSize = *totalSectors << 9; | - *sectorSize = 0x200; | - *totalSize = *totalSectors << 9; | + *sectorSize = 0x200; | + *totalSize = *totalSectors << 9; |
3608 -> 3328 |
992 -> 992 |
_VFiGetCardSize 100% -> 89.35714% |
.rela.text, .text, .symtab |
True |
True |
| 161 |
duplicate-36 |
libs/RevoEX/src/vf/fatfs/pf_cache.c:275 |
duplicate branch |
restored |
- (*pp_page)->sector = sector - (sector % (*pp_page)->size); | - (*pp_page)->p_buf = &(*pp_page)->buffer[(sector % (*pp_page)->size) << p_vol->bpb.log2_bytes_per_sector]; | - (*pp_page)->sector = sector - (sector % (*pp_page)->size); | - (*pp_page)->p_buf = &(*pp_page)->buffer[(sector % (*pp_page)->size) << p_vol->bpb.log2_bytes_per_sector]; | + (*pp_page)->sector = sector - (sector % (*pp_page)->size); | + (*pp_page)->p_buf = &(*pp_page)->buffer[(sector % (*pp_page)->size) << p_vol->bpb.log2_bytes_per_sector]; |
7148 -> 6368 |
0 -> 0 |
VFiPFCACHE_DoAllocatePage 100% -> 91.097435% |
.rela.text, .text, .symtab |
True |
True |
| 162 |
duplicate-37 |
libs/RevoEX/src/vf/fatfs/pf_cache.c:159 |
duplicate branch |
restored |
- *pp_head = p_page; | - *pp_head = p_page; | + *pp_head = p_page; |
7148 -> 5956 |
0 -> 0 |
VFiPFCACHE_WriteFATPage 100% -> 95.71429%; VFiPFCACHE_DoAllocatePage 100% -> 98.92308%; VFiPFCACHE_WriteDataPage 100% -> 96.111115% |
.rela.text, .text, .symtab |
True |
True |
| 163 |
duplicate-38 |
libs/RevoEX/src/vf/fatfs/pf_fat.c:306 |
duplicate branch |
restored |
- *is_found = PF_TRUE; | - *is_found = PF_TRUE; | + *is_found = PF_TRUE; |
12232 -> 11788 |
64 -> 64 |
VFiPFFAT_FindClusterLink 100% -> 97.61261% |
.rela.text, .text, .symtab |
True |
True |
| 164 |
duplicate-39 |
src/BS2/BS2Mach.c:1448 |
duplicate branch |
restored |
- State = BS2_STT_8; | - State = BS2_STT_8; | + State = BS2_STT_8; |
5112 -> 5112 |
158528 -> 155504 |
BS2Tick 98.799484% -> 99.052574% |
.rela.data, .strtab, .rela.text, .text, .symtab |
True |
True |
| 165 |
duplicate-40 |
src/BS2/BS2Mach.c:209 |
duplicate branch |
restored |
- OSRestoreInterrupts(enabled); | - OSRestoreInterrupts(enabled); | + OSRestoreInterrupts(enabled); |
5112 -> 4740 |
158528 -> 158528 |
BS2AbortStateMachine 100% -> 88.97849% |
.strtab, .rela.text, .text |
True |
True |
| 166 |
duplicate-41 |
src/channelScript/CHANSVm.c:5273 |
duplicate branch |
restored |
- intObj = CHANSVmConvertObjectType(VmInst, CHANS_VM_OBJ_TYPE_INTEGER, intObj); | - intObj = CHANSVmConvertObjectType(VmInst, CHANS_VM_OBJ_TYPE_INTEGER, intObj); | + intObj = CHANSVmConvertObjectType(VmInst, CHANS_VM_OBJ_TYPE_INTEGER, intObj); |
44588 -> 44588 |
6904 -> 6904 |
VmBlobPackCommon 98.0988% -> 97.5% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 167 |
duplicate-42 |
src/channelScript/CHANSVm.c:189 |
duplicate branch |
restored |
- object = (CHANSVmObjHdr*)ptr; | - object = (CHANSVmObjHdr*)ptr; | + object = (CHANSVmObjHdr*)ptr; |
44588 -> 44416 |
6904 -> 6904 |
CHANSVmNewObjHdr 100% -> 94.88372% |
.strtab, .text |
True |
True |
| 168 |
duplicate-43 |
src/homebutton/HBMBase.cpp:676 |
duplicate branch |
restored |
- mpGroupAnmController[idx]->play(); | - mpGroupAnmController[idx]->play(); | + mpGroupAnmController[idx]->play(); |
23608 -> 23364 |
3800 -> 3800 |
init_vib__Q210homebutton10HomeButtonFv 100% -> 79.44262% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 169 |
duplicate-44 |
src/homebutton/HBMBase.cpp:658 |
duplicate branch |
restored |
- mpGroupAnmController[idx]->play(); | - mpGroupAnmController[idx]->play(); | + mpGroupAnmController[idx]->play(); |
23608 -> 23260 |
3800 -> 3800 |
init_volume__Q210homebutton10HomeButtonFv 100% -> 88.85058% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 170 |
duplicate-45 |
src/keyboard/tiDebug.cpp:113 |
duplicate branch |
kept |
- GXEnd(); | - GXEnd(); | + GXEnd(); |
1556 -> 1556 |
24 -> 24 |
|
|
True |
True |
| 171 |
duplicate-46 |
src/keyboard/tiLayout.cpp:40 |
duplicate branch |
restored |
- if (cnt->type == nw4r::lyt::res::AnimationContent::ANIMTYPE_PANE) { | - if (strncmp(cnt->name, name, 17) == 0) { | - count++; | - } | - } else { | - if (strncmp(cnt->name, name, 17) == 0) { | - count++; | - } | + if (strncmp(cnt->name, name, 17) == 0) { | + count++; |
2180 -> 876 |
88 -> 88 |
CountAnimForPane___Q29textinput17AnimTransformPaneFPCc 100% -> 73.19149%; ForceBind__Q29textinput17AnimTransformPaneFPQ34nw4r3lyt4PanePCc 100% -> 74%; Bind__Q29textinput17AnimTransformPaneFPQ34nw4r3lyt4Paneb 100% -> 64.121216%; CountAnimForPane___Q29textinput17AnimTransformPaneFPQ34nw4r3lyt4Paneb 100% -> 52.2807% |
.strtab, .rela.text, .text, .symtab, .comment, .rela.data |
True |
True |
| 172 |
duplicate-47 |
src/scene/address/iplAddressEdit.cpp:2575 |
duplicate branch |
restored |
- frame->initFrame(); | - frame->restart(); | - frame->initFrame(); | - frame->restart(); | + frame->initFrame(); | + frame->restart(); |
23344 -> 21204 |
2560 -> 408 |
onEventDerived__Q33ipl5scene11AddressEditFUlUlPCQ33ipl10controller9Interface 100% -> 98.24112% |
.rela.data, .rela.text, .text, .symtab |
True |
True |
| 173 |
duplicate-48 |
src/scene/board/iplBoardObject.cpp:594 |
duplicate branch |
restored |
- DELETE_PTR_ARRAY_FORCE(picture->mpWork); | - DELETE_PTR_ARRAY_FORCE(picture->mpWork); | + DELETE_PTR_ARRAY_FORCE(picture->mpWork); |
9184 -> 8788 |
1320 -> 1320 |
create_picture__Q33ipl5scene11BoardObjectFPQ33ipl5scene7picturePQ23EGG4HeapPQ23EGG4HeapPUcUl 100% -> 92.71717% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 174 |
duplicate-49 |
src/scene/channelEdit/iplChannelEdit.cpp:1346 |
duplicate branch |
restored |
- mState = STATE_ON_VERIFY1ST; | - mState = STATE_ON_VERIFY1ST; | + mState = STATE_ON_VERIFY1ST; |
13412 -> 13196 |
1600 -> 1600 |
on_exist_app__Q33ipl5scene11ChannelEditFv 100% -> 96.111115% |
.rela.text, .text, .symtab |
True |
True |
| 175 |
duplicate-50 |
src/scene/channelEdit/iplChannelEdit.cpp:1310 |
duplicate branch |
restored |
- mState = STATE_ON_END_FORMAT; | - mState = STATE_ON_END_FORMAT; | + mState = STATE_ON_END_FORMAT; |
13412 -> 13236 |
1600 -> 1600 |
on_end_process__Q33ipl5scene11ChannelEditFv 100% -> 95.34091% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 176 |
duplicate-51 |
src/scene/channelEdit/iplChannelEdit.cpp:1231 |
duplicate branch |
restored |
- mState = STATE_ON_CHANGE_TAG1ST; | - mState = STATE_ON_CHANGE_TAG1ST; | + mState = STATE_ON_CHANGE_TAG1ST; |
13412 -> 13308 |
1600 -> 1600 |
on_sd_message3rd__Q33ipl5scene11ChannelEditFv 100% -> 92.11539% |
.rela.text, .text, .symtab |
True |
True |
| 177 |
duplicate-52 |
src/scene/channelEdit/iplNandSDCardManager.cpp:420 |
duplicate branch |
restored |
- mState = STATE_LIST_SDAPP; | - mState = STATE_LIST_SDAPP; | + mState = STATE_LIST_SDAPP; |
11264 -> 9772 |
416 -> 16 |
on_normal__Q33ipl5scene17NandSDCardManagerFv 100% -> 99.4504% |
.strtab, .line, .rela.debug, .rela.text, .symtab, .rela.data |
True |
True |
| 178 |
duplicate-53 |
src/scene/channelEdit/iplNandSDCardManager.cpp:407 |
duplicate branch |
restored |
- mState = STATE_LIST_NANDAPP; | - mState = STATE_LIST_NANDAPP; | + mState = STATE_LIST_NANDAPP; |
11264 -> 9772 |
416 -> 16 |
on_normal__Q33ipl5scene17NandSDCardManagerFv 100% -> 99.4504% |
.strtab, .line, .rela.debug, .rela.text, .symtab, .rela.data |
True |
True |
| 179 |
duplicate-54 |
src/scene/channelEdit/iplNandSDCardManager.cpp:373 |
duplicate branch |
restored |
- mState = STATE_DEL_NANDAPP; | - mState = STATE_DEL_NANDAPP; | + mState = STATE_DEL_NANDAPP; |
11264 -> 9772 |
416 -> 16 |
on_normal__Q33ipl5scene17NandSDCardManagerFv 100% -> 99.4504% |
.strtab, .line, .rela.debug, .rela.text, .symtab, .rela.data |
True |
True |
| 180 |
duplicate-55 |
src/scene/channelSelect/iplChannelSelect.cpp:1662 |
duplicate branch |
restored |
- return isPageCreated(page); | - return isPageCreated(page); | + return isPageCreated(page); |
25668 -> 25576 |
2336 -> 2336 |
prepareRestarting__Q33ipl5scene13ChannelSelectFi 100% -> 90.86957% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 181 |
duplicate-56 |
src/scene/letterWriter/iplLetterWriter.cpp:143 |
duplicate branch |
restored |
- TextWriter::initCalcNormal(); | - TextWriter::initCalcNormal(); | + TextWriter::initCalcNormal(); |
6092 -> 5528 |
632 -> 632 |
initCalcNormal__Q33ipl5scene12LetterWriterFv 100% -> 97.12766% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 182 |
duplicate-57 |
src/scene/memory/iplMemory.cpp:1339 |
duplicate branch |
restored |
- mState = STATE_ON_VERIFY1ST; | - mState = STATE_ON_VERIFY1ST; | + mState = STATE_ON_VERIFY1ST; |
12984 -> 12768 |
1560 -> 1560 |
on_exist_save__Q33ipl5scene6MemoryFv 100% -> 96.111115% |
.rela.text, .text, .symtab |
True |
True |
| 183 |
duplicate-58 |
src/scene/memory/iplMemory.cpp:1303 |
duplicate branch |
restored |
- mState = STATE_ON_END_FORMAT; | - mState = STATE_ON_END_FORMAT; | + mState = STATE_ON_END_FORMAT; |
12984 -> 12808 |
1560 -> 1560 |
on_end_process__Q33ipl5scene6MemoryFv 100% -> 95.34091% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 184 |
duplicate-59 |
src/scene/memory/iplMemory.cpp:1175 |
duplicate branch |
restored |
- mState = STATE_ON_CHANGE_TAG1ST; | - mState = STATE_ON_CHANGE_TAG1ST; | + mState = STATE_ON_CHANGE_TAG1ST; |
12984 -> 12880 |
1560 -> 1560 |
on_sd_message3rd__Q33ipl5scene6MemoryFv 100% -> 92.11539% |
.rela.text, .text, .symtab |
True |
True |
| 185 |
duplicate-60 |
src/scene/nakamuraTest/iplNakamuraTest.cpp:417 |
duplicate branch |
restored |
- cmd = FADER_SCN_NEXT; | - cmd = FADER_SCN_NEXT; | + cmd = FADER_SCN_NEXT; |
3596 -> 744 |
912 -> 40 |
calcNormal__Q33ipl5scene12NakamuraTestFv 100% -> 99.85274% |
.rela.data, .strtab, .rela.text, .text, .symtab |
True |
True |
| 186 |
duplicate-61 |
src/scene/parentalDialog/iplParentalDialog.cpp:289 |
duplicate branch |
restored |
- mState = STATE_WAIT_MSG; | - mState = STATE_WAIT_MSG; | + mState = STATE_WAIT_MSG; |
4540 -> 3900 |
808 -> 808 |
start_trig_event__Q33ipl5scene14ParentalDialogFPCci 100% -> 97.39375% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 187 |
duplicate-62 |
src/scene/setting/AOSS.c:780 |
duplicate branch |
restored |
- resultCode = 0xffffffff; | - resultCode = 0xffffffff; | + resultCode = 0xffffffff; |
7720 -> 7720 |
3928 -> 3928 |
AOSS_Init_old 96.18624% -> 96.21149% |
.strtab, .rela.text, .text |
True |
True |
| 188 |
duplicate-63 |
src/scene/setting/AOSS.c:497 |
duplicate branch |
restored |
- resultCode = 0xffffffff; | - resultCode = 0xffffffff; | + resultCode = 0xffffffff; |
7720 -> 7720 |
3928 -> 3928 |
AOSS_Init_old 96.18624% -> 95.88952% |
.rela.text, .text, .symtab |
True |
True |
| 189 |
duplicate-64 |
src/scene/setting/iplSetting.cpp:1472 |
duplicate branch |
restored |
- static_cast<utility::FrameController*>(wideMaterial)->initFrame(); | - static_cast<utility::FrameController*>(wideMaterial)->restart(); | - static_cast<utility::FrameController*>(wideMaterial)->initFrame(); | - static_cast<utility::FrameController*>(wideMaterial)->restart(); | + static_cast<utility::FrameController*>(wideMaterial)->initFrame(); | + static_cast<utility::FrameController*>(wideMaterial)->restart(); |
36796 -> 34268 |
5696 -> 5696 |
draw__Q33ipl5scene7SettingFv 100% -> 99.35918% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 190 |
duplicate-65 |
src/system/iplNand.cpp:309 |
duplicate branch |
restored |
- if (mpArc) { | - if (mbIsNandFile) { | - result = wrapper::Close(&mNandFile); | - return nand_error_handling(result); | - } else { | - return ARCClose(&mArcFile) == TRUE; | - } | + if (mbIsNandFile) { | + result = wrapper::Close(&mNandFile); | + return nand_error_handling(result); | - if (mbIsNandFile) { | - result = wrapper::Close(&mNandFile); | - return nand_error_handling(result); | - } else { | - return ARCClose(&mArcFile) == TRUE; | - } | + return ARCClose(&mArcFile) == TRUE; |
5108 -> 4940 |
272 -> 272 |
close___Q33ipl4nand4FileFv 100% -> 57% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 191 |
duplicate-66 |
src/system/iplNandMeta.cpp:46 |
duplicate branch |
restored |
- nand_error_handling(result); | - nand_error_handling(result); | + nand_error_handling(result); |
1536 -> 1356 |
136 -> 136 |
readNandBlock___Q33ipl4nand8MetaFileFPvii 100% -> 93.22222% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 192 |
duplicate-67 |
src/system/iplNandSDWorker.cpp:1714 |
duplicate branch |
restored |
- myWork->asyncResult = thumbnailSize; | - myWork->asyncResult = thumbnailSize; | + myWork->asyncResult = thumbnailSize; |
51428 -> 50928 |
12312 -> 12312 |
do_get_sd_app_meta__Q23ipl12NandSDWorkerFv 100% -> 96.6% |
.rela.line, .strtab, .symtab, .line, .rela.debug |
True |
True |
| 193 |
duplicate-68 |
src/system/iplNandSDWorker.cpp:1676 |
duplicate branch |
restored |
- myWork->asyncResult = thumbnailSize; | - myWork->asyncResult = thumbnailSize; | + myWork->asyncResult = thumbnailSize; |
51428 -> 50968 |
12312 -> 12312 |
do_get_sd_app_thumbnail__Q23ipl12NandSDWorkerFv 100% -> 96.304344% |
.rela.line, .strtab, .symtab, .line, .rela.debug |
True |
True |
| 194 |
duplicate-69 |
src/system/rvl_dec.c:666 |
duplicate branch |
kept |
- distanceBitWord = nextDistanceBits; | - distanceBitWord = nextDistanceBits; | + distanceBitWord = nextDistanceBits; |
2600 -> 2600 |
36872 -> 36872 |
|
|
True |
True |
| 195 |
duplicate-70 |
src/system/rvl_dec.c:643 |
duplicate branch |
kept |
- literalBitWord = decodeBitsOrCount; | - literalBitWord = decodeBitsOrCount; | + literalBitWord = decodeBitsOrCount; |
2600 -> 2600 |
36872 -> 36872 |
|
|
True |
True |
| 196 |
duplicate-71 |
src/utility/iplTree.cpp:13 |
duplicate branch |
restored |
- tree->mpParent = this; | - tree->mpParent = this; | + tree->mpParent = this; |
324 -> 264 |
32 -> 32 |
attach__Q33ipl7utility4TreeFPQ33ipl7utility4Tree 100% -> 79.666664% |
.rela.text, .text, .symtab |
True |
True |
| 197 |
vm-scratch-False |
src/channelScript/CHANSVm.c:7106 |
targeted source cleanup |
restored |
- struct { | - CHANSVmObjType operandTypes[2]; | - double floatLiteral; | - CHANSVmObjHdr copies[2]; | - CHANSVmObjHdr load; | - CHANSVmObjHdr operand; | - } scratch; | + CHANSVmObjType operandTypes[2]; | + double floatLiteral; | + CHANSVmObjHdr copies[2]; | + CHANSVmObjHdr load; | + CHANSVmObjHdr operand; | - memset(&scratch.operand, 0, sizeof(scratch.operand)); | - stackPtr = scratch.copies; | + memset(&operand, 0, sizeof(operand)); | + stackPtr = copies; | - memcpy(&scratch.floatLiteral, operandBuf, 8); | - result = CHANSVmSetFloat(vm, &pVm->accumulator, scratch.floatLiteral); | + memcpy(&floatLiteral, operandBuf, 8); | + result = CHANSVmSetFloat(vm, &pVm->accumulator, floatLiteral); | - rightOp = &scratch.operand; | + rightOp = &operand; | - result = VmLoadImmInteger(vm, &scratch.operand, operandBuf, 1); | + result = VmLoadImmInteger(vm, &operand, operandBuf, 1); | - enumedType = scratch.operandTypes; | + enumedType = operandTypes; | - convTypeIdx = convTbl[scratch.operandTypes[0] * 6 + scratch.operandTypes[1]]; | + convTypeIdx = convTbl[operandTypes[0] * 6 + operandTypes[1]]; | - result = CHANSVmDeleteObject(vm, &scratch.operand); | - if (result == CHANS_VM_OK && leftOp != &pVm->accumulator && leftOp != &scratch.operand && (leftOp->flags.raw & CHANSVM_OBJ_FLAG_READONLY) == 0 && | + result = CHANSVmDeleteObject(vm, &operand); | + if (result == CHANS_VM_OK && leftOp != &pVm- [see trial candidate in /tmp/rx56/trials] |
44588 -> 44588 |
6904 -> 6904 |
CHANSVmStep 96.98723% -> 96.97207% |
.strtab, .text |
True |
True |
| 198 |
vm-scratch-True |
src/channelScript/CHANSVm.c:7106 |
targeted source cleanup |
restored |
- struct { | - CHANSVmObjType operandTypes[2]; | - double floatLiteral; | - CHANSVmObjHdr copies[2]; | - CHANSVmObjHdr load; | - CHANSVmObjHdr operand; | - } scratch; | + CHANSVmObjHdr operand; | + CHANSVmObjHdr load; | + CHANSVmObjHdr copies[2]; | + double floatLiteral; | + CHANSVmObjType operandTypes[2]; | - memset(&scratch.operand, 0, sizeof(scratch.operand)); | - stackPtr = scratch.copies; | + memset(&operand, 0, sizeof(operand)); | + stackPtr = copies; | - memcpy(&scratch.floatLiteral, operandBuf, 8); | - result = CHANSVmSetFloat(vm, &pVm->accumulator, scratch.floatLiteral); | + memcpy(&floatLiteral, operandBuf, 8); | + result = CHANSVmSetFloat(vm, &pVm->accumulator, floatLiteral); | - rightOp = &scratch.operand; | + rightOp = &operand; | - result = VmLoadImmInteger(vm, &scratch.operand, operandBuf, 1); | + result = VmLoadImmInteger(vm, &operand, operandBuf, 1); | - enumedType = scratch.operandTypes; | + enumedType = operandTypes; | - convTypeIdx = convTbl[scratch.operandTypes[0] * 6 + scratch.operandTypes[1]]; | + convTypeIdx = convTbl[operandTypes[0] * 6 + operandTypes[1]]; | - result = CHANSVmDeleteObject(vm, &scratch.operand); | - if (result == CHANS_VM_OK && leftOp != &pVm->accumulator && leftOp != &scratch.operand && (leftOp->flags.raw & CHANSVM_OBJ_FLAG_READONLY) == 0 && | + result = CHANSVmDeleteObject(vm, &operand); | + if (result == CHANS_VM_OK && leftOp != &pVm- [see trial candidate in /tmp/rx56/trials] |
44588 -> 44588 |
6904 -> 6904 |
CHANSVmStep 96.98723% -> 96.97526% |
.strtab, .text |
True |
True |
| 199 |
bs2-loader-False |
src/BS2/BS2Mach.c:1333 |
targeted source cleanup |
restored |
- struct { | - u32 offset; | - u32 length; | - u32 address; | - } loaderRead; | + u32 loaderOffset; | + u32 loaderLength; | + u32 loaderAddress; | - status = ((int (*)(u32 *, u32 *, u32 *))((*(void **)&LoaderMain)))(&loaderRead.address, &loaderRead.length, &loaderRead.offset); | + status = ((int (*)(u32 *, u32 *, u32 *))((*(void **)&LoaderMain)))(&loaderAddress, &loaderLength, &loaderOffset); | - BS2Report("Addr [0x%x] length [0x%x] offset [0x%x]\n", loaderRead.address, loaderRead.length, loaderRead.offset); | + BS2Report("Addr [0x%x] length [0x%x] offset [0x%x]\n", loaderAddress, loaderLength, loaderOffset); | - DVDReadAbsAsyncForBS(&Block, (void *)loaderRead.address, loaderRead.length, loaderRead.offset >> __DVDLayoutFormat, BS2DVDCallback); | + DVDReadAbsAsyncForBS(&Block, (void *)loaderAddress, loaderLength, loaderOffset >> __DVDLayoutFormat, BS2DVDCallback); | - DvdTransferLength = loaderRead.length; | + DvdTransferLength = loaderLength; | - status = ((int (*)(u32 *, u32 *, u32 *))((*(void **)&LoaderMain)))(&loaderRead.address, &loaderRead.length, &loaderRead.offset); | + status = ((int (*)(u32 *, u32 *, u32 *))((*(void **)&LoaderMain)))(&loaderAddress, &loaderLength, &loaderOffset); | - BS2Report("Addr [0x%x] length [0x%x] offset [0x%x]\n", loaderRead.address, loaderRead.length, loaderRead.offset); | + BS2Report("Addr [0x%x] length [0x%x] offset [0x%x]\n", loaderAddress, [see trial candidate in /tmp/rx56/trials] |
5112 -> 5112 |
158528 -> 158528 |
BS2Tick 98.799484% -> 98.78196% |
.strtab, .text |
True |
True |
| 200 |
bs2-loader-True |
src/BS2/BS2Mach.c:1333 |
targeted source cleanup |
restored |
- struct { | - u32 offset; | - u32 length; | - u32 address; | - } loaderRead; | + u32 loaderAddress; | + u32 loaderLength; | + u32 loaderOffset; | - status = ((int (*)(u32 *, u32 *, u32 *))((*(void **)&LoaderMain)))(&loaderRead.address, &loaderRead.length, &loaderRead.offset); | + status = ((int (*)(u32 *, u32 *, u32 *))((*(void **)&LoaderMain)))(&loaderAddress, &loaderLength, &loaderOffset); | - BS2Report("Addr [0x%x] length [0x%x] offset [0x%x]\n", loaderRead.address, loaderRead.length, loaderRead.offset); | + BS2Report("Addr [0x%x] length [0x%x] offset [0x%x]\n", loaderAddress, loaderLength, loaderOffset); | - DVDReadAbsAsyncForBS(&Block, (void *)loaderRead.address, loaderRead.length, loaderRead.offset >> __DVDLayoutFormat, BS2DVDCallback); | + DVDReadAbsAsyncForBS(&Block, (void *)loaderAddress, loaderLength, loaderOffset >> __DVDLayoutFormat, BS2DVDCallback); | - DvdTransferLength = loaderRead.length; | + DvdTransferLength = loaderLength; | - status = ((int (*)(u32 *, u32 *, u32 *))((*(void **)&LoaderMain)))(&loaderRead.address, &loaderRead.length, &loaderRead.offset); | + status = ((int (*)(u32 *, u32 *, u32 *))((*(void **)&LoaderMain)))(&loaderAddress, &loaderLength, &loaderOffset); | - BS2Report("Addr [0x%x] length [0x%x] offset [0x%x]\n", loaderRead.address, loaderRead.length, loaderRead.offset); | + BS2Report("Addr [0x%x] length [0x%x] offset [0x%x]\n", loaderAddress, [see trial candidate in /tmp/rx56/trials] |
5112 -> 5112 |
158528 -> 158528 |
BS2Tick 98.799484% -> 98.78196% |
.strtab, .text |
True |
True |
| 201 |
bs2-ticket-buffers |
src/BS2/BS2Mach.c:495 |
targeted source cleanup |
restored |
- struct { | - ESTitleId title[4]; | - u32 count[56]; | - } work ALIGN32; | + ESTitleId titleWork ALIGN32; | + u32 countWork ALIGN32; | - ESTitleId *title = work.title; | - u32 *ticketCount = work.count; | + ESTitleId *title = &titleWork; | + u32 *ticketCount = &countWork; |
5112 -> 4828 |
158528 -> 158528 |
BS2ESGetTicketViews 100% -> 99.788734% |
.strtab, .text |
True |
True |
| 202 |
bs2-launch-buffer |
src/BS2/BS2Mach.c:537 |
targeted source cleanup |
restored |
- struct { | - ESTitleId title[32]; | - } launchWork ALIGN32; | + ESTitleId launchTitle ALIGN32; | - ESTitleId *title = launchWork.title; | + ESTitleId *title = &launchTitle; |
5112 -> 4564 |
158528 -> 158528 |
BS2Reboot 100% -> 99.88321% |
.text |
True |
True |
| 203 |
cdb-epoch-padding-sized |
libs/RevoEX/src/cdb/CDBConv.c:349 |
targeted source cleanup |
restored |
- union { | - char storage[20]; | - struct { | - char prefix[8]; | - char value[12]; | - } epoch; | - } epochBuffer; | - strncpy(epochBuffer.epoch.value, CDBKeyStrEpoch(keyString), CDB_KEYSTR_EPOCH_SIZE); | - epochBuffer.epoch.value[CDB_KEYSTR_EPOCH_SIZE] = 0; | - sscanf(epochBuffer.epoch.value, "%ul", &epoch); | + char epochString[12]; | + strncpy(epochString, CDBKeyStrEpoch(keyString), CDB_KEYSTR_EPOCH_SIZE); | + epochString[CDB_KEYSTR_EPOCH_SIZE] = 0; | + sscanf(epochString, "%ul", &epoch); |
4676 -> 3984 |
232 -> 232 |
CDBConvKeyStrToFullPath_ 100% -> 99.96532% |
.text |
True |
True |
| 204 |
cdb-epoch-padding-terminated |
libs/RevoEX/src/cdb/CDBConv.c:349 |
targeted source cleanup |
restored |
- union { | - char storage[20]; | - struct { | - char prefix[8]; | - char value[12]; | - } epoch; | - } epochBuffer; | - strncpy(epochBuffer.epoch.value, CDBKeyStrEpoch(keyString), CDB_KEYSTR_EPOCH_SIZE); | - epochBuffer.epoch.value[CDB_KEYSTR_EPOCH_SIZE] = 0; | - sscanf(epochBuffer.epoch.value, "%ul", &epoch); | + char epochString[CDB_KEYSTR_EPOCH_SIZE + 1]; | + strncpy(epochString, CDBKeyStrEpoch(keyString), CDB_KEYSTR_EPOCH_SIZE); | + epochString[CDB_KEYSTR_EPOCH_SIZE] = 0; | + sscanf(epochString, "%ul", &epoch); |
4676 -> 3984 |
232 -> 232 |
CDBConvKeyStrToFullPath_ 100% -> 99.96532% |
.text |
True |
True |
| 205 |
mbfield-True |
libs/RevoEX/src/nwc24/NWC24MsgCommit.c:205 |
targeted source cleanup |
restored |
- typedef struct { | + static inline NWC24Err WriteMBRegDateField(NWC24MsgObjPrivate* msg) { | - } MBFieldWork; | - static inline NWC24Err WriteMBRegDateField(NWC24MsgObjPrivate* msg) { | - MBFieldWork field; | - field.flags = msg->msgBoardFlags.raw & 0xFFFF; | - if (!field.flags) | + flags = msg->msgBoardFlags.raw & 0xFFFF; | + if (!flags) | - field.buffer = NWC24WorkP->stringWork; | - Mail_memset(field.buffer, 0, 1024); | - Mail_sprintf(field.buffer, "X-Wii-MB-RegDate: %04X\r\n", field.flags); | - length = STD_strnlen(field.buffer, 1024); | - err = NWC24FWrite(field.buffer, length, m_pFile); | + buffer = NWC24WorkP->stringWork; | + Mail_memset(buffer, 0, 1024); | + Mail_sprintf(buffer, "X-Wii-MB-RegDate: %04X\r\n", flags); | + length = STD_strnlen(buffer, 1024); | + err = NWC24FWrite(buffer, length, m_pFile); | - MBFieldWork field; | + u32 flags; | + char* buffer; | - field.flags = msg->msgBoardFlags.raw & 0xFF0000; | - if (!field.flags) | + flags = msg->msgBoardFlags.raw & 0xFF0000; | + if (!flags) | - field.buffer = NWC24WorkP->stringWork; | - Mail_memset(field.buffer, 0, 1024); | - Mail_sprintf(field.buffer, "X-Wii-MB-Delay: %02X\r\n", field.flags >> 16); | - length = STD_strnlen(field.buffer, 1024); | - err = NWC24FWrite(field.buffer, length, m_pFile); | + buffer = NWC24WorkP->stringWork; | + Mail_memset(buffer, 0, 1024); | + Mail_sprintf(buffer, "X-Wii-MB-Delay: %02X\r\n [see trial candidate in /tmp/rx56/trials] |
8532 -> 5224 |
904 -> 904 |
NWC24CommitMsgInternal 100% -> 99.91536% |
.strtab, .text |
True |
True |
| 206 |
mbfield-False |
libs/RevoEX/src/nwc24/NWC24MsgCommit.c:205 |
targeted source cleanup |
restored |
- typedef struct { | + static inline NWC24Err WriteMBRegDateField(NWC24MsgObjPrivate* msg) { | + char* buffer; | - char* buffer; | - } MBFieldWork; | - static inline NWC24Err WriteMBRegDateField(NWC24MsgObjPrivate* msg) { | - MBFieldWork field; | - field.flags = msg->msgBoardFlags.raw & 0xFFFF; | - if (!field.flags) | + flags = msg->msgBoardFlags.raw & 0xFFFF; | + if (!flags) | - field.buffer = NWC24WorkP->stringWork; | - Mail_memset(field.buffer, 0, 1024); | - Mail_sprintf(field.buffer, "X-Wii-MB-RegDate: %04X\r\n", field.flags); | - length = STD_strnlen(field.buffer, 1024); | - err = NWC24FWrite(field.buffer, length, m_pFile); | + buffer = NWC24WorkP->stringWork; | + Mail_memset(buffer, 0, 1024); | + Mail_sprintf(buffer, "X-Wii-MB-RegDate: %04X\r\n", flags); | + length = STD_strnlen(buffer, 1024); | + err = NWC24FWrite(buffer, length, m_pFile); | - MBFieldWork field; | + char* buffer; | + u32 flags; | - field.flags = msg->msgBoardFlags.raw & 0xFF0000; | - if (!field.flags) | + flags = msg->msgBoardFlags.raw & 0xFF0000; | + if (!flags) | - field.buffer = NWC24WorkP->stringWork; | - Mail_memset(field.buffer, 0, 1024); | - Mail_sprintf(field.buffer, "X-Wii-MB-Delay: %02X\r\n", field.flags >> 16); | - length = STD_strnlen(field.buffer, 1024); | - err = NWC24FWrite(field.buffer, length, m_pFile); | + buffer = NWC24WorkP->stringWork; | + Mail_memset(buffer, 0, 1024); | + Mail_sprin [see trial candidate in /tmp/rx56/trials] |
8532 -> 5224 |
904 -> 904 |
NWC24CommitMsgInternal 100% -> 99.91536% |
.strtab, .text |
True |
True |
| 207 |
aterm-key-array |
src/scene/setting/ATERM.c:1295 |
targeted source cleanup |
kept |
- struct { | - char text[32]; | - char terminator; | - } keyText; | + char keyText[33]; | - keyString = keyText.text; | + keyString = keyText; | - memcpy(keyText.text, sourceKey, 0x20); | - keyText.terminator = '\0'; | - keyLength = strlen(keyText.text); | + memcpy(keyText, sourceKey, 0x20); | + keyText[32] = '\0'; | + keyLength = strlen(keyText); |
12200 -> 12200 |
18864 -> 18864 |
|
|
True |
True |
| 208 |
nhttp-token-comparison |
libs/RevoEX/src/nhttp/NHTTP_thread.c:989 |
targeted source cleanup |
restored |
- struct TokenMatch { | - BOOL matched; | - }; | - struct TokenMatch match = {FALSE}; | - if (NHTTPi_compareTokenN_HdrRecvBuf(response, offset, offset + length, "Keep-Alive", 0) == 0) | - { | - match.matched = TRUE; | - context->keepAlive = match.matched; | - } | - else context->keepAlive = match.matched; | + context->keepAlive = NHTTPi_compareTokenN_HdrRecvBuf(response, offset, offset + length, "Keep-Alive", 0) == 0; |
11292 -> 10528 |
504 -> 504 |
NHTTPi_ThreadParseHeaderProc 100% -> 96.910995% |
.rela.text, .strtab, .text, .symtab |
True |
True |
| 209 |
nhttp-token-if |
libs/RevoEX/src/nhttp/NHTTP_thread.c:989 |
targeted source cleanup |
restored |
- struct TokenMatch { | - BOOL matched; | - }; | - struct TokenMatch match = {FALSE}; | - match.matched = TRUE; | - context->keepAlive = match.matched; | + context->keepAlive = TRUE; | - else context->keepAlive = match.matched; | + else context->keepAlive = FALSE; |
11292 -> 10528 |
504 -> 504 |
NHTTPi_ThreadParseHeaderProc 100% -> 98.58639% |
.rela.text, .strtab, .text |
True |
True |
| 210 |
letter-identity |
src/scene/letterWriter/iplLetterWriter.cpp:17 |
targeted source cleanup |
restored |
- static inline wchar_t* letterWriterCaption(wchar_t* caption) { | - return caption; | - } | - const wchar_t* caption = letterWriterCaption(makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name)); | + const wchar_t* caption = makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name); |
6092 -> 5528 |
632 -> 632 |
initCalcNormal__Q33ipl5scene12LetterWriterFv 100% -> 99.92908% |
.strtab, .text |
True |
True |
| 211 |
keyboard-init-zero |
src/keyboard/tiPcKeyboard.cpp:1643 |
targeted source cleanup |
restored |
- u32 keyMode; | + u32 keyMode = 0; |
28484 -> 28064 |
18564 -> 18564 |
setTranslateMode__Q49textinput8keyboard6pctype4BaseFQ59textinput8keyboard6pctype4Base13TranslateMode 100% -> 99.04762% |
.rela.text, .text, .symtab |
True |
True |
| 212 |
keyboard-init-input-mode |
src/keyboard/tiPcKeyboard.cpp:1643 |
targeted source cleanup |
restored |
- u32 keyMode; | + u32 keyMode = mode; |
28484 -> 28064 |
18564 -> 18564 |
setTranslateMode__Q49textinput8keyboard6pctype4BaseFQ59textinput8keyboard6pctype4Base13TranslateMode 100% -> 99.04762% |
.rela.text, .text, .symtab |
True |
True |
| 213 |
keyboard-init-current-mode |
src/keyboard/tiPcKeyboard.cpp:1643 |
targeted source cleanup |
restored |
- u32 keyMode; | + u32 keyMode = mKeyState.abcFlags & 15; |
28484 -> 28064 |
18564 -> 18564 |
setTranslateMode__Q49textinput8keyboard6pctype4BaseFQ59textinput8keyboard6pctype4Base13TranslateMode 100% -> 95.2381% |
.strtab, .rela.text, .text, .symtab |
True |
True |
| 214 |
alloc-register |
libs/MSL/src/MSL_Common/alloc.c:435 |
targeted source cleanup |
kept |
- register Block* bp; | - register SubBlock* ptr; | + Block* bp; | + SubBlock* ptr; | - void* malloc(register unsigned int size) { | + void* malloc(unsigned int size) { | - register __mem_pool_obj* pool_obj; | + __mem_pool_obj* pool_obj; | - register unsigned int rv = size; | - register __mem_pool_obj* pool; | + unsigned int rv = size; | + __mem_pool_obj* pool; | - register void* ptr; | - register unsigned int total; | + void* ptr; | + unsigned int total; |
5176 -> 5176 |
288 -> 288 |
|
|
True |
True |
| 215 |
cx-volatile |
libs/RVL_SDK/src/cx/CXStreamingUncompression.c:362 |
volatile cast |
compile rejected |
- int c = (*(vu8*)context->decodeTable << currBit) & 0x80; // ? | + int c = (*context->decodeTable << currBit) & 0x80; // ? |
|
|
|
|
not measured |
not measured |
| 216 |
semaphore-volatile |
libs/RVL_SDK/src/os/OSSemaphore.c:16 |
volatile cast |
restored |
- while ((count = ((volatile OSSemaphore*)sem)->count) <= 0) { | + while ((count = sem->count) <= 0) { |
296 -> 184 |
0 -> 0 |
OSWaitSemaphore 100% -> 89.10714% |
.text, .symtab, .rela.text |
True |
True |
| 217 |
thread-volatile |
libs/RVL_SDK/src/os/OSThread.c:540 |
volatile cast |
kept |
- if (((volatile OSThread*)thread)->state == OS_THREAD_STATE_DEAD) { | + if (thread->state == OS_THREAD_STATE_DEAD) { |
8232 -> 8232 |
4656 -> 4656 |
|
|
True |
True |
| 218 |
dvd-volatile |
libs/RVL_SDK/src/dvd/dvd.c:1897 |
volatile cast |
restored |
- if (((volatile DVDCommandBlock*)block)->state == DVD_STATE_COVER_CLOSED) { | + if (block->state == DVD_STATE_COVER_CLOSED) { | - } else if (((volatile DVDCommandBlock*)block)->state == DVD_STATE_COVER_OPENED) { | + } else if (block->state == DVD_STATE_COVER_OPENED) { | - retVal = ((volatile DVDCommandBlock*)block)->state; | + retVal = block->state; | - retVal = ((volatile DVDCommandBlock*)block)->state; | + retVal = block->state; | - retVal = ((volatile DVDCommandBlock*)block)->state; | + retVal = block->state; | - state = ((volatile DVDCommandBlock*)block)->state; | + state = block->state; | - command = ((volatile DVDCommandBlock*)block)->command; | + command = block->command; |
21692 -> 21492 |
20688 -> 20688 |
DVDGetCommandBlockStatus 100% -> 87.94% |
.rela.text, .text, .symtab |
True |
True |
| 219 |
rso-volatile |
src/system/RsoSystem.cpp:14 |
volatile cast |
restored |
- GXColor front = {*((volatile const unsigned char*)&scRsoFatalColorR), *((volatile const unsigned char*)&scRsoFatalColorG), *((volatile const unsigned char*)&scRsoFatalColorB), *((volatile const unsigned char*)&scRsoFatalColorA)}; \ | + GXColor front = {scRsoFatalColorR, scRsoFatalColorG, scRsoFatalColorB, scRsoFatalColorA}; \ |
2848 -> 2640 |
96 -> 96 |
GetTextColor__Q34nw4r3lyt7TextBoxCFUl 100% -> 91.23077% |
.rela.text, .strtab, .text, .symtab, .comment |
True |
True |
| 220 |
nwc24-volatile |
src/system/iplNwc24Manager.cpp:936 |
volatile cast |
restored |
- *(volatile const NWC24DlId*)&DL_ID_0, | - *(volatile const NWC24DlId*)&DL_ID_1, | - *(volatile const NWC24DlId*)&DL_ID_5, | - *(volatile const NWC24DlId*)&DL_ID_6, | + DL_ID_0, | + DL_ID_1, | + DL_ID_5, | + DL_ID_6, | - *(volatile const u16*)&DL_INTERVAL_0, | - *(volatile const u16*)&DL_INTERVAL_1, | - *(volatile const u16*)&DL_INTERVAL_2, | - *(volatile const u16*)&DL_INTERVAL_3, | + DL_INTERVAL_0, | + DL_INTERVAL_1, | + DL_INTERVAL_2, | + DL_INTERVAL_3, | - *(volatile const u8*)&DL_PRIORITY_0, | - *(volatile const u8*)&DL_PRIORITY_1, | - *(volatile const u8*)&DL_PRIORITY_2, | - *(volatile const u8*)&DL_PRIORITY_3, | + DL_PRIORITY_0, | + DL_PRIORITY_1, | + DL_PRIORITY_2, | + DL_PRIORITY_3, |
10252 -> 10252 |
888 -> 888 |
|
.rela.text, .strtab, .symtab, .comment, .rela.data |
True |
True |
| 221 |
wd-volatile |
libs/RevoEX/src/wd/WDScan.c:34 |
volatile cast |
restored |
- #define scRsnOui0 (*((volatile const u8*)&scRsnOui0)) | - #define scRsnOui1 (*((volatile const u8*)&scRsnOui1)) | - #define scRsnOui2 (*((volatile const u8*)&scRsnOui2)) | - #define scWpaOui0 (*((volatile const u8*)&scWpaOui0)) | - #define scWpaOui1 (*((volatile const u8*)&scWpaOui1)) | - #define scWpaOui2 (*((volatile const u8*)&scWpaOui2)) | - #define scWpaFindOui0 (*((volatile const u8*)&scWpaFindOui0)) | - #define scWpaFindOui1 (*((volatile const u8*)&scWpaFindOui1)) | - #define scWpaFindOui2 (*((volatile const u8*)&scWpaFindOui2)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 75.36522% |
.rela.text, .text, .symtab |
True |
True |
| 222 |
url-data-padding |
src/scene/board/iplUrlProcessor.cpp:246 |
targeted source cleanup |
restored |
- namespace ipl { | - namespace scene { | - __declspec(weak) u32 url_processor_data_pad() { | - static const u32 pad __attribute__((section(".data"), aligned(1))) = 0; | - return *((volatile const u32*)&pad); | - } | - } // namespace scene | - } // namespace ipl |
2488 -> 2488 |
48 -> 24 |
|
.rela.text, .data, .strtab, .text, .symtab, .comment, .rela.data |
True |
True |
| 223 |
calendar-data-padding |
src/scene/calendar/iplCalendar.cpp:882 |
targeted source cleanup |
restored |
- static const f32 pad0 __attribute__((section(".data"), aligned(1), used)) = 0.0f; |
7452 -> 7452 |
1244 -> 516 |
|
.rela.text, .data, .strtab, .symtab, .comment, .rela.data |
True |
True |
| 224 |
date-data-padding |
src/scene/calendar/iplDate.cpp:65 |
targeted source cleanup |
restored |
- u8 padding[0x10]; | - DECOMP_FORCE_ACTIVE(iplDate_cpp, padding); |
2868 -> 2868 |
356 -> 356 |
|
.rela.text, .strtab, .text, .symtab, .comment, .rela.data |
True |
True |
| 225 |
wpad-data-padding |
libs/RVL_SDK/src/wpad/WPAD.c:790 |
targeted source cleanup |
restored |
- static u8 FAKE_ALIGNMENT[0x10]; | - DECOMP_FORCE_ACTIVE(WPAD_c, _dev_handle_index, FAKE_ALIGNMENT); | + DECOMP_FORCE_ACTIVE(WPAD_c, _dev_handle_index); |
31040 -> 30512 |
15096 -> 15096 |
WPADiInitSub 100% -> 99.992424% |
.rela.sdata, .rela.text, .strtab, .text, .symtab, .comment, .rela.data |
True |
True |
| 226 |
chanedit-fake-constructor |
src/scene/channelEdit/iplChanAppEdit.cpp:31 |
targeted source cleanup |
restored |
- // TODO: Figure out what this might've been/why it isn't inlining | - void CHANAPPEDIT_dummyFunctionToKeepAConstructorStuffFromInlining(nw4r::math::VEC3& vec) { | - math::VEC3 end(vec); | - } |
6696 -> 6696 |
1392 -> 1392 |
|
.rela.text, .strtab, .text, .symtab, .comment, .rela.data |
True |
True |
| 227 |
numeric-key-reference |
src/keyboard/tiCellPhone.cpp:178 |
targeted source cleanup |
restored |
- struct NumericKeyView { | - const PaneNameToCharCode& key; | - NumericKeyView(const KeySet& set, u16 index) : key(set.pPaneNameToCharCode[index]) {} | - bool matches(const char* paneName) const { return util::strcmp(key.szPaneName, paneName); } | - wchar_t character() const { return key.wc[0]; } | - }; | - const NumericKeyView key(csKeySetNumber, index); | - if (key.matches(paneName)) { | - wchar_t character = key.character(); | + const PaneNameToCharCode& key = csKeySetNumber.pPaneNameToCharCode[index]; | + if (util::strcmp(key.szPaneName, paneName)) { | + wchar_t character = key.wc[0]; |
19028 -> 16300 |
3860 -> 3860 |
onKey__Q49textinput8keyboard13cellphonetype4BaseFUlPv 100% -> 99.98534% |
.strtab, .text |
True |
True |
| 228 |
numeric-key-pointer |
src/keyboard/tiCellPhone.cpp:178 |
targeted source cleanup |
restored |
- struct NumericKeyView { | - const PaneNameToCharCode& key; | - NumericKeyView(const KeySet& set, u16 index) : key(set.pPaneNameToCharCode[index]) {} | - bool matches(const char* paneName) const { return util::strcmp(key.szPaneName, paneName); } | - wchar_t character() const { return key.wc[0]; } | - }; | - const NumericKeyView key(csKeySetNumber, index); | - if (key.matches(paneName)) { | - wchar_t character = key.character(); | + const PaneNameToCharCode* key = &csKeySetNumber.pPaneNameToCharCode[index]; | + if (util::strcmp(key->szPaneName, paneName)) { | + wchar_t character = key->wc[0]; |
19028 -> 16300 |
3860 -> 3860 |
onKey__Q49textinput8keyboard13cellphonetype4BaseFUlPv 100% -> 99.98534% |
.strtab, .text |
True |
True |
| 229 |
numeric-key-indexed |
src/keyboard/tiCellPhone.cpp:178 |
targeted source cleanup |
restored |
- struct NumericKeyView { | - const PaneNameToCharCode& key; | - NumericKeyView(const KeySet& set, u16 index) : key(set.pPaneNameToCharCode[index]) {} | - bool matches(const char* paneName) const { return util::strcmp(key.szPaneName, paneName); } | - wchar_t character() const { return key.wc[0]; } | - }; | - const NumericKeyView key(csKeySetNumber, index); | - if (key.matches(paneName)) { | - wchar_t character = key.character(); | + if (util::strcmp(csKeySetNumber.pPaneNameToCharCode[index].szPaneName, paneName)) { | + wchar_t character = csKeySetNumber.pPaneNameToCharCode[index].wc[0]; |
19028 -> 19028 |
3860 -> 3860 |
|
.strtab |
True |
True |
| 230 |
cell-input-keys-helper |
src/keyboard/tiCellPhone.cpp:174 |
targeted source cleanup |
restored |
- static inline const PaneNameToCharCode* inputKeys(const LanguageDependencyData* table, u32 mode) { | - return table->keySets[mode]->pPaneNameToCharCode; | - } | - const PaneNameToCharCode* currentKeys = inputKeys(static_cast<const LanguageDependencyData*>(mpInputModeTable), mCurrentInputMode); | + const PaneNameToCharCode* currentKeys = static_cast<const LanguageDependencyData*>(mpInputModeTable)->keySets[mCurrentInputMode]->pPaneNameToCharCode; |
19028 -> 16300 |
3860 -> 3860 |
onKey__Q49textinput8keyboard13cellphonetype4BaseFUlPv 100% -> 99.95601% |
.strtab, .text |
True |
True |
| 231 |
vm-status-width |
src/channelScript/CHANSVm.c:7104 |
targeted source cleanup |
restored |
+ u32 immediateSize; | - result = 1; | + immediateSize = 1; | - result = 2; | + immediateSize = 2; | - result = 4; | + immediateSize = 4; | - result = 8; | + immediateSize = 8; | - opSize = result + 1; | + opSize = immediateSize + 1; | - result = VmLoadImmInteger(vm, &pVm->accumulator, operandBuf, result); | + result = VmLoadImmInteger(vm, &pVm->accumulator, operandBuf, immediateSize); |
44588 -> 44588 |
6904 -> 6904 |
|
.strtab |
True |
True |
| 232 |
aoss-wait-union |
src/scene/setting/AOSS.c:428 |
targeted source cleanup |
restored |
- u16 defaultConnection; | - u16 defaultResponse; | - union { | - struct { s16 connection; s16 response; } limits; | - struct { u16 connection; u16 response; } defaults; | - } waitIntervals; | + s16 connectionWait; | + s16 responseWait; | - defaultConnection = s_defaultOptions[0]; | - defaultResponse = s_defaultOptions[1]; | - waitIntervals.defaults.connection = defaultConnection; | - waitIntervals.defaults.response = defaultResponse; | - waitIntervals.limits.connection = input->options[0]; | - if (waitIntervals.limits.connection == -1) { | - waitIntervals.limits.connection = 10; | + connectionWait = input->options[0]; | + if (connectionWait == -1) { | + connectionWait = 10; | - waitIntervals.limits.response = input->options[1]; | - if (waitIntervals.limits.response == -1) { | - waitIntervals.limits.response = 100; | + responseWait = input->options[1]; | + if (responseWait == -1) { | + responseWait = 100; | - initialWait = waitIntervals.limits.connection; | + initialWait = connectionWait; | - remainingWait = waitIntervals.limits.response; | + remainingWait = responseWait; | - initialWait = waitIntervals.limits.connection; | + initialWait = connectionWait; | - remainingWait = (u16)waitIntervals.limits.response; | + remainingWait = (u16)responseWait; | - if (attemptCount == waitIntervals.limits.connection) { | + if (attemptCount == connectionWait) { | - initialWait = waitInterval [see trial candidate in /tmp/rx56/trials] |
7720 -> 7720 |
3928 -> 3920 |
AOSS_Init_old 96.18624% -> 95.2601% |
.comment, .rela.data, .rela.text, .sdata2, .shstrtab, .strtab, .symtab, .text |
True |
True |
| 233 |
cx-volatile-raw-field |
libs/RVL_SDK/src/cx/CXStreamingUncompression.c:362 |
volatile cast |
restored |
- int c = (*(vu8*)context->decodeTable << currBit) & 0x80; // ? | + int c = (context->decodeTable->raw << currBit) & 0x80; // ? |
2684 -> 1772 |
0 -> 0 |
CXReadUncompHuffman 100% -> 96.53509% |
.symtab, .text |
True |
True |
| 234 |
mbox-plain-locals |
libs/RevoEX/src/nwc24/NWC24MBoxCtrl.c:558 |
targeted source cleanup |
restored |
- static inline void GetOldestMsgId(const MBCHeader* header, volatile u32* id) { | - *id = header->oldestId; | - } | - struct { | - volatile u32 oldestId; | - MBCHeader* header; | - } mailbox; | + MBCHeader* header; | + u32 oldestId; | - err = GetCachedMBCHeader(type, &mailbox.header); | + err = GetCachedMBCHeader(type, &header); | - if (mailbox.header->numMessages >= mailbox.header->capacity) | + if (header->numMessages >= header->capacity) | - if (mailbox.header->freeBytes <= required) | + if (header->freeBytes <= required) | - while (mailbox.header->numMessages >= mailbox.header->capacity || mailbox.header->freeBytes <= required) { | - GetOldestMsgId(mailbox.header, &mailbox.oldestId); | - err = DeleteMsg(type, mailbox.oldestId, FALSE); | + while (header->numMessages >= header->capacity || header->freeBytes <= required) { | + oldestId = header->oldestId; | + err = DeleteMsg(type, oldestId, FALSE); | - err = GetCachedMBCHeader(type, &mailbox.header); | + err = GetCachedMBCHeader(type, &header); |
10604 -> 10332 |
192 -> 192 |
NWC24iMBoxCheck 100% -> 96.92647% |
.rela.text, .strtab, .symtab, .text |
True |
True |
| 235 |
ncd-interrupt-scope |
libs/RevoEX/src/ncd/ncdsystem.c:55 |
targeted source cleanup |
restored |
- union { | - BOOL enabled; | - NCDConfig* config; | - } state; | + NCDConfig* config; | - state.enabled = OSDisableInterrupts(); | + { | + BOOL enabled = OSDisableInterrupts(); | - OSRestoreInterrupts(state.enabled); | + OSRestoreInterrupts(enabled); | + } | - state.config = ncdCommonBuffer; | + config = ncdCommonBuffer; | - state.config->selectedMedia = 0; | + config->selectedMedia = 0; | - state.config->selectedMedia = ifConfig->selectedMedia; | - profile = state.config->profiles; | + config->selectedMedia = ifConfig->selectedMedia; | + profile = config->profiles; | - state.config->linkTimeout = ifConfig->linkTimeout; | + config->linkTimeout = ifConfig->linkTimeout; | - if (state.config->profiles[i].flags & 0x80) { | + if (config->profiles[i].flags & 0x80) { | - state.config->profiles[i].flags &= ~1; | + config->profiles[i].flags &= ~1; | - state.config->profiles[i].flags |= 1; | + config->profiles[i].flags |= 1; | - state.config->profiles[0].flags |= 0x80; | + config->profiles[0].flags |= 0x80; | - state.config->profiles[0].flags &= ~1; | - memcpy(&state.config->profiles[0].netif.wireless, &ifConfig->netif, 0x15c); | + config->profiles[0].flags &= ~1; | + memcpy(&config->profiles[0].netif.wireless, &ifConfig->netif, 0x15c); | - state.config->profiles[0].flags |= 1; | - memcpy(&state.config->profiles[0].netif.wired, &ifConfig->netif, 4); | + config->profiles[0].flags |= 1; | [see trial candidate in /tmp/rx56/trials] |
4180 -> 3560 |
496 -> 496 |
NCDSetIfConfig 100% -> 99.935486% |
.strtab, .text |
True |
True |
| 236 |
kpr-alignment-carrier |
libs/RVL_SDK/src/kpr/kpr_lib.c:159 |
targeted source cleanup |
restored |
- static union { u64 align; u8 flag; } once; | - if (!once.flag) { | + static u8 once; | + if (!once) { | - once.flag = TRUE; | + once = TRUE; |
1536 -> 1536 |
1104 -> 1088 |
|
.comment, .sbss, .symtab |
True |
True |
| 237 |
nhttp-unused-once |
libs/RevoEX/src/nhttp/d_nhttp.c:664 |
targeted source cleanup |
restored |
- { | - static s32 debugSet; | - if (debugSet == 0) | - { | - debugSet = 1; | - } | - } |
3180 -> 3180 |
720 -> 720 |
|
.comment, .rela.text, .sbss, .strtab, .symtab, .text |
True |
True |
| 238 |
egg-thunk-carrier |
libs/EGG/src/core/eggAudioExpMgr.cpp:33 |
targeted source cleanup |
restored |
- ExpAudioMgr::ExpAudioMgr() { | - } | - ExpAudioMgr::~ExpAudioMgr() { | - } |
524 -> 524 |
120 -> 120 |
|
.comment, .data, .rela.data, .rela.text, .strtab, .symtab, .text |
True |
True |
| 239 |
whitespace-NANDCore |
libs/RVL_SDK/src/nand/NANDCore.c:58 |
targeted source cleanup |
kept |
|
4472 -> 4472 |
800 -> 800 |
|
|
True |
True |
| 240 |
whitespace-tiDebug |
src/keyboard/tiDebug.cpp:113 |
targeted source cleanup |
kept |
|
1556 -> 1556 |
24 -> 24 |
|
|
True |
True |
| 241 |
whitespace-rvl_dec |
src/system/rvl_dec.c:643 |
targeted source cleanup |
kept |
|
2600 -> 2600 |
36872 -> 36872 |
|
|
True |
True |
| 242 |
force-macros-0 |
libs/RVL_SDK/src/axfx/AXFXReverbHiExp.c:374 |
force-retention macro |
restored |
- DECOMP_FORCE_LITERAL(AXFXReverbHiExp_c, -3.0f, 10.0); |
3892 -> 3892 |
480 -> 416 |
|
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 243 |
force-macros-1 |
libs/RVL_SDK/src/axfx/AXFXReverbHiExpDpl2.c:388 |
force-retention macro |
restored |
- DECOMP_FORCE_LITERAL(AXFXReverbHiExpDpl2_c, -3.0f, 10.0); |
4096 -> 4096 |
512 -> 448 |
|
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 244 |
force-macros-2 |
libs/RVL_SDK/src/cnt/cnt.c:14 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(cnt_c, "<< RVL_SDK - CNT \trelease build: Apr 20 2010 11:21:37 (0x4199_60831) >>"); | - DECOMP_FORCE_ACTIVE(cnt_c, "/content%d"); | - DECOMP_FORCE_ACTIVE(cnt_c, "Warning: CNTInitHandle(): directory '%s' is not found under '/'\n"); |
2228 -> 1892 |
888 -> 632 |
__CNTConvertErrorCode 100% -> 99.96429% |
.comment, .data, .rela.text, .strtab, .symtab, .text |
False |
False |
| 245 |
force-macros-3 |
libs/RVL_SDK/src/dvd/dvd_broadway.c:102 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(dvd_broadway_c, dvdContexts); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "(doCoverCallback) Error - context mangled!\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, coverStatus); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, coverRegister); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "DVDLowOpenPartitionWithTmdAndTicket"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "(%s) eTicket memory is unaligned\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "(%s) tmd parameter cannot be NULL\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "(%s) tmd memory is unaligned\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "(%s) eTicket parameter cannot be NULL\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "DVDLowNoDiscOpenPartition"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "@@@ (DVDLowWaitForCoverClose) IOS_IoctlAsync returned error: %d\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "@@@ (DVDLowInquiry) IOS_IoctlAsync returned error: %d\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "@@@ (DVDLowRequestError) IOS_IoctlAsync returned error: %d\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "(DVDLowSetSpinupFlag): Synch functions can't be called in callbacks\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "@@@ (DVDLowNotifyReset) IOS_IoctlAsync returned error: %d\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "@@@ (DVDLowReset) IOS_IoctlAsync returned error: %d\n"); | - DECOMP_FORCE_ACTIVE(dvd_broadway_c, "(DVDLowGe [see trial candidate in /tmp/rx56/trials] |
8900 -> 540 |
4248 -> 56 |
DVDLowOpenPartitionWithTmdAndTicketView 100% -> 99.90849%; DVDLowSeek 100% -> 99.95789%; DVDLowClosePartition 100% -> 99.955055%; DVDLowUnencryptedRead 100% -> 99.960396%; DVDLowClearCoverInterrupt 100% -> 99.955055%; DVDLowInquiry 100% -> 99.95556%; DVDLowGetNoDiscOpenPartitionParams 100% -> 99.945786%; DVDLowPrepareCoverRegister 100% -> 99.95556%; DVDLowAudioBufferConfig 100% -> 99.960396%; DVDLowReset 100% -> 99.95789%; DVDLowRequestError 100% -> 99.95556%; DVDLowGetNoDiscBufferSizes 100% -> 99.91603%; DVDLowReadDiskID 100% -> 99.94898%; DVDLowOpenPartition 100% -> 99.94156%; DVDLowPrepareStatusRegister 100% -> 99.95556%; DVDLowInit 100% -> 99.94118%; DVDLowStopMotor 100% -> 99.960396%; DVDLowSetMaximumRotation 100% -> 99.958336%; DVDLowRead 100% -> 99.953705% |
.bss, .comment, .data, .rela.text, .strtab, .symtab, .text |
False |
False |
| 246 |
force-macros-4 |
libs/RVL_SDK/src/ipc/ipcProfile.c:16 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(ipcProfile_c, IpcFdArray); // Force `IpcFdArray` to be first |
452 -> 452 |
264 -> 264 |
|
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 247 |
force-macros-5 |
libs/RVL_SDK/src/os/OSExec.c:22 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(OSExec_c, "\nOSExec(): Failed to exec %d in %d\n"); | - DECOMP_FORCE_ACTIVE(OSExec_c, "\nOSExec(): The specified game doesn't exist in the disc\n"); | - DECOMP_FORCE_ACTIVE(OSExec_c, "OSLaunchDisk(): You can't call this API from DVD application. \n"); | - DECOMP_FORCE_ACTIVE(OSExec_c, "OSLaunchDisk(): You must call DVDPrepareDisk before launching disc.\n"); | - DECOMP_FORCE_ACTIVE(OSExec_c, "OSLaunchDisk(): Specified id is different from one specified to DVDPrepareDisk.\n"); | - DECOMP_FORCE_ACTIVE(OSExec_c, "0000000000000000"); | - DECOMP_FORCE_ACTIVE(OSExec_c, "2004/02/01"); | - DECOMP_FORCE_ACTIVE(OSExec_c, "OSLaunchPartition(): You can't call this API from NAND application. \n"); | - DECOMP_FORCE_ACTIVE(OSExec_c, "OSLaunchPartition(): Specified title ID is not DISC application. \n"); |
3476 -> 2284 |
864 -> 16 |
LaunchCommon 100% -> 99.98322% |
.comment, .data, .rela.text, .strtab, .symtab, .text |
False |
False |
| 248 |
force-macros-6 |
libs/RVL_SDK/src/os/OSNet.c:41 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(OSNet_c, "NWC24iPrepareShutdown"); | - DECOMP_FORCE_ACTIVE(OSNet_c, "/dev/net/kd/request"); | - DECOMP_FORCE_ACTIVE(OSNet_c, "NWC24SuspendScheduler"); | - DECOMP_FORCE_ACTIVE(OSNet_c, "NWC24ResumeScheduler"); | - DECOMP_FORCE_ACTIVE(OSNet_c, "NWC24iRequestShutdown"); | - DECOMP_FORCE_ACTIVE(OSNet_c, "NWC24Shutdown_: Give up!\n"); // Give up! | - DECOMP_FORCE_ACTIVE(OSNet_c, "NWC24iSetRtcCounter_"); | - DECOMP_FORCE_ACTIVE(OSNet_c, "/dev/net/kd/time"); |
188 -> 188 |
360 -> 0 |
|
.comment, .data, .rela.text, .strtab, .symtab, .text |
False |
False |
| 249 |
force-macros-7 |
libs/RVL_SDK/src/os/OSPlayRecord.c:13 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(OSPlayRecord_c, PlayRecord); |
2288 -> 2288 |
624 -> 624 |
|
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 250 |
force-macros-8 |
libs/RVL_SDK/src/os/OSReset.c:66 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(OSReset_c, "OSReset.c"); | - DECOMP_FORCE_ACTIVE(OSReset_c, "__OSHotReset(): Falied to reset system.\n"); | - DECOMP_FORCE_ACTIVE(OSReset_c, "OSReturnToMenu(): Falied to boot system menu.\n"); | - DECOMP_FORCE_ACTIVE(OSReset_c, "OSReturnToDataManager(): Falied to boot system menu.\n"); | - DECOMP_FORCE_ACTIVE(OSReset_c, "OSResetSystem() is obsoleted. It doesn't work any longer.\n"); | - DECOMP_FORCE_ACTIVE(OSReset_c, "OSSetBootDol() is obsoleted. It doesn't work any longer.\n"); |
1308 -> 956 |
672 -> 24 |
__OSReturnToMenuForError 100% -> 99.902435%; OSReturnToSetting 100% -> 99.80851% |
.comment, .data, .rela.data, .rela.text, .strtab, .symtab, .text |
False |
False |
| 251 |
force-macros-9 |
libs/RVL_SDK/src/os/OSThread.c:863 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(OSThread_c, IdleThread); // IdleThread is unused but linked anyway. |
8232 -> 8232 |
4656 -> 2088 |
|
.bss, .comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 252 |
force-macros-10 |
libs/RVL_SDK/src/usb/usb.c:216 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(usb_c, "OpenDevice\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "OpenDeviceIdsAsync: Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "CloseDevice\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "CloseDevice returned: %d\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "openDevice: Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "getDeviceList: Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "CloseDeviceAsync: Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "openDevice: Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "getDeviceList: Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "getDeviceList: Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "__IntrBlkMsgInt: Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "intr/blk ioctl returned: %d\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "IntBlkMsgInt (async): Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "intrblkmsg: cb = 0x%x cbArg = 0x%x\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "ctrlmsg: bad data buffer\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "Ctrl Msg: Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "CtrlMsgInt (async): Not enough memory\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "ctrlmsgint: cb = 0x%x cbArg = 0x%x\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "Ctrl Msg async returned: %d\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "GetStrCb returned: %d\n"); | - DECOMP_FORCE_ACTIVE(usb_c, "GetStrCb: buf = 0x%x buflen = %u\n" [see trial candidate in /tmp/rx56/trials] |
4396 -> 1832 |
1712 -> 32 |
__IntrBlkMsgInt 100% -> 99.980675%; __CtrlMsgInt 100% -> 99.98615%; IUSB_CloseDeviceAsync 100% -> 99.9589% |
.comment, .data, .rela.text, .strtab, .symtab, .text |
False |
False |
| 253 |
force-macros-11 |
libs/RVL_SDK/src/wpad/WPAD.c:791 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(WPAD_c, _dev_handle_index, FAKE_ALIGNMENT); |
31040 -> 30512 |
15096 -> 15096 |
WPADiInitSub 100% -> 99.992424% |
.bss, .comment, .rela.data, .rela.sdata, .rela.text, .strtab, .symtab, .text |
True |
True |
| 254 |
force-macros-12 |
libs/RVL_SDK/src/wud/WUD.c:1057 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(WUD_c, "name : %s\n") | - DECOMP_FORCE_ACTIVE(WUD_c1, "WUDStartSyncSpDevice()\n"); | - DECOMP_FORCE_ACTIVE(WUD_c2, "WUDCancelSyncDevice()\n"); | - DECOMP_FORCE_ACTIVE(WUD_c3, "WUDiCancelSync()\n"); | - DECOMP_FORCE_ACTIVE(WUD_c4, "_WUDEnableTestMode\n") | - DECOMP_FORCE_ACTIVE(WUD_c5, "_WUDStartSyncDevice()\n") | - DECOMP_FORCE_ACTIVE(WUD_c6, "_WUDDeleteStoreDevice()\n") | - DECOMP_FORCE_ACTIVE(WUD_c7, "dev number = %d\n") | - DECOMP_FORCE_ACTIVE(WUD_c8, "Nintendo RVL-WBC") |
18852 -> 14420 |
12016 -> 8152 |
WUDSecurityCallback 100% -> 99.935486%; WUDStoredLinkKeyCallback 100% -> 99.93048%; WUDVendorSpecificCallback 100% -> 99.96135%; WUDiRemoveDevice 100% -> 99.93104%; WUDPowerManagerCallback 100% -> 99.93671%; WUDSearchCallback 100% -> 99.9542%; WUDiRegisterDevice 100% -> 99.97369% |
.comment, .data, .rela.data, .rela.text, .strtab, .symtab, .text |
False |
False |
| 255 |
force-macros-13 |
libs/RevoEX/src/cdb/CDBConv.c:134 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(CDBConv_c, "%08X"); | - DECOMP_FORCE_ACTIVE(CDBConv_c, "%04d%02d%02d"); |
4676 -> 3984 |
232 -> 0 |
CDBConvKeyStrToFullPath_ 100% -> 99.98266% |
.comment, .data, .rela.data, .rela.text, .sdata, .strtab, .symtab, .text |
False |
False |
| 256 |
force-macros-14 |
libs/RevoEX/src/cdb/CDBFileSystem.c:14 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "NANDCreateDir %s\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "NANDCreateDir() error = %d\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "NANDPrivateGetStatus %s = %d\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "ownerId=%u, groupId=%u, attribute=%u, permission="); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "(other-group-owner)\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "nocopy/cdbwiiid.dat"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "VFMountDriveNANDFlashEx VFErr=%d(%s)\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "home=%s\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "VFCreateSystemFileNANDFlashEx DEVErr=%d\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "VFMountDriveNANDFlashEx VFErr=%d\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "VFFormatDrive VFErr=%d\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "VFMountDriveNANDFlashEx %s->%s succeeded\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "VFChangeDir %s %s\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "NANDPrivateDelete %s-->\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "NANDPrivateDelete=%d\n"); | - DECOMP_FORCE_ACTIVE(CDBFileSystem_c, "<--NANDPrivateDelete\n"); |
1672 -> 656 |
952 -> 152 |
CDBFSInit 100% -> 99.94095% |
.comment, .data, .rela.text, .strtab, .symtab, .text |
False |
False |
| 257 |
force-macros-15 |
libs/RevoEX/src/cdb/CDBFileSystemSD.c:287 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(CDBFileSystem_c, CDB_SD_VFF_FILE_NAME); // Unused but linked |
2072 -> 2072 |
616 -> 616 |
|
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 258 |
force-macros-16 |
src/channelScript/systemmenu/iplCSMtx.cpp:9 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(iplCSMtx_cpp, "MTX34"); |
1492 -> 1492 |
232 -> 72 |
|
.comment, .rela.rodata, .rela.text, .sdata, .strtab, .symtab, .text |
True |
True |
| 259 |
force-macros-17 |
src/channelScript/systemmenu/iplCSSavedata.cpp:622 |
force-retention macro |
restored |
- DECOMP_FORCE_LITERAL(iplCSSavedata_cpp, util::get_int<COMPRESSION_LZ>) | - DECOMP_FORCE_LITERAL(iplCSSavedata_cpp, util::get_int<COMPRESSION_HUFFMAN>) | - DECOMP_FORCE_LITERAL(iplCSSavedata_cpp, util::get_int<COMPRESSION_RL>) |
5836 -> 5836 |
512 -> 512 |
|
.comment, .rela.rodata, .rela.text, .strtab, .symtab, .text |
True |
True |
| 260 |
force-macros-18 |
src/keyboard/tiDebug.cpp:15 |
force-retention macro |
restored |
- DECOMP_FORCE_LITERAL(tiDebug_cpp, 0.0f); |
1556 -> 1556 |
24 -> 24 |
|
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 261 |
force-macros-19 |
src/keyboard/tiPredictLang.cpp:518 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(tiPredictLang_cpp, (((CommandSender*)(NULL))->updateFromReceiver(0, NULL), 0)) |
5536 -> 5536 |
2300 -> 2300 |
|
.comment, .rela.data, .rela.text, .strtab, .symtab, .text |
True |
True |
| 262 |
force-macros-20 |
src/scene/board/iplFocusObject.cpp:1246 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(iplFocusObject_cpp, L".html"); | - DECOMP_FORCE_ACTIVE(iplFocusObject_cpp, L".htm"); | - DECOMP_FORCE_ACTIVE(iplFocusObject_cpp, L".shtml"); | - DECOMP_FORCE_ACTIVE(iplFocusObject_cpp, L".shtm"); | - DECOMP_FORCE_ACTIVE(iplFocusObject_cpp, L".cgi"); | - DECOMP_FORCE_ACTIVE(iplFocusObject_cpp, L".php"); | - DECOMP_FORCE_ACTIVE(iplFocusObject_cpp, L".asp"); | - DECOMP_FORCE_ACTIVE(iplFocusObject_cpp, L".jsp"); |
20332 -> 19488 |
2576 -> 232 |
onEventDerived__Q33ipl5scene12button_eventFUlUlPCQ33ipl10controller9Interface 100% -> 99.98578% |
.comment, .data, .rela.data, .rela.rodata, .rela.text, .strtab, .symtab, .text |
True |
True |
| 263 |
force-macros-21 |
src/scene/calendar/iplDate.cpp:67 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(iplDate_cpp, padding); |
2868 -> 2868 |
356 -> 356 |
|
.comment, .rela.data, .rela.text, .strtab, .symtab, .text |
True |
True |
| 264 |
force-macros-22 |
src/scene/sdButton/iplSDMenuButton.cpp:26 |
force-retention macro |
restored |
- DECOMP_FORCE_LITERAL(iplSDMenuButton_cpp, -152.0f); |
3120 -> 3120 |
560 -> 560 |
|
.comment, .rela.data, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 265 |
force-macros-23 |
src/scene/setting/iplParental.cpp:327 |
force-retention macro |
restored |
- DECOMP_FORCE_ACTIVE(iplParental_cpp, "flags:%d\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "rating:%d\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "password:%s\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "secretQuestion:%d\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "secretAnswer:%s\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "secretAnswerLength:%d\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "net contents restrictions:%02x\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "www channel restriction :%d\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "requestNum:%s\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "masterkey:%s\n"); | - DECOMP_FORCE_ACTIVE(iplParental_cpp, "country: %d\n"); |
2376 -> 2376 |
1576 -> 1240 |
|
.comment, .data, .rela.text, .strtab, .symtab, .text |
False |
False |
| 266 |
egg-unused-constructors |
libs/EGG/src/core/eggAudioExpMgr.cpp:13 |
targeted source cleanup |
restored |
- // auto generates constructors | - SimpleAudioMgrArg unused0; | - AudioFxMgr::AudioFxMgrArg unused1; |
524 -> 452 |
120 -> 120 |
__ct__Q33EGG20SimpleAudioMgrWithFx9ArgWithFxFv 100% -> 77.44444% |
.rela.text, .symtab, .text |
True |
True |
| 267 |
board-carrier-types |
src/scene/board/iplBoard.cpp:432 |
targeted source cleanup |
restored |
- struct RecordReadState { | - BOOL recordInterrupts; | - u32 dataSize; | - BOOL waitInterrupts; | - BOOL slotInterrupts; | - int recordSecond; | - int recordMin; | - int recordHour; | - u32 recordGC; | - CDBId cdbId; | - char recordType[8]; | - utility::Date recordDate; | - CDBRecordKey recordKey; | - } state; | - state.recordGC = 0; | + u32 dataSize; | + BOOL slotInterrupts; | + BOOL waitInterrupts; | + BOOL recordInterrupts; | + int recordSecond; | + int recordMin; | + int recordHour; | + u32 recordGC; | + CDBId cdbId; | + char recordType[8]; | + utility::Date recordDate; | + CDBRecordKey recordKey; | + recordGC = 0; | - state.recordType[0] = 0; | - state.recordType[1] = 0; | - state.recordType[2] = 0; | - state.recordType[3] = 0; | - state.recordType[4] = 0; | - state.recordType[5] = 0; | - state.recordType[6] = 0; | - state.recordType[7] = 0; | + recordType[0] = 0; | + recordType[1] = 0; | + recordType[2] = 0; | + recordType[3] = 0; | + recordType[4] = 0; | + recordType[5] = 0; | + recordType[6] = 0; | + recordType[7] = 0; | - CDBRecordGetCalendarTimeForce(record, &state.recordDate.year, &state.recordDate.month, &state.recordDate.day, | - &state.recordHour, &state.recordMin, &state.recordSecond); | - CDBRecordGetKeyForce(record, &state.recordKey); | - CDBRecordGetTypeForce(record, state.recordType); | - CDBRecordGetGameCodeForce(record, (char*)&state.recordGC); | + CDBReco [see trial candidate in /tmp/rx56/trials] |
20276 -> 19144 |
896 -> 896 |
appendRecord__Q33ipl5scene5BoardFP10_CDBRecord 100% -> 97.837456% |
.strtab, .text |
True |
True |
| 268 |
aoss-integrity-scope |
src/scene/setting/AOSS.c:1854 |
targeted source cleanup |
compile rejected |
- struct { u32 expected; u32 actual; } integrity; | + u32 expectedChecksum; | - integrity.expected = message->checksum; | + expectedChecksum = message->checksum; | - integrity.actual = 0xffffffff; | + u32 actualChecksum = 0xffffffff; | - integrity.actual = (integrity.actual >> 8) ^ s_crcTable[(integrity.actual ^ decryptedData[crcIndex]) & 0xff]; | + actualChecksum = (actualChecksum >> 8) ^ s_crcTable[(actualChecksum ^ decryptedData[crcIndex]) & 0xff]; | - if (((integrity.actual ^ 0xffffffff) & 0xff) != integrity.expected) { | + if (((actualChecksum ^ 0xffffffff) & 0xff) != expectedChecksum) { |
|
|
|
|
not measured |
not measured |
| 269 |
cdb-epoch-reuse |
libs/RevoEX/src/cdb/CDBConv.c:349 |
targeted source cleanup |
restored |
- union { | - char storage[20]; | - struct { | - char prefix[8]; | - char value[12]; | - } epoch; | - } epochBuffer; | - strncpy(epochBuffer.epoch.value, CDBKeyStrEpoch(keyString), CDB_KEYSTR_EPOCH_SIZE); | - epochBuffer.epoch.value[CDB_KEYSTR_EPOCH_SIZE] = 0; | - sscanf(epochBuffer.epoch.value, "%ul", &epoch); | + strncpy(fileEpochStr, CDBKeyStrEpoch(keyString), CDB_KEYSTR_EPOCH_SIZE); | + fileEpochStr[CDB_KEYSTR_EPOCH_SIZE] = 0; | + sscanf(fileEpochStr, "%ul", &epoch); |
4676 -> 3984 |
232 -> 232 |
CDBConvKeyStrToFullPath_ 100% -> 99.93063% |
.strtab, .text |
True |
True |
| 270 |
cdb-decoded-scope |
libs/RevoEX/src/cdb/CDBDatabase.c:353 |
targeted source cleanup |
restored |
- struct { | + CDBDate date; | + char type[8]; | + CDBConvKeyStrToEpochValue(key, &date); | + if (conditions->beginDate > date || date > conditions->endDate) return CDB_ERROR_OK; | + if (conditions->makerCode != 0xFFFF) { | - u32 gameCode; | - CDBDate date; | - char type[8]; | - } decoded; | - CDBConvKeyStrToEpochValue(key, &decoded.date); | - if (conditions->beginDate > decoded.date || decoded.date > conditions->endDate) return CDB_ERROR_OK; | - if (conditions->makerCode != 0xFFFF) { | - CDBConvKeyStrToMakerCode(key, (u32*)&decoded.makerCode); | - if (conditions->makerCode != decoded.makerCode) return CDB_ERROR_OK; | + CDBConvKeyStrToMakerCode(key, (u32*)&makerCode); | + if (conditions->makerCode != makerCode) return CDB_ERROR_OK; | - CDBConvKeyStrToGameCode(key, &decoded.gameCode); | - if (conditions->gameCode != decoded.gameCode) return CDB_ERROR_OK; | + u32 gameCode; | + CDBConvKeyStrToGameCode(key, &gameCode); | + if (conditions->gameCode != gameCode) return CDB_ERROR_OK; | - CDBConvKeyStrToType(key, decoded.type); | - if (CDBCompareTypeStr(conditions->type, decoded.type)) return CDB_ERROR_OK; | + CDBConvKeyStrToType(key, type); | + if (CDBCompareTypeStr(conditions->type, type)) return CDB_ERROR_OK; |
12152 -> 11896 |
312 -> 312 |
CDBDatabaseSearchConditionsIsMatch 100% -> 99.96875% |
.text |
True |
True |
| 271 |
cdb-key-strings-semantic |
libs/RevoEX/src/cdb/CDBRecordKey.c:32 |
targeted source cleanup |
restored |
- struct { | - char mcStr[4]; | - char typeStr[8]; | - char gcStr[8]; | - } strings; | + char mcStr[4]; | + char gcStr[8]; | + char typeStr[8]; | - CDBConvMCValueToMCStr(makerCode, strings.mcStr); | - CDBConvGCValueToGCStr(gameCode, strings.gcStr); | + CDBConvMCValueToMCStr(makerCode, mcStr); | + CDBConvGCValueToGCStr(gameCode, gcStr); | - strcpy(strings.typeStr, fileType); | - CDBToLower(((char*)strings.typeStr), typeLength); | + strcpy(typeStr, fileType); | + CDBToLower(((char*)typeStr), typeLength); | - sprintf(recordKey->keyString, "%010u_%s_%s_%03d.%s", epoch, strings.gcStr, strings.mcStr, serialNumber, strings.typeStr); | + sprintf(recordKey->keyString, "%010u_%s_%s_%03d.%s", epoch, gcStr, mcStr, serialNumber, typeStr); |
2424 -> 2164 |
64 -> 64 |
CDBRecordKeyInit 100% -> 99.92308% |
.strtab, .text |
True |
True |
| 272 |
letter-identity-mutable |
src/scene/letterWriter/iplLetterWriter.cpp:17 |
targeted source cleanup |
restored |
- static inline wchar_t* letterWriterCaption(wchar_t* caption) { | - return caption; | - } | - const wchar_t* caption = letterWriterCaption(makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name)); | + wchar_t* caption = makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name); | - const wchar_t* caption = makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name); | + wchar_t* caption = makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name); |
6092 -> 5528 |
632 -> 632 |
initCalcNormal__Q33ipl5scene12LetterWriterFv 100% -> 99.92908% |
.strtab, .text |
True |
True |
| 273 |
letter-identity-assignment |
src/scene/letterWriter/iplLetterWriter.cpp:17 |
targeted source cleanup |
restored |
- static inline wchar_t* letterWriterCaption(wchar_t* caption) { | - return caption; | - } | - const wchar_t* caption = letterWriterCaption(makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name)); | + const wchar_t* caption; | + caption = makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name); | - const wchar_t* caption = makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name); | + const wchar_t* caption; | + caption = makeHeaderCaption((const wchar_t*)mFriendInfo.attr.name); |
6092 -> 5528 |
632 -> 632 |
initCalcNormal__Q33ipl5scene12LetterWriterFv 100% -> 99.92908% |
.strtab, .text |
True |
True |
| 274 |
nandsd-unused-path |
src/system/iplNandSDWorker.cpp:3168 |
targeted source cleanup |
restored |
- char unusedPath[NAND_MAX_PATH] = ""; |
51428 -> 49176 |
12312 -> 12312 |
do_copy_sd_save_to_nand__Q23ipl12NandSDWorkerFv 100% -> 97.30728% |
.comment, .debug, .line, .rela.data, .rela.debug, .rela.line, .rela.text, .strtab, .symtab, .text |
True |
True |
| 275 |
channel-unused-locals |
src/system/iplChannelScriptManager.cpp:156 |
targeted source cleanup |
restored |
- void* unused1 = heap1->getEndAddress(); | - void* unused2 = heap2->getEndAddress(); | + heap1->getEndAddress(); | + heap2->getEndAddress(); |
2148 -> 2076 |
1024 -> 1024 |
isValidAddr__Q33ipl7channel20ChannelScriptManagerFPv 100% -> 72.166664% |
.strtab, .text |
True |
True |
| 276 |
date-unused-local |
src/scene/calendar/iplDate.cpp:187 |
targeted source cleanup |
restored |
- int unused = con != NULL ? con->getChannel() : getLatestEventCtrlNo(); | + if (con != NULL) { | + con->getChannel(); | + } else { | + getLatestEventCtrlNo(); | + } |
2868 -> 2868 |
356 -> 356 |
|
.strtab |
True |
True |
| 277 |
asm-userid-clean |
libs/RevoEX/src/nwc24/NWC24UserId.c:56 |
assembly placeholder |
restored |
- static asm NWC24UserId getUnScrambleId(register NWC24UserId id) { | - li r9,-1 | - lis r7,0x20 | - lis r6,0x5e5e | - stwu r1,-0x20(r1) | - subi r7,r7,1 | - and r8,r4,r9 | - addi r0,r6,0x5e5e | - stw r31,0x1c(r1) | - and r3,r3,r7 | - lis r5,-1 | - xor r8,r8,r0 | - stw r30,0x18(r1) | - and r8,r8,r9 | - xori r3,r3,0x5e5e | - rlwinm r0,r8,0x15,0xa,0xa | - li r6,-0x100 | - and r3,r3,r7 | - rlwinm r8,r8,0x1f,0,0x1f | - or r3,r3,r0 | - stw r29,0x14(r1) | - rlwimi r8,r3,0x1f,0,0 | - lis r4,-0xff | - rlwinm r7,r3,0x1f,1,0x1f | - addi r5,r5,0xff | - rlwinm r30,r8,0x18,0,0x1f | - rlwinm r29,r3,0x17,0x18,0x1f | - and r12,r7,r9 | - li r0,0 | - rlwimi r30,r3,0x17,0,7 | - and r31,r8,r6 | - rlwimi r31,r30,0,0x18,0x1f | - rlwinm r11,r3,0x1f,0x10,0x17 | - and r30,r31,r5 | - and r12,r12,r9 | - rlwimi r0,r29,8,0x18,0x1f | - subi r4,r4,1 | - or r12,r12,r0 | - or r11,r30,r11 | - and r30,r11,r4 | - rlwinm r31,r8,0,0x18,0x1f | - li r0,0 | - rlwinm r11,r8,0x10,8,0xf | - lis r10,0x100 | - and r12,r12,r9 | - rlwimi r0,r31,0x10,0x10,0x1f | - or r30,r30,r11 | - or r29,r12,r0 | - rlwinm r12,r3,0x1f,0x18,0x1f | - subi r0,r10,1 | - li r10,0 | - rlwimi r10,r12,0x18,8,0x1f | - and r11,r29,r9 | - and r12,r30,r0 | - rlwinm r3,r3,0x17,0,7 | - or r3,r12,r3 | - or r12,r11,r10 | - and r10,r3,r9 | - lis r3,TtableInv@ha | - and r31,r10,r9 | - rlwinm r30,r8,0x10,0,0x1f | - rlwinm r11,r31,0x1c,0x1c,0x1f | - addi r3,r3, [see trial candidate in /tmp/rx56/trials] |
1032 -> 644 |
16 -> 16 |
|
.comment, .rela.text, .sdata2, .shstrtab, .strtab, .symtab, .text |
True |
True |
| 278 |
asm-cache-clear-clean |
libs/RVL_SDK/src/cntcache/cntcache.c:42 |
assembly placeholder |
restored |
- void CNTCACHEClear(); | + s32 CNTCACHEClear(); | - asm void CNTCACHEClear() { | - clrlwi r11, r1, 0x1b | - mr r12, r1 | - subfic r11, r11, -0x500 | - stwux r1, r1, r11 | - mflr r0 | - mr r11, r12 | - stw r0, 4(r12) | - bl _savegpr_23 | - lis r30, scCntCacheStrs@ha | - lis r3, _CNTCACHEMutex@ha | - addi r30, r30, scCntCacheStrs@l | - li r29, 0 | - addi r3, r3, _CNTCACHEMutex@l | - bl OSLockMutex | - addi r3, r30, 0x50 | - addi r4, r1, 0x24 | - li r27, 1 | - li r5, 3 | - bl NANDPrivateOpen | - cmpwi r3, -0xc | - mr r28, r3 | - bne L_d4 | - li r28, 0 | - b L_28c | - L_d4: | - cmpwi r3, 0 | - beq L_e0 | - b L_268 | - L_e0: | - addi r3, r1, 0x24 | - addi r4, r1, 0x20 | - bl NANDGetLength | - cmpwi r3, 0 | - mr r28, r3 | - beq L_fc | - b L_268 | - L_fc: | - li r26, 0 | - li r31, 0 | - b L_25c | - L_108: | - lwz r25, 0x20(r1) | - cmplwi r25, 0x400 | - ble L_118 | - li r25, 0x400 | - L_118: | - addi r24, r1, 0xc0 | - addi r0, r25, 0x1f | - addi r3, r1, 0x24 | - mr r4, r24 | - rlwinm r5, r0, 0, 0, 0x1a | - bl NANDRead | - cmpw r3, r25 | - beq L_140 | - li r28, -0x14b3 | - b L_268 | - L_140: | - mr r4, r24 | - li r28, 0 | - mtctr r25 | - cmplwi r25, 0 | - ble L_16c | - L_154: | - lbz r0, 0(r4) | - cmpwi r0, 0xa | - bne L_164 | - b L_170 | - L_164: | - addi r4, r4, 1 | - bdnz L_154 | - L_16c: | - li r4, 0 | - L_170: | - cmpwi r4, 0 | - bne L_224 | - li r28, 0 | - b L_268 | - b L_224 | - [see trial candidate in /tmp/rx56/trials] |
1828 -> 1224 |
280 -> 280 |
CNTCACHEClear 100% -> 69.13908% |
.comment, .data, .rela.sdata, .rela.text, .strtab, .symtab, .text |
False |
False |
| 279 |
asm-cache-removable-clean |
libs/RVL_SDK/src/cntcache/cntcache.c:266 |
assembly placeholder |
restored |
- asm int _CNTCACHEIsTitleRemovable(ESTitleId titleId) { | - clrlwi r11, r1, 0x1b | - mr r12, r1 | - subfic r11, r11, -0x2100 | - stwux r1, r1, r11 | - mflr r0 | - lis r5, scCntCacheTitleDataFmt@ha | - stw r0, 4(r12) | - li r0, 1 | - addi r5, r5, scCntCacheTitleDataFmt@l | - stw r31, -4(r12) | - stw r30, -8(r12) | - mr r30, r3 | - addi r3, r1, 0x40 | - stw r29, -0xc(r12) | - mr r29, r4 | - li r4, -1 | - stw r0, 0x20(r1) | - and r6, r30, r4 | - and r7, r29, r4 | - li r4, 0x40 | - stw r0, 0x24(r1) | - crclr 4*cr1+eq | - bl snprintf | - addi r3, r1, 0x40 | - addi r4, r1, 0x20 | - addi r5, r1, 0x24 | - bl NANDSecretGetUsage | - cmpwi r3, -0xc | - mr r4, r3 | - bne L_418 | - li r4, 2 | - b L_444 | - L_418: | - cmpwi r3, 0 | - blt L_444 | - lwz r0, 0x24(r1) | - cmplwi r0, 1 | - bne L_440 | - lwz r0, 0x20(r1) | - cmpwi r0, 0 | - bne L_440 | - li r4, 1 | - b L_444 | - L_440: | - li r4, 0 | - L_444: | - cmpwi r4, 1 | - bne L_4bc | - mr r4, r29 | - mr r3, r30 | - addi r31, r1, 0x80 | - addi r6, r1, 0x28 | - li r5, 0 | - bl ES_GetTmdView | - cmpwi r3, 0 | - beq L_470 | - b L_4c0 | - L_470: | - lwz r0, 0x28(r1) | - cmplwi r0, 0x2060 | - ble L_484 | - li r3, -0x400 | - b L_4c0 | - L_484: | - mr r4, r29 | - mr r3, r30 | - mr r5, r31 | - addi r6, r1, 0x28 | - bl ES_GetTmdView | - cmpwi r3, 0 | - beq L_4a4 | - b L_4c0 | - L_4a4: | - lhz r0, 0xd8(r1) | - rlwinm. r0, r0, 0x18, 0x18, 0x1f | - bne [see trial candidate in /tmp/rx56/trials] |
1828 -> 1500 |
280 -> 280 |
_CNTCACHEIsTitleRemovable 100% -> 87.42683% |
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 280 |
asm-cache-content-clean |
libs/RVL_SDK/src/cntcache/cntcache.c:360 |
assembly placeholder |
restored |
- asm void _CNTCACHEDeleteContent() { | - clrlwi r11, r1, 0x1b | - mr r12, r1 | - subfic r11, r11, -0x2100 | - stwux r1, r1, r11 | - mflr r0 | - mr r11, r12 | - stw r0, 4(r12) | - bl _savegpr_26 | - li r3, 0 | - la r4, scCntCacheSpaceNl | - bl strtok | - li r31, 0 | - li r4, 0 | - stw r31, errno(r0) | - li r5, 0x10 | - bl strtoull | - lwz r0, errno(r0) | - mr r29, r4 | - mr r30, r3 | - cmpwi r0, 0 | - bne L_708 | - li r0, -1 | - and r5, r3, r0 | - addis r0, r5, -1 | - cmplwi r0, 5 | - bne L_708 | - addi r28, r1, 0x80 | - addi r6, r1, 0x28 | - li r5, 0 | - bl ES_GetTmdView | - cmpwi r3, -0x6a | - beq L_708 | - cmpwi r3, 0 | - bne L_708 | - mr r4, r29 | - mr r3, r30 | - mr r5, r28 | - addi r6, r1, 0x28 | - bl ES_GetTmdView | - cmpwi r3, 0 | - bne L_708 | - lwz r3, 0x94(r1) | - rlwinm. r0, r3, 0, 0x1c, 0x1c | - beq L_6f0 | - rlwinm. r0, r3, 0, 0x1b, 0x1b | - beq L_6f0 | - li r3, 0 | - la r4, scCntCacheSpaceNl | - bl strtok | - li r26, 1 | - lis r27, scCntCacheTitleDataFmt@ha | - b L_6e8 | - L_5b0: | - stw r31, errno(r0) | - li r4, 0 | - li r5, 0xa | - bl strtoul | - lwz r0, errno(r0) | - cmpwi r0, 0 | - bne L_6dc | - cmplwi r3, 0x1fe | - bgt L_6dc | - lhz r0, 0xda(r1) | - li r4, 0 | - mtctr r0 | - cmplwi r0, 0 | - ble L_6dc | - L_5e8: | - add r5, r28, r4 | - lhz r0, 0x60(r5) | - cmplw r3, r0 | - bne L_6d4 | - lhz r0, 0x62(r5) | - rlwinm. r0, r0, 0, 0x10, 0x10 | - bne L_6dc | - lwz [see trial candidate in /tmp/rx56/trials] |
1828 -> 1248 |
280 -> 280 |
_CNTCACHEDeleteContent 100% -> 95.793106% |
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 281 |
asm-jpeg-restart-clean |
libs/RVLMiddleware/TMC_JPEG/src/jpegdec/jdec_main.c:903 |
assembly placeholder |
restored |
- #ifdef __MWERKS__ | - asm s32 TMCJPEGDEC_err_restart(register TMCCJPEGDecWork* work) { | - nofralloc | - stwu r1, -0x20(r1) | - mflr r0 | - stw r0, 0x24(r1) | - stw r31, 0x1c(r1) | - stw r30, 0x18(r1) | - mr r30, r3 | - stw r29, 0x14(r1) | - stw r28, 0x10(r1) | - lbz r0, 0x181c(r3) | - lwz r31, 0x19e4(r3) | - cmplwi r0, 1 | - bne _err_restart_rewind | - li r0, 0 | - li r3, 0 | - stw r0, 0x6cc(r31) | - b _err_restart_return | - _err_restart_rewind: | - bl TMCJPEGDEC_rewind_ptr | - cmpwi r3, 0 | - bge _err_restart_load_byte | - b _err_restart_return | - _err_restart_load_byte: | - lwz r3, 0xc(r30) | - lbz r0, 0(r3) | - stb r0, 8(r1) | - b _err_restart_check_byte | - _err_restart_read_byte: | - mr r4, r30 | - addi r3, r1, 8 | - bl TMCJPEGDEC_get_byte | - cmpwi r3, 0 | - bge _err_restart_check_byte | - b _err_restart_return | - _err_restart_check_byte: | - lbz r0, 8(r1) | - cmplwi r0, 0xff | - bne _err_restart_read_byte | - mr r4, r30 | - addi r3, r1, 8 | - bl TMCJPEGDEC_get_byte | - lbz r6, 8(r1) | - cmplwi r6, 0xd9 | - bne _err_restart_check_result | - cmpwi r3, 0 | - bge _err_restart_eoi | - cmpwi r3, -0x90 | - beq _err_restart_eoi | - b _err_restart_return | - _err_restart_eoi: | - li r3, 0 | - b _err_restart_return | - _err_restart_check_result: | - cmpwi r3, 0 | - bge _err_restart_check_marker | - b _err_restart_return | - _err_restart_check_marker: | - cmplwi r6, 0xd0 | - [see trial candidate in /tmp/rx56/trials] |
5604 -> 5144 |
256 -> 256 |
TMCJPEGDEC_err_restart 100% -> 82.791306% |
.rela.text, .symtab, .text |
True |
True |
| 282 |
jpeg-copy-wrapper |
libs/RVLMiddleware/TMC_JPEG/src/jpegdec/jdec_main.c:591 |
targeted source cleanup |
restored |
- typedef struct { | - u32 data[64]; | - } CopyBlock64; | - *(CopyBlock64*)d = *(CopyBlock64*)scJpegAanScale; | + memcpy(d, scJpegAanScale, sizeof(tblCopy)); |
5604 -> 5276 |
256 -> 256 |
TMCJPEGDEC_parse_dqt 100% -> 88.32927% |
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 283 |
aoss-integrity-branch-scope |
src/scene/setting/AOSS.c:1854 |
targeted source cleanup |
restored |
- struct { u32 expected; u32 actual; } integrity; | + u32 expectedChecksum; | - integrity.expected = message->checksum; | + expectedChecksum = message->checksum; | + u32 actualChecksum; | - integrity.actual = 0xffffffff; | + actualChecksum = 0xffffffff; | - integrity.actual = (integrity.actual >> 8) ^ s_crcTable[(integrity.actual ^ decryptedData[crcIndex]) & 0xff]; | + actualChecksum = (actualChecksum >> 8) ^ s_crcTable[(actualChecksum ^ decryptedData[crcIndex]) & 0xff]; | - if (((integrity.actual ^ 0xffffffff) & 0xff) != integrity.expected) { | + if (((actualChecksum ^ 0xffffffff) & 0xff) != expectedChecksum) { |
7720 -> 6436 |
3928 -> 3928 |
AOSSDecryptMessage 100% -> 99.75078% |
.strtab, .text |
True |
True |
| 284 |
asm-userid-out-of-line |
libs/RevoEX/src/nwc24/NWC24UserId.c:10 |
assembly placeholder |
restored |
- static NWC24UserId getUnScrambleId(NWC24UserId id); | + static NWC24UserId getUnScrambleId(NWC24UserId id) NO_INLINE; | - static asm NWC24UserId getUnScrambleId(register NWC24UserId id) { | - li r9,-1 | - lis r7,0x20 | - lis r6,0x5e5e | - stwu r1,-0x20(r1) | - subi r7,r7,1 | - and r8,r4,r9 | - addi r0,r6,0x5e5e | - stw r31,0x1c(r1) | - and r3,r3,r7 | - lis r5,-1 | - xor r8,r8,r0 | - stw r30,0x18(r1) | - and r8,r8,r9 | - xori r3,r3,0x5e5e | - rlwinm r0,r8,0x15,0xa,0xa | - li r6,-0x100 | - and r3,r3,r7 | - rlwinm r8,r8,0x1f,0,0x1f | - or r3,r3,r0 | - stw r29,0x14(r1) | - rlwimi r8,r3,0x1f,0,0 | - lis r4,-0xff | - rlwinm r7,r3,0x1f,1,0x1f | - addi r5,r5,0xff | - rlwinm r30,r8,0x18,0,0x1f | - rlwinm r29,r3,0x17,0x18,0x1f | - and r12,r7,r9 | - li r0,0 | - rlwimi r30,r3,0x17,0,7 | - and r31,r8,r6 | - rlwimi r31,r30,0,0x18,0x1f | - rlwinm r11,r3,0x1f,0x10,0x17 | - and r30,r31,r5 | - and r12,r12,r9 | - rlwimi r0,r29,8,0x18,0x1f | - subi r4,r4,1 | - or r12,r12,r0 | - or r11,r30,r11 | - and r30,r11,r4 | - rlwinm r31,r8,0,0x18,0x1f | - li r0,0 | - rlwinm r11,r8,0x10,8,0xf | - lis r10,0x100 | - and r12,r12,r9 | - rlwimi r0,r31,0x10,0x10,0x1f | - or r30,r30,r11 | - or r29,r12,r0 | - rlwinm r12,r3,0x1f,0x18,0x1f | - subi r0,r10,1 | - li r10,0 | - rlwimi r10,r12,0x18,8,0x1f | - and r11,r29,r9 | - and r12,r30,r0 | - rlwinm r3,r3,0x17,0,7 | - or r3,r12,r3 | - or r12,r11,r10 | - and r10,r3,r9 [see trial candidate in /tmp/rx56/trials] |
1032 -> 388 |
16 -> 16 |
getUnScrambleId 100% -> 76.27329% |
.comment, .rela.text, .sdata2, .shstrtab, .strtab, .symtab, .text |
True |
True |
| 285 |
wad-import-carrier |
libs/RVL_SDK/src/wad/wad.c:3499 |
targeted source cleanup |
compile rejected |
- struct { | - s32 type; | - u16 cidxMode; | - u16 version; | - u32 certificateSize; | - void* certificates; | - u32 crlSize; | - void* crls; | - u32 ticketSize; | - void* ticket; | - u32 titleMetaSize; | - void* titleMeta; | - } parts; | + s32 type; | + u16 cidxMode = 0; | + u32 certificateSize = 0; | + void* certificates = NULL; | + u32 crlSize = 0; | + void* crls = NULL; | + u32 ticketSize = 0; | + void* ticket = NULL; | + u32 titleMetaSize = 0; | + void* titleMetaData = NULL; | - memset(&parts, 0, sizeof(parts)); | - if (WAD_815C2F44(&header, &parts.type) != 2) { | + if (WAD_815C2F44(&header, &type) != 2) { | - parts.certificateSize = header.certSize; | - parts.certificates = readBuffer + sectionOffset; | + certificateSize = header.certSize; | + certificates = readBuffer + sectionOffset; | - parts.crlSize = header.crlSize; | - parts.crls = readBuffer + sectionOffset; | + crlSize = header.crlSize; | + crls = readBuffer + sectionOffset; | - parts.ticketSize = header.ticketSize; | - parts.ticket = readBuffer + sectionOffset; | + ticketSize = header.ticketSize; | + ticket = readBuffer + sectionOffset; | - parts.titleMetaSize = header.tmdSize; | - parts.titleMeta = readBuffer + sectionOffset; | + titleMetaSize = header.tmdSize; | + titleMetaData = readBuffer + sectionOffset; | - if (parts.type == 3) { | + if (type == 3) { | - if (parts.ticket != 0) { | - result = ES_ImportTicket [see trial candidate in /tmp/rx56/trials] |
|
|
|
|
not measured |
not measured |
| 286 |
dvd-volatile-single-0 |
libs/RVL_SDK/src/dvd/dvd.c:1897 |
volatile cast |
kept |
- if (((volatile DVDCommandBlock*)block)->state == DVD_STATE_COVER_CLOSED) { | + if (block->state == DVD_STATE_COVER_CLOSED) { |
21692 -> 21692 |
20688 -> 20688 |
|
|
True |
True |
| 287 |
dvd-volatile-single-1 |
libs/RVL_SDK/src/dvd/dvd.c:1907 |
volatile cast |
kept |
- retVal = ((volatile DVDCommandBlock*)block)->state; | + retVal = block->state; |
21692 -> 21692 |
20688 -> 20688 |
|
|
True |
True |
| 288 |
dvd-volatile-single-2 |
libs/RVL_SDK/src/dvd/dvd.c:1917 |
volatile cast |
restored |
- retVal = ((volatile DVDCommandBlock*)block)->state; | + retVal = block->state; |
21692 -> 21492 |
20688 -> 20688 |
DVDGetCommandBlockStatus 100% -> 89.94% |
.rela.text, .strtab, .text |
True |
True |
| 289 |
dvd-volatile-single-3 |
libs/RVL_SDK/src/dvd/dvd.c:2180 |
volatile cast |
kept |
- state = ((volatile DVDCommandBlock*)block)->state; | + state = block->state; |
21692 -> 21692 |
20688 -> 20688 |
|
|
True |
True |
| 290 |
rso-volatile-single-0 |
src/system/RsoSystem.cpp:14 |
volatile cast |
restored |
- GXColor front = {*((volatile const unsigned char*)&scRsoFatalColorR), *((volatile const unsigned char*)&scRsoFatalColorG), *((volatile const unsigned char*)&scRsoFatalColorB), *((volatile const unsigned char*)&scRsoFatalColorA)}; \ | + GXColor front = {scRsoFatalColorR, *((volatile const unsigned char*)&scRsoFatalColorG), *((volatile const unsigned char*)&scRsoFatalColorB), *((volatile const unsigned char*)&scRsoFatalColorA)}; \ |
2848 -> 2640 |
96 -> 96 |
GetTextColor__Q34nw4r3lyt7TextBoxCFUl 100% -> 90.96154% |
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 291 |
rso-volatile-single-1 |
src/system/RsoSystem.cpp:14 |
volatile cast |
restored |
- GXColor front = {*((volatile const unsigned char*)&scRsoFatalColorR), *((volatile const unsigned char*)&scRsoFatalColorG), *((volatile const unsigned char*)&scRsoFatalColorB), *((volatile const unsigned char*)&scRsoFatalColorA)}; \ | + GXColor front = {*((volatile const unsigned char*)&scRsoFatalColorR), scRsoFatalColorG, *((volatile const unsigned char*)&scRsoFatalColorB), *((volatile const unsigned char*)&scRsoFatalColorA)}; \ |
2848 -> 2640 |
96 -> 96 |
GetTextColor__Q34nw4r3lyt7TextBoxCFUl 100% -> 91.05769% |
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 292 |
rso-volatile-single-2 |
src/system/RsoSystem.cpp:14 |
volatile cast |
restored |
- GXColor front = {*((volatile const unsigned char*)&scRsoFatalColorR), *((volatile const unsigned char*)&scRsoFatalColorG), *((volatile const unsigned char*)&scRsoFatalColorB), *((volatile const unsigned char*)&scRsoFatalColorA)}; \ | + GXColor front = {*((volatile const unsigned char*)&scRsoFatalColorR), *((volatile const unsigned char*)&scRsoFatalColorG), scRsoFatalColorB, *((volatile const unsigned char*)&scRsoFatalColorA)}; \ |
2848 -> 2640 |
96 -> 96 |
GetTextColor__Q34nw4r3lyt7TextBoxCFUl 100% -> 91.15385% |
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 293 |
rso-volatile-single-3 |
src/system/RsoSystem.cpp:14 |
volatile cast |
restored |
- GXColor front = {*((volatile const unsigned char*)&scRsoFatalColorR), *((volatile const unsigned char*)&scRsoFatalColorG), *((volatile const unsigned char*)&scRsoFatalColorB), *((volatile const unsigned char*)&scRsoFatalColorA)}; \ | + GXColor front = {*((volatile const unsigned char*)&scRsoFatalColorR), *((volatile const unsigned char*)&scRsoFatalColorG), *((volatile const unsigned char*)&scRsoFatalColorB), scRsoFatalColorA}; \ |
2848 -> 2640 |
96 -> 96 |
GetTextColor__Q34nw4r3lyt7TextBoxCFUl 100% -> 92.88461% |
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 294 |
nwc-volatile-single-0 |
src/system/iplNwc24Manager.cpp:936 |
volatile cast |
restored |
- *(volatile const NWC24DlId*)&DL_ID_0, | + DL_ID_0, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 94.21429% |
.comment, .rela.data, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 295 |
nwc-volatile-single-1 |
src/system/iplNwc24Manager.cpp:937 |
volatile cast |
restored |
- *(volatile const NWC24DlId*)&DL_ID_1, | + DL_ID_1, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 97.581635% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 296 |
nwc-volatile-single-2 |
src/system/iplNwc24Manager.cpp:938 |
volatile cast |
restored |
- *(volatile const NWC24DlId*)&DL_ID_5, | + DL_ID_5, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 97.57143% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 297 |
nwc-volatile-single-3 |
src/system/iplNwc24Manager.cpp:939 |
volatile cast |
restored |
- *(volatile const NWC24DlId*)&DL_ID_6, | + DL_ID_6, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 97.561226% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 298 |
nwc-volatile-single-4 |
src/system/iplNwc24Manager.cpp:942 |
volatile cast |
restored |
- *(volatile const u16*)&DL_INTERVAL_0, | + DL_INTERVAL_0, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 97.80612% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 299 |
nwc-volatile-single-5 |
src/system/iplNwc24Manager.cpp:943 |
volatile cast |
restored |
- *(volatile const u16*)&DL_INTERVAL_1, | + DL_INTERVAL_1, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 97.78571% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 300 |
nwc-volatile-single-6 |
src/system/iplNwc24Manager.cpp:944 |
volatile cast |
restored |
- *(volatile const u16*)&DL_INTERVAL_2, | + DL_INTERVAL_2, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 97.77551% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 301 |
nwc-volatile-single-7 |
src/system/iplNwc24Manager.cpp:945 |
volatile cast |
restored |
- *(volatile const u16*)&DL_INTERVAL_3, | + DL_INTERVAL_3, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 97.765305% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 302 |
nwc-volatile-single-8 |
src/system/iplNwc24Manager.cpp:948 |
volatile cast |
restored |
- *(volatile const u8*)&DL_PRIORITY_0, | + DL_PRIORITY_0, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 99.84694% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 303 |
nwc-volatile-single-9 |
src/system/iplNwc24Manager.cpp:949 |
volatile cast |
restored |
- *(volatile const u8*)&DL_PRIORITY_1, | + DL_PRIORITY_1, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 99.82653% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 304 |
nwc-volatile-single-10 |
src/system/iplNwc24Manager.cpp:950 |
volatile cast |
restored |
- *(volatile const u8*)&DL_PRIORITY_2, | + DL_PRIORITY_2, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 99.81633% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 305 |
nwc-volatile-single-11 |
src/system/iplNwc24Manager.cpp:951 |
volatile cast |
restored |
- *(volatile const u8*)&DL_PRIORITY_3, | + DL_PRIORITY_3, |
10252 -> 9860 |
888 -> 848 |
addDlTask__Q33ipl5nwc247ManagerFv 100% -> 99.80612% |
.comment, .rela.text, .sdata2, .strtab, .symtab, .text |
True |
True |
| 306 |
wd-volatile-single-0 |
libs/RevoEX/src/wd/WDScan.c:34 |
volatile cast |
restored |
- #define scRsnOui0 (*((volatile const u8*)&scRsnOui0)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 95.90435% |
.rela.text, .symtab, .text |
True |
True |
| 307 |
wd-volatile-single-1 |
libs/RevoEX/src/wd/WDScan.c:35 |
volatile cast |
restored |
- #define scRsnOui1 (*((volatile const u8*)&scRsnOui1)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 97.17391% |
.rela.text, .text |
True |
True |
| 308 |
wd-volatile-single-2 |
libs/RevoEX/src/wd/WDScan.c:36 |
volatile cast |
restored |
- #define scRsnOui2 (*((volatile const u8*)&scRsnOui2)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 97.21739% |
.rela.text, .text |
True |
True |
| 309 |
wd-volatile-single-3 |
libs/RevoEX/src/wd/WDScan.c:37 |
volatile cast |
restored |
- #define scWpaOui0 (*((volatile const u8*)&scWpaOui0)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 97.13043% |
.rela.text, .text |
True |
True |
| 310 |
wd-volatile-single-4 |
libs/RevoEX/src/wd/WDScan.c:38 |
volatile cast |
restored |
- #define scWpaOui1 (*((volatile const u8*)&scWpaOui1)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 97.17391% |
.rela.text, .text |
True |
True |
| 311 |
wd-volatile-single-5 |
libs/RevoEX/src/wd/WDScan.c:39 |
volatile cast |
restored |
- #define scWpaOui2 (*((volatile const u8*)&scWpaOui2)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 97.21739% |
.rela.text, .text |
True |
True |
| 312 |
wd-volatile-single-6 |
libs/RevoEX/src/wd/WDScan.c:40 |
volatile cast |
restored |
- #define scWpaFindOui0 (*((volatile const u8*)&scWpaFindOui0)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 94.295654% |
.rela.text, .text |
True |
True |
| 313 |
wd-volatile-single-7 |
libs/RevoEX/src/wd/WDScan.c:41 |
volatile cast |
restored |
- #define scWpaFindOui1 (*((volatile const u8*)&scWpaFindOui1)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 94.252174% |
.rela.text, .text |
True |
True |
| 314 |
wd-volatile-single-8 |
libs/RevoEX/src/wd/WDScan.c:42 |
volatile cast |
restored |
- #define scWpaFindOui2 (*((volatile const u8*)&scWpaFindOui2)) |
2180 -> 1720 |
16 -> 16 |
WDGetPrivacyMode 100% -> 94.208694% |
.rela.text, .text |
True |
True |
| 315 |
osinit-reboot-volatile |
libs/RVL_SDK/src/os/OS.c:521 |
volatile cast |
kept |
- volatile OSExecParams* params = (volatile OSExecParams*)&__OSRebootParams; | + OSExecParams* params = &__OSRebootParams; |
5084 -> 5084 |
1240 -> 1240 |
|
|
True |
True |
| 316 |
wad-import-clean-sections |
libs/RVL_SDK/src/wad/wad.c:3499 |
targeted source cleanup |
restored |
- struct { | - s32 type; | - u16 cidxMode; | - u16 version; | - u32 certificateSize; | - void* certificates; | - u32 crlSize; | - void* crls; | - u32 ticketSize; | - void* ticket; | - u32 titleMetaSize; | - void* titleMeta; | - } parts; | + s32 type; | + u32 certificateSize = 0; | + void* certificates = NULL; | + u32 crlSize = 0; | + void* crls = NULL; | + u32 ticketSize = 0; | + void* ticket = NULL; | + u32 titleMetaSize = 0; | + void* titleMetaData = NULL; | - memset(&parts, 0, sizeof(parts)); | - if (WAD_815C2F44(&header, &parts.type) != 2) { | + if (WAD_815C2F44(&header, &type) != 2) { | - parts.certificateSize = header.certSize; | - parts.certificates = readBuffer + sectionOffset; | + certificateSize = header.certSize; | + certificates = readBuffer + sectionOffset; | - parts.crlSize = header.crlSize; | - parts.crls = readBuffer + sectionOffset; | + crlSize = header.crlSize; | + crls = readBuffer + sectionOffset; | - parts.ticketSize = header.ticketSize; | - parts.ticket = readBuffer + sectionOffset; | + ticketSize = header.ticketSize; | + ticket = readBuffer + sectionOffset; | - parts.titleMetaSize = header.tmdSize; | - parts.titleMeta = readBuffer + sectionOffset; | + titleMetaSize = header.tmdSize; | + titleMetaData = readBuffer + sectionOffset; | - if (parts.type == 3) { | + if (type == 3) { | - if (parts.ticket != 0) { | - result = ES_ImportTicket(parts.ticket, parts.c [see trial candidate in /tmp/rx56/trials] |
24500 -> 23448 |
528 -> 528 |
WADImportDVDExForBS 100% -> 72.37643% |
.rela.text, .strtab, .symtab, .text |
True |
True |
| 317 |
dvd-volatile-remainder-3 |
libs/RVL_SDK/src/dvd/dvd.c:2187 |
volatile cast |
kept |
- command = ((volatile DVDCommandBlock*)block)->command; | + command = block->command; |
21692 -> 21692 |
20688 -> 20688 |
|
|
True |
True |
| 318 |
dvd-volatile-remainder-2 |
libs/RVL_SDK/src/dvd/dvd.c:1917 |
volatile cast |
restored |
- retVal = ((volatile DVDCommandBlock*)block)->state; | + retVal = block->state; |
21692 -> 21492 |
20688 -> 20688 |
DVDGetCommandBlockStatus 100% -> 89.94% |
.rela.text, .strtab, .text |
True |
True |
| 319 |
dvd-volatile-remainder-1 |
libs/RVL_SDK/src/dvd/dvd.c:1913 |
volatile cast |
kept |
- retVal = ((volatile DVDCommandBlock*)block)->state; | + retVal = block->state; |
21692 -> 21692 |
20688 -> 20688 |
|
|
True |
True |
| 320 |
dvd-volatile-remainder-0 |
libs/RVL_SDK/src/dvd/dvd.c:1899 |
volatile cast |
restored |
- } else if (((volatile DVDCommandBlock*)block)->state == DVD_STATE_COVER_OPENED) { | + } else if (block->state == DVD_STATE_COVER_OPENED) { |
21692 -> 21492 |
20688 -> 20688 |
DVDGetCommandBlockStatus 100% -> 98% |
.rela.text, .symtab, .text |
True |
True |
| 321 |
vm-chunk-union-split |
src/channelScript/CHANSVm.c:347 |
targeted source cleanup |
restored |
- union { | - u32 off; | - ChunkEntry* entry; | - } u; | + u32 chunkOffset; | + ChunkEntry* entry; | - u.off = 0; | + chunkOffset = 0; | - u.off = idx + (chunkIdx << 10); | - idx = u.off; | + chunkOffset = idx + (chunkIdx << 10); | + idx = chunkOffset; | - u.off += 4; | + chunkOffset += 4; | - u.off = 0; | + entry = vmNull; | - u.entry = &chunk[idx & 0x3FF]; | - memset(u.entry, 0, sizeof(CHANSVmObjHdr)); | - u.entry->inUse = 1; | + entry = &chunk[idx & 0x3FF]; | + memset(entry, 0, sizeof(CHANSVmObjHdr)); | + entry->inUse = 1; | - return u.entry; | + return entry; |
44588 -> 44204 |
6904 -> 6904 |
CHANSVmNewObjData 100% -> 99.375% |
.strtab, .text |
True |
True |
| 322 |
vm-chunk-no-dead-offset |
src/channelScript/CHANSVm.c:347 |
targeted source cleanup |
restored |
- union { | - u32 off; | - ChunkEntry* entry; | - } u; | + ChunkEntry* entry; | - u.off = 0; | - u.off = idx + (chunkIdx << 10); | - idx = u.off; | + idx += chunkIdx << 10; | - u.off += 4; | - u.off = 0; | + entry = vmNull; | - u.entry = &chunk[idx & 0x3FF]; | - memset(u.entry, 0, sizeof(CHANSVmObjHdr)); | - u.entry->inUse = 1; | + entry = &chunk[idx & 0x3FF]; | + memset(entry, 0, sizeof(CHANSVmObjHdr)); | + entry->inUse = 1; | - return u.entry; | + return entry; |
44588 -> 44204 |
6904 -> 6904 |
CHANSVmNewObjData 100% -> 99.375% |
.text |
True |
True |
| 323 |
address-message-union-split |
src/scene/address/iplAddress.cpp:1628 |
targeted source cleanup |
restored |
- union MessageValue { | - const wchar_t* text; | - u32 id; | - } message; | - message.text = System::getMessage(MESG_ERROR_CODE); | - wcsncat(errMsg, message.text, errMsgLen - wcslen(errMsg)); | + const wchar_t* messageText; | + u32 messageId; | + messageText = System::getMessage(MESG_ERROR_CODE); | + wcsncat(errMsg, messageText, errMsgLen - wcslen(errMsg)); | - message.id = MESG_ERROR_NWC24_NETWORK; | + messageId = MESG_ERROR_NWC24_NETWORK; | - message.id = MESG_ERROR_NWC24_SERVER; | + messageId = MESG_ERROR_NWC24_SERVER; | - message.id = reinterpret_cast<u32>(message.text); | + messageId = reinterpret_cast<u32>(messageText); | - message.text = System::getMessage(message.id); | - wcsncat(errMsg, message.text, errMsgLen - wcslen(errMsg)); | + messageText = System::getMessage(messageId); | + wcsncat(errMsg, messageText, errMsgLen - wcslen(errMsg)); |
23988 -> 23668 |
1964 -> 1964 |
set_err_msg__Q33ipl5scene7AddressFPwUl8NWC24Err 100% -> 99.875% |
.strtab, .text |
True |
True |
| 324 |
address-message-scoped |
src/scene/address/iplAddress.cpp:1628 |
targeted source cleanup |
restored |
- union MessageValue { | - const wchar_t* text; | - u32 id; | - } message; | - message.text = System::getMessage(MESG_ERROR_CODE); | - wcsncat(errMsg, message.text, errMsgLen - wcslen(errMsg)); | + const wchar_t* messageText; | + messageText = System::getMessage(MESG_ERROR_CODE); | + wcsncat(errMsg, messageText, errMsgLen - wcslen(errMsg)); | + u32 messageId; | - message.id = MESG_ERROR_NWC24_NETWORK; | + messageId = MESG_ERROR_NWC24_NETWORK; | - message.id = MESG_ERROR_NWC24_SERVER; | + messageId = MESG_ERROR_NWC24_SERVER; | - message.id = reinterpret_cast<u32>(message.text); | + messageId = reinterpret_cast<u32>(messageText); | - message.text = System::getMessage(message.id); | - wcsncat(errMsg, message.text, errMsgLen - wcslen(errMsg)); | + messageText = System::getMessage(messageId); | + wcsncat(errMsg, messageText, errMsgLen - wcslen(errMsg)); |
23988 -> 23668 |
1964 -> 1964 |
set_err_msg__Q33ipl5scene7AddressFPwUl8NWC24Err 100% -> 99.875% |
.strtab, .text |
True |
True |
| 325 |
ncd-mac-separate-representations |
src/scene/setting/iplNCDSetting.cpp:767 |
targeted source cleanup |
restored |
- union { | - char str[sizeof("XX-XX-XX-XX-XX-XX")]; | - u64 num; | - u8 bytes[8]; | - } PACKED mac; | + char macText[sizeof("XX-XX-XX-XX-XX-XX")]; | + u64 macNumber = 0; | - sprintf(mac.str, "%02x-%02x-%02x-%02x-%02x-%02x", macAddress[0], macAddress[1], macAddress[2], macAddress[3], macAddress[4], | + sprintf(macText, "%02x-%02x-%02x-%02x-%02x-%02x", macAddress[0], macAddress[1], macAddress[2], macAddress[3], macAddress[4], | - OSReport("MAC: %s\n", &mac); | + OSReport("MAC: %s\n", macText); | - utility::CharacterCode::ANSIToUTF8((char*)mMac, (u8*)&mac); | + utility::CharacterCode::ANSIToUTF8((char*)mMac, (u8*)macText); | - memset(&mac, 0, sizeof(mac.str)); | - memcpy(mac.bytes + 2, &macAddress, 6); | + memcpy((u8*)&macNumber + 2, &macAddress, 6); | - mMacNum = mac.num % 100000000; | - OSReport("%lld %d\n", mMacNum, mac.num, mMacNum); | + mMacNum = macNumber % 100000000; | + OSReport("%lld %d\n", mMacNum, macNumber, mMacNum); |
6796 -> 6488 |
14232 -> 14232 |
makeMacAddr__Q33ipl3ncd10NCDSettingFv 100% -> 88.87013% |
.rela.text, .symtab, .text |
True |
True |
| 326 |
placement-0 |
src/scene/calendar/iplDate.cpp:17 |
section/retention pragma |
restored |
- #pragma section const_type ".data" | - #pragma section const_type ".data" | - #pragma section const_type ".sdata" | - #pragma section sconst_type ".sdata2" |
2868 -> 2868 |
356 -> 252 |
|
.data, .rela.data, .rodata, .symtab |
False |
False |
| 327 |
placement-1 |
src/scene/channelTitle/iplChannelTitle.cpp:151 |
section/retention pragma |
kept |
- #pragma section data_type ".sdata" |
28788 -> 28788 |
3144 -> 3144 |
|
|
True |
True |
| 328 |
placement-2 |
src/scene/channelEdit/iplChanAppBox.cpp:6 |
section/retention pragma |
restored |
- #pragma section const_type ".data" | - #pragma section const_type ".sdata" | - #pragma section sconst_type ".sdata2" |
3532 -> 2808 |
536 -> 520 |
draw__Q33ipl5scene10ChanAppBoxFv 100% -> 99.392265% |
.data, .rela.data, .rela.text, .rodata, .strtab, .symtab, .text |
False |
False |
| 329 |
placement-3 |
src/system/iplNwc24Manager.cpp:4 |
section/retention pragma |
kept |
- #pragma force_active on | - #pragma force_active off |
10252 -> 10252 |
888 -> 888 |
|
|
True |
True |
| 330 |
placement-4 |
src/system/iplKeyboard.cpp:48 |
section/retention pragma |
restored |
- #pragma force_active on | - #pragma force_active off |
6024 -> 6024 |
1184 -> 1184 |
|
.comment |
True |
True |
| 331 |
placement-5 |
src/homebutton/HBMBase.cpp:46 |
section/retention pragma |
restored |
- #pragma force_active on | - #pragma force_active off |
23608 -> 23608 |
3800 -> 3800 |
|
.comment |
True |
True |
| 332 |
placement-6 |
src/channelScript/systemmenu/iplCSPane.cpp:624 |
section/retention pragma |
restored |
- #pragma section const_type ".data" | - #pragma section data_type ".sdata" |
5804 -> 5804 |
672 -> 320 |
|
.data, .rodata, .symtab |
False |
False |
| 333 |
placement-7 |
libs/RevoEX/src/cdb/CDBDatabase.c:81 |
section/retention pragma |
kept |
- #pragma section sdata_type ".sdata" | - #pragma section data_type ".data" |
12152 -> 12152 |
312 -> 312 |
|
|
True |
True |
| 334 |
placement-8 |
libs/RevoEX/src/ssl/ssl_api.c:552 |
section/retention pragma |
kept |
- #pragma section data_type ".data" | - #pragma section data_type ".sdata" |
3404 -> 3404 |
12424 -> 12424 |
|
|
True |
True |
| 335 |
placement-9 |
libs/RevoEX/src/wd/WDScan.c:12 |
section/retention pragma |
restored |
- #pragma section sconst_type ".sdata2" | - #pragma section sconst_type ".sdata" |
2180 -> 2180 |
16 -> 8 |
|
.comment, .rela.text, .sdata, .sdata2, .shstrtab, .symtab |
True |
True |
| 336 |
ssl-empty-section-blocks |
libs/RevoEX/src/ssl/ssl_api.c:551 |
section/retention pragma |
kept |
- #pragma push | - #pragma pop | - #pragma push | - #pragma pop |
3404 -> 3404 |
12424 -> 12424 |
|
|
True |
True |
| 337 |
channel-title-empty-section-block |
src/scene/channelTitle/iplChannelTitle.cpp:150 |
section/retention pragma |
kept |
- #pragma push | - #pragma pop |
28788 -> 28788 |
3144 -> 3144 |
|
|
True |
True |
| 338 |
ssl-final-newline |
libs/RevoEX/src/ssl/ssl_api.c:550 |
targeted source cleanup |
kept |
|
3404 -> 3404 |
12424 -> 12424 |
|
|
True |
True |
| 339 |
nand-thumbnail-parentheses |
src/system/iplNandSDWorker.cpp:3936 |
targeted source cleanup |
kept |
- ret = read_file(fd, fileKind, iconBinOffset, thumbnailSize, (appBnrOut)->thumbnail); | + ret = read_file(fd, fileKind, iconBinOffset, thumbnailSize, appBnrOut->thumbnail); |
51428 -> 51428 |
12312 -> 12312 |
|
|
True |
True |
| 340 |
nwc-include-spacing |
src/system/iplNwc24Manager.cpp:6 |
targeted source cleanup |
kept |
|
10252 -> 10252 |
888 -> 888 |
|
|
True |
True |
| 341 |
nand-close-dummy |
src/system/iplNand.cpp:278 |
targeted source cleanup |
restored |
- // Seems like there was going to be logic when close_ returns false, but it seemed like it was not included on release. | - // However it did left the compare instruction! | - if (!close_()) { | - u32 dummy = 0; | - } | + close_(); |
5108 -> 4340 |
272 -> 272 |
read__Q33ipl4nand4FileFv 100% -> 99.479164% |
.rela.text, .strtab, .symtab, .text |
True |
True |
| 342 |
schedule-protected-dummy |
libs/RevoEX/src/nwc24/NWC24Schedule.c:184 |
targeted source cleanup |
restored |
- } else if (result == NWC24_ERR_PROTECTED) { | - // Stripped out but left out if statement | - u32 dummy = 0; |
4140 -> 3852 |
584 -> 584 |
NWC24ExecDownloadTask 100% -> 97.083336% |
.rela.text, .strtab, .symtab, .text |
True |
True |
| 343 |
mime-impossible-condition-dummy |
libs/RevoEX/src/nwc24/NWC24Parser.c:41 |
targeted source cleanup |
restored |
- if (conv && !conv) { | - u32 dummy = 0; | - } |
1512 -> 1440 |
784 -> 784 |
NWC24GetMIMETypeStr 100% -> 93.333336% |
.rela.text, .text |
True |
True |
| 344 |
sdi-switch-dummy |
libs/RVL_SDK/src/sdi/sdi_api.c:314 |
targeted source cleanup |
restored |
- switch (ret) { | - case IPC_RESULT_ACCESS: | - case IPC_RESULT_EXISTS: { | - int dummy = 0; | - } | - } |
5948 -> 5356 |
248 -> 248 |
ISD_ProbeCard 100% -> 96.8421%; ISD_MountCard 100% -> 94.33962% |
.line, .rela.debug, .rela.text, .strtab, .symtab, .text |
True |
True |
| 345 |
ncd-mutex-padding |
libs/RevoEX/src/ncd/ncdsystem.c:15 |
targeted source cleanup |
restored |
- struct NCDMutex { | - OSMutex mutex; | - u8 padding[8]; | - } ncdMutex; | + OSMutex ncdMutex; | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSUnlockMutex(&ncdMutex.mutex); | + OSUnlockMutex(&ncdMutex); | - OSInitMutex(&ncdMutex.mutex); | + OSInitMutex(&ncdMutex); | - OSLockMutex(&ncdMutex.mutex); | + OSLockMutex(&ncdMutex); |
4180 -> 4180 |
496 -> 400 |
|
.symtab |
True |
True |
| 346 |
flags-byte-output |
src/utility/iplCSFlags.cpp:17 |
targeted source cleanup |
kept |
- u32 dummy; | + u8 fileType; | - s32 result = NANDPrivateGetType(FLAG_FILE_PATH, (u8*)&dummy); | + s32 result = NANDPrivateGetType(FLAG_FILE_PATH, &fileType); |
1172 -> 1172 |
816 -> 816 |
|
|
True |
True |
| 347 |
vf-empty-file-status-assigned |
libs/RevoEX/src/vf/fatfs/pf_file.c:600 |
targeted source cleanup |
restored |
- // stinky fakematch | - #ifdef DEBUG | - #endif | - #ifdef DEBUG | - #else | - if (VFiPFENT_InitENT(p_ent, p_fname, 0x20U, 1U, p_parent_ent, p_vol) == 0) | - #endif | - #ifdef DEBUG | - #else | - if (VFiPFENT_allocateEntry(p_ent, (p_ent->num_entry_LFNs + 1), &ffd, prev_chain, p_fname, 0x77U, &pos) == 0) | - #endif |
14052 -> 12652 |
0 -> 0 |
VFiPFFILE_p_fopen 100% -> 85.597145% |
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 348 |
vf-empty-file-status-no-initial-store |
libs/RevoEX/src/vf/fatfs/pf_file.c:600 |
targeted source cleanup |
kept |
- // stinky fakematch | - #ifdef DEBUG | - err = 0; | - #endif | - #ifdef DEBUG | - #else | - if (VFiPFENT_InitENT(p_ent, p_fname, 0x20U, 1U, p_parent_ent, p_vol) == 0) | - #endif | - #ifdef DEBUG | - #else | - if (VFiPFENT_allocateEntry(p_ent, (p_ent->num_entry_LFNs + 1), &ffd, prev_chain, p_fname, 0x77U, &pos) == 0) | - #endif |
14052 -> 14052 |
0 -> 0 |
|
|
True |
True |
| 349 |
vf-empty-file-status-early-return |
libs/RevoEX/src/vf/fatfs/pf_file.c:607 |
targeted source cleanup |
restored |
- if (err == 0) | - { | - VFiPFFAT_InitFFD(&ffd, &hint, p_vol, &p_parent_ent->start_cluster); | - err = VFiPFENT_allocateEntry(p_ent, (p_ent->num_entry_LFNs + 1), &ffd, prev_chain, p_fname, 0x77U, &pos); | - if (err == 0) | - { | - p_ent->start_cluster = 0; | - if ((p_ent->long_name[0] != 0) && ((VFipf_vol_set.setting & 2) == 2)) { | - VFiPFPATH_AdjustExtShortName(p_ent->short_name, pos); | - p_ent->check_sum = VFiPFENT_CalcCheckSum(p_ent); | - } | - err = VFiPFENT_UpdateEntry(p_ent, prev_chain, 0U); | - } | + if (err != 0) { | + return err; | - return err; | + VFiPFFAT_InitFFD(&ffd, &hint, p_vol, &p_parent_ent->start_cluster); | + err = VFiPFENT_allocateEntry(p_ent, p_ent->num_entry_LFNs + 1, &ffd, prev_chain, p_fname, 0x77U, &pos); | + if (err != 0) { | + return err; | + } | + p_ent->start_cluster = 0; | + if (p_ent->long_name[0] != 0 && (VFipf_vol_set.setting & 2) == 2) { | + VFiPFPATH_AdjustExtShortName(p_ent->short_name, pos); | + p_ent->check_sum = VFiPFENT_CalcCheckSum(p_ent); | + } | + return VFiPFENT_UpdateEntry(p_ent, prev_chain, 0U); |
14052 -> 12652 |
0 -> 0 |
VFiPFFILE_p_fopen 100% -> 85.597145% |
.comment, .rela.text, .strtab, .symtab, .text |
True |
True |
| 350 |
nand-force-stack-weaks |
src/system/iplNandSDWorker.cpp:39 |
targeted source cleanup |
restored |
- #ifndef NON_MATCHING | - // this could work as a seperate unit??? | - void forceStackWeaks() { | - ut::FreeList freeList; | - freeList.init(NULL, 0, 0); | - freeList.get(); | - ut::Stack stack; | - stack.init(NULL, 0, 0); | - stack.push(NULL); | - stack.pop(NULL); | - } | - #endif |
51428 -> 50036 |
12312 -> 12312 |
push__Q33ipl2ut5StackFPCv 100% -> 50.866665%; recursion_nand__Q23ipl12NandSDWorkerFPCcPCcQ33ipl12NandSDWorker16RecursiveProcessPPCcUl 100% -> 82.701256% |
.comment, .debug, .line, .rela.data, .rela.debug, .rela.line, .rela.rodata, .rela.sdata, .rela.sdata2, .rela.text, .strtab, .symtab, .text |
True |
True |
| 351 |
nand-thumbnail-md5-helper |
src/system/iplNandSDWorker.cpp:3688 |
targeted source cleanup |
restored |
- // FAKEMATCH: Should be using NETCalcMD5, but thumbPtr had to ruin everything. | - NETMD5Context context; | - NETMD5Init(&context); | - void* thumbPtr; | - thumbPtr = sdBanner->thumbnail; | - NETMD5Update(&context, thumbPtr, wadOffset - sizeof(SDAppBanner)); | - NETMD5GetDigest(&context, MD5Sum); | + void* thumbPtr = sdBanner->thumbnail; | + NETCalcMD5(MD5Sum, thumbPtr, wadOffset - sizeof(SDAppBanner)); |
51428 -> 50100 |
12312 -> 12312 |
do_copy_nand_app_to_sd__Q23ipl12NandSDWorkerFv 100% -> 98.72891% |
.comment, .debug, .line, .rela.data, .rela.debug, .rela.line, .rela.text, .strtab, .symtab, .text |
True |
True |
| 352 |
channel-time-remainder |
src/scene/channelTitle/iplChannelTitle.cpp:2558 |
targeted source cleanup |
restored |
- // FAKEMATCH: should be modular division. not whatever this is | - *minute = (mTimeLimitRemain - ((60 * 60) * *hour)) / 60; | - //*minute = (u32)(mTimeLimitRemain % (60 * 60)) / 60U; | + *minute = mTimeLimitRemain % (60 * 60) / 60; |
28788 -> 28720 |
3144 -> 3144 |
isTimeLimitedChannel__Q33ipl5scene12ChannelTitleFPUlPUl 100% -> 80.29412% |
.rela.text, .symtab, .text |
True |
True |
| 353 |
vf-empty-file-braces |
libs/RevoEX/src/vf/fatfs/pf_file.c:610 |
targeted source cleanup |
kept |
- if (err == 0) | - { | + if (err == 0) { | - if (err == 0) | - { | + if (err == 0) { |
14052 -> 14052 |
0 -> 0 |
|
|
True |
True |